Post order traversal of min heap

[lost110]

The code is showing the right children for data: 1,2,3,4,5
but shows wrong left and right children for data: 10,8,3,5,12
Kindly help!

#include <iostream>
using namespace std;
using namespace std;
void min_heapify(int *a, int i, int n)
{
	int j, temp;
	temp = a[i];
	j = 2 * i;
	while (j <= n)
	{
		if (j < n && a[j + 1] < a[j])
			j = j + 1;
		if (temp < a[j])
			break;
		else if (temp >= a[j])
		{
			a[j / 2] = a[j];
			j = 2 * j;
		}
	}
	a[j / 2] = temp;
	return;
}
void build_minheap(int *a, int n)
{
	int i;
	for (i = n / 2; i >= 1; i--)
	{
		min_heapify(a, i, n);
	}
}
void postorder(int arr[], int size, int i) {
	if (i > size)
		return;
	if (i <= size) {
			cout << "parrent: " << arr[i];
			if (2 * i  <= size)
				cout << "\tleft: " << arr[2 * i];
			if (2 * i + 1 <= size)
				cout << "\tright: " << arr[2 * i + 1];

		}
	cout << endl;
	postorder(arr, size, i + 1);
}
int main()
{
	int n, i, x;
	cout << "enter no of elements of array\n";
	cin >> n;
	int a[20];
	for (i = 1; i <= n; i++)
	{
		cout << "enter element" << (i) << endl;
		cin >> a[i];
	}
	build_minheap(a, n);
	cout << "Min Heap\n";
	postorder(a, n, 1);
	/*for (i = 1; i <= n; i++)
	{
		cout << a[i] << endl;
	}*/
	system("pause");
}

[dhayden]

In C++, arrays are indexed from 0 to size-1. Your code uses indexes 1 to size. You should get in the habit of using the standard index values.

That said, your code works fine for me.

$ ./foo
enter no of elements of array
5
enter element1
10
enter element2
8
enter element3
3
enter element4
5
enter element5
12
Min Heap
parrent: 3      left: 5 right: 10
parrent: 5      left: 8 right: 12
parrent: 10
parrent: 8
parrent: 12
sh: pause: command not found