My list does not print out the info

[Bopaki]

Here is my list program:

  #include<iostream>
#include<list>
using namespace std;
struct nodeType
{
       int info;
       nodeType *link;
};
class buildLForward
{
public:
       
nodeType *buildListForward();
void print() const;
};
nodeType *buildLForward::buildListForward()
{
         nodeType *first, *last, *newNode;
         int num;
         cout<<"Enter a list of integers ending with -999.\n";
         cin >> num;
         first = NULL;
         while(num != -999)
         {
                   newNode = new nodeType;
                   assert(newNode != NULL);
                   newNode->info = num;
                   newNode->link = NULL;
                   if(first == NULL)
                   {
                            first = NULL;
                            last = NULL;
                   }
                   else
                   {
                       last->link = newNode;
                       last = newNode;
                   }
                   cin >> num;
        } //end while
        return first;
} // end buildListForward
void buildLForward::print() const
{
nodeType *current, *first; //pointer to traverse the list
current = first; //set current point to the first node
while (current != NULL) //while more data to print
{
cout << current->info << " ";
current = current->link;
}
}//end print

int main()
{
    int num;
    buildLForward list;
    nodeType *last;
    list.buildListForward();
    
      list.print();
       return 0;
       }
             
                          

When I try to print the list I get nothing

C:\Dev-Cpp>buildListForward
Enter a list of integers ending with -999.
45 56 89 -999

C:\Dev-Cpp>

[lastchance]

                   if(first == NULL)
                   {
                            first = NULL;
                            last = NULL;
                   }

Now that's a weird thing to write.

Probably you meant

                   if(first == NULL)
                   {
                            first = newNode;
                            last = newNode;
                   }

Please:
- correct as above

- remove the line with assert in

- define
nodeType *first, *last;
in your class declaration and NOT in either buildListForward() or print(). (TBH they would be better initialised to NULL (or, better, nullptr) in the class declaration.)

[Bopaki]

I have done the changes as lastchance said. Now The program only print the last node only.

C:\Dev-Cpp>buildlistForward
Enter a list of integers ending with -999.
45 67 89 65 -999
65
C:\Dev-Cpp>

[lastchance]

Show your whole revised code. I get

Enter a list of integers ending with -999.
45 67 89 65 -999
45 67 89 65  

Make sure that you followed the instruction

define
nodeType *first, *last;
in your class declaration and NOT in either buildListForward() or print()

[Bopaki]

Here is my code as requested by lastchance:

#include<iostream>
#include<list>
#include<cassert>
using namespace std;
struct nodeType
{
       int info;
       nodeType *link;
};
class buildLForward
{
public:
       
nodeType *buildListForward();
nodeType *first, *last;
void print() const;
};
nodeType *buildLForward::buildListForward()
{
         nodeType *first, *last, *newNode;
         int num;
         cout<<"Enter a list of integers ending with -999.\n";
         cin >> num;
         first = NULL;
         while(num != -999)
         {
                   newNode = new nodeType;
                   assert(newNode != NULL);
                   newNode->info = num;
                   newNode->link = NULL;
                   if(first == NULL)
                   {
                          first = newNode;
                          last = newNode;         
                   }
                   else
                   {
                       last->link = newNode;
                       last = newNode;
                   }
                   cin >> num;
        } //end while
        return first;
} // end buildListForward
void buildLForward::print() const
{
nodeType *current, *first; //pointer to traverse the list
current = first; //set current point to the first node
while (current != NULL) //while more data to print
{
cout << current->info << " ";
current = current->link;
}
}//end print

int main()
{
    int num;
    buildLForward list;
    nodeType *last;
    list.buildListForward();
    
      list.print();
       return 0;
       }

                       
                      

Here is what I get:

C:\Dev-Cpp>buildlistforward
Enter a list of integers ending with -999.
45 67 98 12 -999
12
C:\Dev-Cpp>

[lastchance]

@Bopaki,
Please, READ MY LAST POST!

You redeclare first and last in buildLForward::buildListForward() (see line 20) - DON'T!

You redeclare first in vbuildLForward::print() (see line 47) - DON'T!

These would create completely new variables in those routines that just happen to have the same name as (and hence hide) the originals.

Don't you think it would cause utter confusion if I decided to call myself Bopaki?

[Bopaki]

Thanks lastchance I corrected those errors, and now my program runs fine.