Parsing JSON Files and Storing Data in Program

[PiggiesGoSqueal]

Intro / What I Tried
I'm trying to parse JSON files (which I've never done before). I first tried JsonCpp using this tutorial:
https://www.codeproject.com/Articles/1102603/Accessing-JSON-Data-with-Cplusplus#_articleTop
But Json::Reader is deprecated and didn't seem to work.

I then tried looking into nlohmann's Parser which is nice because it only requires 1 header file to include:
https://github.com/nlohmann/json/tree/v3.6.1#stl-like-access
But I couldn't figure out how to get it to work. It gives errors when I include the header file as seen here:
https://github.com/nlohmann/json/issues/1659

Then I looked into how to create my own JSON parser and as I'm sure you can guess, that was insanely difficult (for a beginner). :P

So... After spending ~4 days trying to figure this out, now I'm here.

What I am trying to do:
There's a game called Minecraft that is Survival based and allows you to craft different items and build or use them for various things.

In short, I'm trying to parse the data and store the data into my program.

Here's an example JSON file - acacia_boat.json:

{
  "type": "crafting_shaped",
  "group": "boat",
  "pattern": [
    "# #",
    "###"
  ],
  "key": {
    "#": {
      "item": "minecraft:acacia_planks"
    }
  },
  "result": {
    "item": "minecraft:acacia_boat"
  }
}

Another Example - piston.json

{
  "type": "crafting_shaped",
  "pattern": [
    "TTT",
    "#X#",
    "#R#"
  ],
  "key": {
    "R": {
      "item": "minecraft:redstone"
    },
    "#": {
      "item": "minecraft:cobblestone"
    },
    "T": {
      "tag": "minecraft:planks"
    },
    "X": {
      "item": "minecraft:iron_ingot"
    }
  },
  "result": {
    "item": "minecraft:piston"
  }
}

https://minecraft.gamepedia.com/Recipe#JSON_format

How can I parse the data and print it in my program?

Thanks!

Please Note: I may take 1-4 days to respond because I'm going to be very busy with a school project. But I'll check this when I can!

Edit: Apologies, this project is taking much longer than I expected.. I'll read and respond to all replies when I can. I'm going to be swamped for the week though as the semester is nearing the end.

[poteto]

Ill take nlohmann's word that this is a compiler warning (he posted on github a few moments you you made the issue).

I use clang I am am used to disabling warnings using compiler specific flags. For visual studios it should be the same, this is the first result on stack overflow I found:

#pragma warning( push )
#pragma warning( disable : 4101)
// Your function
#pragma warning( pop )  

The warning ID should be the one you see in your IDE.

[dutch]

You can do a quick-and-dirty "parse" of those particular json files like this. If that's the format of all of them (or something very similar that you could modify this technique for) then it would work just fine.

Assumptions: the input is of this form and has no errors and the strings have no embedded double-quotes. Also, I unilaterally decided that there is no distinction between the words "item" and "tag" in the "key" section and so just ignored them.

A map may be more appropriate for the "key" data. It depends on what you want to do with it.

#include <iostream>
#include <fstream>
#include <sstream>
#include <string>
#include <vector>
#include <cstdlib>

struct Minecraft {
    std::string type, group;    
    std::vector<std::string> pattern;
    std::vector<std::pair<std::string, std::string>> key;
    std::string result;

    Minecraft() = default;
    Minecraft(std::istream&);
    void read(std::istream&);
    void print();
    void clear() {
        type.clear();
        group.clear();
        pattern.clear();
        key.clear();
        result.clear();
    }
};

void die(const std::string& msg) {
    std::cerr << "Error: " << msg << '\n';
    exit(1);
}

void Minecraft::print() {
    using std::cout;
    cout << "type: " << type << '\n';
    if (!group.empty()) cout << "group: " << group << '\n';
    cout << "pattern:\n";
    for (const auto& p: pattern) cout << "  " << p << '\n';
    cout << "key:\n";
    for (const auto& k: key) cout << "  " << k.first << ": " << k.second << '\n';
    cout << "result: " << result << '\n';
}

std::string get_next_string(std::istream& in) {
    char ch;
    while (in.get(ch) && ch != '"') ;
    std::string str;
    while (in.get(ch) && ch != '"') str.push_back(ch);
    return str;
}

Minecraft::Minecraft(std::istream& in) {
    read(in);
}

void Minecraft::read(std::istream& in) {
    clear();
    std::string str = get_next_string(in);
    if (str != "type") die("type");
    type = get_next_string(in);
    str = get_next_string(in);
    if (str == "group") {
        group = get_next_string(in);
        str = get_next_string(in);
    }
    if (str != "pattern") die("pattern");
    for (;;) {
        str = get_next_string(in);
        if (str == "key") break;
        pattern.push_back(str);
    }
    for(;;) {
        std::pair<std::string,std::string> p;
        p.first = get_next_string(in);
        if (p.first == "result") break;
        str = get_next_string(in);
        if (str != "item" && str != "tag") die("key");
        p.second = get_next_string(in);
        key.push_back(p);
    }
    str = get_next_string(in);
    if (str != "item" && str != "tag") die("result");
    result = get_next_string(in);
}

int main(int argc, char **argv) {
    Minecraft mc;

    if (argc == 2) {
        std::ifstream fin(argv[1]);
        if (!fin) {
            std::cerr << "Cannot open " << argv[1] << '\n';
            return 1;
        }
        mc.read(fin);
    }
    else {
        extern std::istringstream sin;
        mc.read(sin);
    }

    mc.print();
}

std::istringstream sin(
R"(
{
  "type": "crafting_shaped",
  "pattern": [
    "TTT",
    "#X#",
    "#R#"
  ],
  "key": {
    "R": {
      "item": "minecraft:redstone"
    },
    "#": {
      "item": "minecraft:cobblestone"
    },
    "T": {
      "tag": "minecraft:planks"
    },
    "X": {
      "item": "minecraft:iron_ingot"
    }
  },
  "result": {
    "item": "minecraft:piston"
  }
}
)"); 

[mbozzi]

int main(int argc, char **argv) {
    extern std::istringstream sin;
    std::istream* in = &sin;

    if (argc == 2) {
        std::ifstream fin(argv[1]);
        if (!fin) {
            std::cerr << "Cannot open " << argv[1] << '\n';
            return 1;
        }
        in = &fin;
    }

    Minecraft mc(*in);
    mc.print();
}

IINM, that main function leaves in a dangling pointer when its referent, fin, is destroyed at the closing brace of the if-statement.

[dutch]

Yikes! You're right. I threw that bit in at the end so it could be run online with sin. Thanks. I'll fix it above.
EDIT: I decided to get rid of the pointer. It was, and is, pointless.

[poteto]

no comments XD

edit:
Well it doesn't really matter, the code nothing is wrong with it, but OP needs to reply if the problem was the fact that he thought compiler warnings were errors.

Your suggestion is a bit weird though, why reinvent the wheel when json is a powerful tool that can be reused.

[dutch]

If you mean that my code has no comments, I tried adding them (to the read function since everything else is self-explanatory, and if it isn't you can always ask) but it just added clutter. I should probably state the basic idea of the algorithm, though.

It only looks at the strings and ignores everything else (all the braces, colons, etc.). It reads strings with the get_next_string function that finds the next double-quote and reads the string up to the following double-quote.

So it sees this:

{
  "type": "crafting_shaped",
  "group": "boat",
  "pattern": [
    "# #",
    "###"
  ],
  "key": {
    "#": {
      "item": "minecraft:acacia_planks"
    }
  },
  "result": {
    "item": "minecraft:acacia_boat"
  }
}

as this:

type
crafting_shaped
group
boat
pattern
# #
###
key
#
item
minecraft:acacia_planks
result
item
minecraft:acacia_boat

It "parses" the data by knowing that the first string should be "type", the next the actual type string, the next is optionally "group", in which case the next is the group string, then there's "pattern", which is followed by strings that need to be stored in the pattern vector until the string "key", which is followed by pairs of strings (ignoring words "item" and "tag" which seem to have no meaning) that are stored in the key vector, until the string "result", which is followed by the result string (after "item" which we ignore as usual).

[coder777]

Why don't you use boost property_tree and their json parser:

https://www.boost.org/doc/libs/1_70_0/doc/html/property_tree/parsers.html#property_tree.parsers.json_parser

    boost::property_tree::ptree pt;
    try { boost::property_tree::read_json("filename", pt); }
    catch(...) { std::cerr << "Error"; }

and learn to use that libraries:

https://www.boost.org/doc/libs/1_70_0/

There are a lot useful things.