If else statement

[Cjigsaw]

@Niccolo,

That worked. Maybe its the lack of sleep. When I was playing around with it. I just saved my ideas on notepad so I could paste it and try it out but I didn't try it with the '==' .I may have more questions after I finish up this part of the code. I definitely want to continue with this community. I want learn as much as possible. Now if I can just figure at a different time how to install code blocks on linux. lol

[Cjigsaw]

good night fellow programmers! I will keep you posted.

[Niccolo]

'night 'saw

[Cjigsaw]

Ugh, I'm awake. I just need to add one thing in this code and I should be good. I hope. My least favorite part I have to do is make the flowchart. I hate those.

[Cjigsaw]

My next piece I need to figure out is something like this, but I don't know where to stick it.

if (saving > 30)// no matter what reward level ,you can't have more than 30 for savings
{
saving = 30;
cout<<"You saved: $";
cout<<showpoint<<fixed<<setprecision(2)<<saving<<endl; 
}

[jonnin]

put it last. do everything else and then check if its too big and put a cap on it at that time.

[Cjigsaw]

cap?

[Niccolo]

In each of the options from your previous code example, savings is calculated with something like:

    saving = receiptAmt * sDiscountAdd;
    cout<<"You saved: $";
    cout<<showpoint<<fixed<<setprecision(2)<<saving<<endl;

This is repeated in each of the clauses, but where the parameter "sDiscountAdd" is chosen differently, they're all otherwise the same. So, this is a typical pattern where a function is used to homogenize a control over the "saving" parameter, and it subsequently simplifies your code.

I assume floats, but use whatever "savings" really is (a double maybe, I'm not sure).

float calc_saving( float receiptAmt, float discount )
{
float s = receiptAmt * discount;

if ( s > 30 ) s = 30;

   cout<<"You saved: $";
    cout<<showpoint<<fixed<<setprecision(2)<<s<<endl;

return s;
}

Now, where each clause currently says something like the first example in this post, it can read:

saving = calc_saving( receiptAmt, sDiscountAdd );

Thus, the repeated code is now no longer repeated (all those couts in each clause), and the selection according to each case is handled by the parameter, which wraps the concept of "limiting" the value of saving into a function.

[Cjigsaw]

wow, my mind is blown. so i would have to introduce a new variable calc_saving and maybe discount too? I would assume I add this last after all the other if else statements. Please forgive me for not getting it right away. lol.

[Niccolo]

calc_saving is a function in my post, not a variable.

Functions are the heart of programming. Thousands of them are likely in a single program.

You have discount already, several version in the code you posted. Examine the code you last took from here that worked. Read and notice everywhere that you already have the calculation for saving. It is a patter repeated 4 times in your code, once for each possible option in the "if/else" logic. Each one you used is different, apparently for the given circumstance.

The function takes whichever is appropriate, and REPLACES all of the repeated code. Read what I posted above carefully and notice what is similar about each "if/else" clause and that function to figure out what it replaces.

[Cjigsaw]

Makes sense. These are my variables

char rewardLevel;
double receiptAmt;
double Gdiscount = .12;//Gold discount
double gDiscountAdd = .035;//Gold discount when you spend more than 200
double Sdiscount  = .08;//silver discount
double sDiscountAdd = .0225;//silver discount when you spend more than 200
double Bdiscount = .04;//bronze discount
double bDiscountAdd = .0175;//bronze discount when you spend more than 200
string salesDiscount;//discount in percentage
double saving;//how much savings the member receives when they made a purchase

My if statemtents for like before

if (rewardLevel == 'g' || rewardLevel == 'G')//checks to see if the user entered reward level gold. to move on to gold discount
{
 if ( receiptAmt > 200)//if the user spends more than 200, it moves them into a different discount bracket.
 {
  saving = receiptAmt * gDiscountAdd;//calculates how much the member saved
   cout<<"You saved: $";
    cout << showpoint<< fixed<< setprecision(2)<<saving<<endl;

 }
 else
 {
  saving = receiptAmt * Gdiscount;//calculates how much the member saved
    cout<<"You saved: $";
    cout << showpoint<< fixed<< setprecision(2)<<saving<<endl;
 }

}
if (rewardLevel == 's' || rewardLevel == 'S' )
{
  if (receiptAmt > 200)
  {
    saving = receiptAmt * sDiscountAdd;
    cout<<"You saved: $";
    cout<<showpoint<<fixed<<setprecision(2)<<saving<<endl;
  }

  else
  {
     saving = receiptAmt * Sdiscount;
     cout<<"You saved: $";
     cout<<showpoint<<fixed<<setprecision(2)<<saving<<endl;
  }

}
if (rewardLevel == 'b' || rewardLevel == 'B')
{
    if (receiptAmt >200)
    {
        saving = receiptAmt * bDiscountAdd;
        cout<<"You saved: $";
        cout<<showpoint<<fixed<<setprecision(2)<<saving<<endl;
    }
    else
    {
        saving = receiptAmt * Bdiscount;
        cout<<"You saved: $";
        cout<<showpoint<<fixed<<setprecision(2)<<saving<<endl;
    }
}

each little discount has its own level. so do the calc function in each part were it has saving = ? The code you recommended where would that go exactly?

[Cjigsaw]

I got it!

[Niccolo]

:) Good thing I was out at the store then ;)

[Cjigsaw]

@Niccolo, I greatly appreciate you and everyone's help here. I do hope I can pm you to pick your brain. I would say I would help in return, but I'm new to this, so I'm not much use. lol.

[MikeyBoy]

Cjigsaw wrote:

I do hope I can pm you to pick your brain.

Why would you want to do that? Why would you want to limit the number of people who could give you help to 1, rather than posting publicly so that you can get help from more than 1 person.