Problem in writing the binary of a file after reading it into memory

[elyson]

Following a guide in this site, I wrote a program to read in an exe's binary and then output it. But after I output the memory content of the file, some of the byte are duplicated, making the output file that suppose to be an exact copy of the file being read having a larger size. The following are my code.

// reading a complete binary file
#include <iostream>
#include <string>
#include <fstream>

using namespace std;

ifstream::pos_type size;
char * memblock;

string filename="hjsplit.exe";//string filename="hjsplit.dat";
  ifstream file(filename.c_str(), ios::in|ios::binary|ios::ate);
  ofstream output("hjsplit.dat");

int main () {
  
  
    
  if (file.is_open())
  {
    size = file.tellg();
    memblock = new char [size];
    file.seekg (0, ios::beg);
    file.read (memblock, size);
    file.close();
   
   for(int i=0;i<size;i++){output<<memblock[i];}
   
    delete[] memblock;
}
  else cout << "Unable to open file"<<endl;
  system("pause");
  return 0;
}

However, not all file have byte duplicated, only certain files.

[Duthomhas]

Your ostream is not in binary mode.

BTW, you should create your file streams in the main block.

Hope this helps.

[elyson]

Ya, following your advice solve the problem, thanks.