2048 Game: How to overcome this bug?

[John Davis]

I am testing it using:

int main(){

    std::vector<int> v{1,1,1,1};

    bool c = game_over(v);

    if(c){
        std::cout << "true" << std::endl;
    }

    if(!c){
        std::cout << "false" << std::endl;
    }

    return 0;
}

[dutch]

What's 2048 game?
Post runnable code.

[John Davis]

Hi dutch.

This here is an example of the 2048 game: http://2048game.com/

The code I have above and the test do run and do compile It's just that it only returns false.

[dutch]

The code doesn't compile. It's missing headers and twod_to_oned.
The 2048 game is not entirely comprehensible to me.
In particular, I have no idea what a "game over" situation would be, and I have no idea what your initial setup in main, {1, 1, 1, 1} would mean. Is that game over? Why? Is your grid 4 x 4 or not?

One thing I notice is that your i < length should be i < length - 1. Same with j < length.

[helios]

In particular, I have no idea what a "game over" situation would be

When there are no more possible moves. I.e. There are no empty spaces in the board and there are no adjacent pieces of the same value.

[John Davis]

I do not see why it should be length -1. For example. If we consider a 4 by 4 square, the length would equal 4. now this means that the maximium i values should be 3 and so if it was i < length max value would be 3 whereas if we put length -1 max value would be 2 which is incorrect.

[lastchance]

The problem isn't i, it's i+1 (see line 19).

Post compileable code if you wish for assistance.

[John Davis]

Ah! I have solved it thank you.