How to update the integer in other function

[jujull]

Every time I try to run this code, all the output become 0. Can anyone help me out? So, here's my code:

  #include <iostream>
using namespace std;
void countFreq(int);
int sumPos(int);
int sumNeg(int);

int main ()
{
	int a, totp, totn;
	
	cout << "Enter 10 integers: " << endl;
	
	for (int i=0;i<10;i++)	
	{
		cin >> a;
	}
	
	totp = sumPos(a);
	totn = sumNeg(a);
	
	countFreq(a) ; 
	cout <<endl << "The sum of positive number is: " << totp<< endl;
	cout << "The sum of positive number is: " << totn;

	return 0;
}

void countFreq(int c)
{
	
	int pn=0, nn=0, z=0;
	
	if (c > 0)
		pn += 1;
		
	else if (c<0)
		nn += 1;
		
	else
		z += 1;
	
	cout << "There are " << pn << " positive numbers, " << nn << " negative numbers and " << z << " zeroes.";
}

int sumPos(int a)
{
	int tpn;
	
	tpn += a;
	
	return tpn;	
}

int sumNeg(int b)
{
	int tnn;
	
	tnn += b;
	
	return tnn;
}

[Hammad Ali]

Hi jujull ,

Your code have a very basic issue. The loop which is taking input in "a" is overwriting the value of "a" after every input. So at the end of this loop you have only one value of "a".

for (int i=0;i<10;i++)	
	{
		cin >> a;
	}

what you should do is create array instead of single variable

[Satan]

Try this:

int totp=0, totn=0;
	for (int i=0;i<10;i++)	
	{
		cin >> a;
		totn = totn+a;
                if(a > 0) 
                    totp = totp+a;
		
	}

Assuming totn is total sum of all numbers and totp is total sum of only positive numbers. ;)

[LajosOnly]

He don't have to create an Array or something he only should make the operations with a in his for-Loop like this:

for (int i=0;i<10;i++)	
	{
		cin >> a;
                totp = sumPos(a);
	        totn = sumNeg(a);
	}

[jujull]

This assignment was before we learn array, so we shouldn't using any array. Btw, thanks guys for the help. I really appreciate a lot!