My objects are sharing a variable?

[Blake7]

I'm creating a little game where I have a player and the computer fighting each other. Although, for some reason, it seems like they're sharing the same hp. I've put the code below so if you want, you can play and see exactly what I'm talking about. It's a little messy since I've had to paste my header and implementation files into one, but if anyone could help review my code that would be wonderful.

// Example program
#include <iostream>
#include <cmath>
#include <random>
#include <string>
#include <iomanip>

using namespace std;

//header 
enum AttackType 
{
	OFFENSIVE = 1,
	DEFENSIVE = 2,
};
class Character 
{
public:
	void Setup(const string &name, int hp, int atk, int def);
	void DisplayStats();
	void SelectAction();
	int GetAttack();
	void GetHit(int atk);
	int GetHP();
protected:
	string m_name;
	int m_hp;
	int m_atk;
	int m_def;
	AttackType m_attackType;

};

class Player: public Character
{
public:
	void SelectAction();
};

class Enemy : public Character
{
public:
	void SelectAction();
};

// main
int GetUserInput(int min, int max)
{
	int number;
	cout << "Please enter a number" << endl;
	cin >> number;

	if (number > max)
	{
		cout << "Sorry that's an invalid option. Please try again." << endl;
		GetUserInput(min, max);
	}
	if (number < min) 
	{
		cout << "Sorry that's an invalid option. Please try again." << endl;
		GetUserInput(min, max);
	}
	return number;
}
int GetRandom(int min, int max)
{
	srand(time(NULL)); // Seed the time for random number every time
	int finalNum = rand() % (max - min + 1) + min;
	return finalNum;
}

void SetupCharacters(Player &player, Enemy &enemy);

int main() 
{
	bool ready = false;
	Player player;
	Enemy enemy;
	while (ready == false)
	{
		int pick;
		SetupCharacters(player, enemy);
		cout << "Your stats:" << endl;
		player.DisplayStats();
		
		cout << "Enemy's stats:" << endl;
		enemy.DisplayStats();
		cout << "Are you ready?\n\n1. Yes\n2. No" << endl;
		pick = GetUserInput(1, 2);
		if (pick == 1)
			ready = true;
		if (pick == 2)
			ready = false;
	}
	int i = 1;
	while (player.GetHP() > 0 && enemy.GetHP() > 0)
	{
		int playerAtkNum;
		int enemyAtkNum;
		cout << "Round " << i << "\n\n" << "Your stats: ";
		player.DisplayStats();
		cout << "\n\n" << "Your opponents' stats: ";
		enemy.DisplayStats();
		player.SelectAction();
		enemy.SelectAction();
		playerAtkNum = player.GetAttack();
		enemyAtkNum = enemy.GetAttack();
		player.GetHit(enemyAtkNum);
		enemy.GetHit(playerAtkNum);
		i++;
	}
	

	
	system("pause");
	return 0;
}

void SetupCharacters(Player &player, Enemy &enemy) 
{
	string name;
	int stats;
	cout << "Please, tell us your name." << endl;
	cin >> name;
	const string NAME{ name };
	
	cout << endl;
	cout << "Pick your stats!\n\n";
	cout << "Option" << setw(15) << "Attack" << setw(15) << "Defense" << endl;
	cout << "1" << setw(15) << "5" << setw(15) << "15" << endl;
	cout << "2" << setw(15) << "15" << setw(15) << "5" << endl;
	cout << "3" << setw(15) << "10" << setw(15) << "10" << endl;
	cin >> stats;
	cout << endl;
	if (stats == 1) 
	{
		player.Setup(NAME, 50, 5, 15);
	}
	else if (stats == 2) 
	{
		player.Setup(NAME, 50, 15, 5);
	}
	else
	{
		player.Setup(NAME, 50, 10, 10);
	}

	
	int finalNum;
	finalNum = GetRandom(1, 3);
	if (finalNum == 1)
	{
		enemy.Setup("NPC", 50, 5, 15);
	}
	else if (finalNum == 2)
	{
		enemy.Setup("NPC", 50, 15, 5);
	}
	else if (finalNum == 3)
	{
		enemy.Setup("NPC", 50, 10, 10);
	}
}

//implementation

void Character::Setup(const string &name, int hp, int atk, int def) 
{
	m_name = name;
	m_hp = hp;
	m_atk = atk;
	m_def = def;
}

void Character::DisplayStats() 
{
	cout << m_name << " HP:" << m_hp << " ATK:" << m_atk << " DEF:" << m_def << endl;
}

void Character::SelectAction() 
{

}

int Character::GetAttack()
{
	int attackNum;
	srand(time(NULL)); // Seed the time for random number every time
	int finalNum = rand() % (3 - 1 + 1) + 1;
	if (m_attackType == OFFENSIVE)
	{
		attackNum = m_atk + finalNum;
		cout << m_name << " chose Offensive style." << endl;
		return attackNum;
	}
	else{ 
		cout << m_name << " chose Defensive style." << endl;
		attackNum = m_atk;
		return attackNum; }
		
}

void Character::GetHit(int attack) 
{
	int dmg;
	if (m_attackType == OFFENSIVE) 
	{
		dmg = attack - m_def;
		if (dmg >= 0)
		{
			m_hp = m_hp - dmg;
		}
		if (dmg <= 0) 
		{
			m_hp = m_hp;
		}
	}
	else 
	{
		srand(time(NULL)); // Seed the time for random number every time
		int finalNum = rand() % (3 - 1 + 1) + 1;
		dmg = attack - m_def - finalNum;
		if (dmg >= 0)
		{
			m_hp = m_hp - dmg;
		}
		if (dmg <= 0)
		{
			m_hp = m_hp;
		}
	}
}

int Character::GetHP() 
{
	return m_hp;
}

void Player::SelectAction() 
{
	int type;
	srand(time(NULL)); // Seed the time for random number every time
	int finalNum = rand() % (3 - 1 + 1) + 1;
	cout << "Which attack style would you like?\n1. Offensive\n2. Defensive" << endl;
	cin >> type;
	cout << endl;
	if (type == 1)
	{
		m_attackType = OFFENSIVE;
	}
	else {
		m_attackType = DEFENSIVE;
	}
}

void Enemy::SelectAction() 
{
	srand(time(NULL)); // Seed the time for random number every time
	int finalNum = rand() % (2 - 1 + 1) + 1;
	if (finalNum == 1) 
	{
		m_attackType = OFFENSIVE;
	}
	else 
	{
		m_attackType = DEFENSIVE;
	}
}

[helios]

No, the problem is that you keep calling srand() with the current time. Since a single combat cycle will take only a few microseconds at most, your functions keep drawing the same numbers from rand().
srand() should be called only once, at the beginning of the program.

[Blake7]

Thank you! This is working, I'm getting different values for hp now, but even if I was generating the same rand() number, I should've still been getting different values for hp, but hey whatever works. Thanks again.

[helios]

Well, think about it. Once you made my suggested change you started seeing different HP values. If you think that without that change you should have been seeing different values, why weren't you?