how do i call cout statements to appear in a student report
I would like the results or output in void codesymbol and results in passfail to show in void print
******************************************************************
e.g
symbol code
A 7
B 6
c 5
outcome:passed
******************************************************************
******************************************************************
e.g
symbol code
A 7
B 6
c 5
outcome:passed
******************************************************************
|
|
Last edited on
Hello RahRah,
A few things I see right off.
"conio.h" is not a standard C++ header file and not everyone has this header file with their compiler. I have not seen where in you code that you would need this header file, but you are missing "main".
"double"s are the preferred floating point number type. It is more accurate than a "float".
Watch your indenting. I first see it in lines 21 -24. Then in the "codeSymbol" function the "cout" statements need better indenting and I would say that every other "if "statement needs unindented.
I try to run your program to see how it works, but with out 'main" it may take awhile.
Hope that helps,
Andy
A few things I see right off.
"conio.h" is not a standard C++ header file and not everyone has this header file with their compiler. I have not seen where in you code that you would need this header file, but you are missing "main".
"double"s are the preferred floating point number type. It is more accurate than a "float".
Watch your indenting. I first see it in lines 21 -24. Then in the "codeSymbol" function the "cout" statements need better indenting and I would say that every other "if "statement needs unindented.
I try to run your program to see how it works, but with out 'main" it may take awhile.
Hope that helps,
Andy
Hello RahRah,
I have fixed something up to see how the functions work. I do not know if the numbers I used are correct, but it works,
For these variables:
If you could provide what value each variable would be it would help.
I also found in the "codeSymbol" function in the matMark1 section your last if statement reads
The output I get is:
The first line may be better at the bottom, but works for testing. The "FF" should go away when the line(s) are fixed.
It also looks like there is duplication of a few sections in the "code
Andy
Edit: Sorry I meant to post this earlier and got tied up with the program.
I have fixed something up to see how the functions work. I do not know if the numbers I used are correct, but it works,
For these variables:
|
|
If you could provide what value each variable would be it would help.
I also found in the "codeSymbol" function in the matMark1 section your last if statement reads
if (matMark1 >= 80 && matMark1 <= 100) I think you meant it to beif (matMark1 >= 0 && matMark1 <= 29)The output I get is:
outcome : Passed A 7 A 7 FF 1 B 6 A 7 B A FF 7 716767 |
The first line may be better at the bottom, but works for testing. The "FF" should go away when the line(s) are fixed.
It also looks like there is duplication of a few sections in the "code
Andy
Edit: Sorry I meant to post this earlier and got tied up with the program.
Last edited on
Hello RahRah,
After working with the program and rereading your question I believe the answer to your question is.
First I created an overloaded function
Then to use it:
Notice the function call to
I have only set this up for one subject and need to deal with the others.
Hope this helps,
Andy
After working with the program and rereading your question I believe the answer to your question is.
First I created an overloaded function
std::string codeSymbol(double course), but I am now thinking that it should take two parameters. Still working on the second parameter.Then to use it:
std::cout << "English"; std::cout << "\t\t\t" << engMark1 << "%"; std::cout << "\t\t" << codeSymbol(engMark1); std::cout << "\t" << code << std::endl;Notice the function call to
codeSymbol(engMark1). The return value will be output in the "cout" statement.I have only set this up for one subject and need to deal with the others.
Hope this helps,
Andy
@RahRah,
Whenever you find yourself doing essentially the same thing six times, it's time to write some smaller functions.
Whenever you find yourself doing exactly the same thing several times, it's time to delete some lines of code.
Whenever you find yourself doing essentially the same thing six times, it's time to write some smaller functions.
Whenever you find yourself doing exactly the same thing several times, it's time to delete some lines of code.
Hello RahRah,
This is the output I have achieved here with what I had to start with. All the numbers and letters come from the program except "Z" for code. I do not know what that is for,so I just hard coded that for now.
Not knowing what you did for input makes it hard to guess what to do.
If you look closely at the way every thing is spaced out it is because I changed the way things are output.
I do have a suggestion for your code in the "print" function:
The first four lines show what you did in a more easy to read way. The second four lines demonstrate how you can chain all the separate "cout" statements into one single "cout" statement.
Hope that helps,
Andy
This is the output I have achieved here with what I had to start with. All the numbers and letters come from the program except "Z" for code. I do not know what that is for,so I just hard coded that for now.
Not knowing what you did for input makes it hard to guess what to do.
outcome : Passed
*************************************************************************
**** STUDENT ACADEMIC RECORD ****
This program inputs the learner marks of matric level
subjects and prints the student final report.
*************************************************************************
Name: John Doe School: CSCC
Subject Mark Symbol Code
----------------------------------------------------
English 80% A Z
Mathematics 85% A Z
Life Orientaton 75% B Z
History 95% A Z
Computer Literacy 79% B Z
Geography 84% A Z
Average Year Mark: 83 with Symbol: A and code: Z
the highest mark was: 95
the lowest mark was: 75
*************************************************************************
Press Enter to continue
|
If you look closely at the way every thing is spaced out it is because I changed the way things are output.
I do have a suggestion for your code in the "print" function:
|
|
The first four lines show what you did in a more easy to read way. The second four lines demonstrate how you can chain all the separate "cout" statements into one single "cout" statement.
Hope that helps,
Andy
Goodmorning Andy
Thank you so much for the help. but i dont understand what oveloading a function means
we just covered the topic on functions but that was never covered how do i go about it
i have done some of things you suggested but i am coming across two errors
Thank you so much for the help. but i dont understand what oveloading a function means
First I created an overloaded function std::string codeSymbol(double course)we just covered the topic on functions but that was never covered how do i go about it
i have done some of things you suggested but i am coming across two errors
error too few arguments to function 'void codesymbol and error at this point in file |
|
|
Last edited on
Hello RahRah,
Sorry while working on this reply my computer locked up and I lost everything,so I will try again.
An overloaded function is based on using an already used function name ,but with different parameters. The return type can be the same or different. It is the parameters that make an overloaded function not the return type.
An example of what I did. Your original function call:
The overloaded function call:
The overloaded function looks like this:
And the "ReturnScore" function looks like this:
Looking at these functions today I am starting to think I could combine the two and do away with the "switch" and most likely the first parameter and accomplish the same thing. I will have to look into that. Fo now it at least gives you an idea of what you could do.
The error message is related to line 124 of the "print" function. You have:
and it should be:
The function requires two parameters and you are only sending it one. Hence the error message "too few arguments to function call".
The first parameter is based on this "enum" I put at the top of the file.
For what its worth I set up the "print" function this way:
Lines 24 - 27 show you how you can take what you had and make it more readable.
Lines 29 - 33 Show you how you can chain everything together and even separate the code on different lines, but it is still considered a whole because the compiler does not care about white space.
Line 20. will print a line of "-" across the screen. And line 22 tells the "cout" to print what is in a given space to the "left" side of the space. Something worth learning, but you can do with out it right now.
Any thing else you do not understand let me know.
Hope that helps,
Andy
Sorry while working on this reply my computer locked up and I lost everything,so I will try again.
An overloaded function is based on using an already used function name ,but with different parameters. The return type can be the same or different. It is the parameters that make an overloaded function not the return type.
An example of what I did. Your original function call:
void codeSymbol(double &course, double matMark1, double LOMark1, double HisMark1, double CLMark1, double GeoMark1, double average1, char symbol)The overloaded function call:
std::string codeSymbol(courses name, double course)The overloaded function looks like this:
|
|
And the "ReturnScore" function looks like this:
|
|
Looking at these functions today I am starting to think I could combine the two and do away with the "switch" and most likely the first parameter and accomplish the same thing. I will have to look into that. Fo now it at least gives you an idea of what you could do.
The error message is related to line 124 of the "print" function. You have:
cout<<"English"; cout<<"\t\t\t"<<engMark1<<"%"<<"\t\t"<<codeSymbol(engMark1);and it should be:
cout<<"English"; cout<<"\t\t\t"<<engMark1<<"%"<<"\t\t"<<codeSymbol(eng, engMark1);The function requires two parameters and you are only sending it one. Hence the error message "too few arguments to function call".
The first parameter is based on this "enum" I put at the top of the file.
const enum courses { eng = 1, math, Life, His, computer, geography, avg };. The names can be changed, spelled out if you will, but I would stay with something that is meaningful for what it is. Since an "enum will start at zero with its numbering and add one for each entry I chose to start the first name at 1. It is not necessary, that is where my head was at when I wrote it, also in the "switch" making the first case 1 be a little easier to understand than zero.For what its worth I set up the "print" function this way:
|
|
Lines 24 - 27 show you how you can take what you had and make it more readable.
Lines 29 - 33 Show you how you can chain everything together and even separate the code on different lines, but it is still considered a whole because the compiler does not care about white space.
Line 20. will print a line of "-" across the screen. And line 22 tells the "cout" to print what is in a given space to the "left" side of the space. Something worth learning, but you can do with out it right now.
Any thing else you do not understand let me know.
Hope that helps,
Andy
Thank you Andy let me do what you have suggested and get back to you if i face problems thank you so much once again
Goodafternoon Handy
I have tried what you said i should do but i am getting this error message. I am still yet to input your suggestion on how the report should look
I have tried what you said i should do but i am getting this error message. I am still yet to input your suggestion on how the report should look
error: no matching function for call to 'codeSymbol(double&, double&)'| error: call of overloaded 'codeSymbol(double&, double&, double&, double&, double&, double&, double&, double&)' is ambiguous| |
|
|
Last edited on
Hello RahRah,
According to your error message
It looks like the overloaded function is
You may think that the problem lies in the "print' function, but it is in the "codeSymbol" function that takes two parameters. Neither of which should be a "float".
Show me the function "codeSymbol(parm1, parm2)" so I can see what you did.
Just because the error message may point to a line in the "print" function does not mean that is where the error is or starts.
Most times it is better to post the complete error message and not the part that you think is important. There is more useful information in the error message than you think.
I realize that I am showing you concepts that you are not familiar with and someday will cover, but for now I think the problem is that we are about one page different in the same book. I need to get us on the same page at the same time.
I also think it is a good time to post your whole code so I can see where you are at and can better address any problems.
Hope that helps,
Andy
According to your error message
| error: no matching function for call to 'codeSymbol(float&, float&)'| |
codeSymbol(float&, float&). That is not what I showed you earlier.You may think that the problem lies in the "print' function, but it is in the "codeSymbol" function that takes two parameters. Neither of which should be a "float".
Show me the function "codeSymbol(parm1, parm2)" so I can see what you did.
Just because the error message may point to a line in the "print" function does not mean that is where the error is or starts.
Most times it is better to post the complete error message and not the part that you think is important. There is more useful information in the error message than you think.
I realize that I am showing you concepts that you are not familiar with and someday will cover, but for now I think the problem is that we are about one page different in the same book. I need to get us on the same page at the same time.
I also think it is a good time to post your whole code so I can see where you are at and can better address any problems.
Hope that helps,
Andy
Goodafternoon Andy
yes i m new to programming and some topics havent been covered.I spent the day trying to understnd switch statements and how they operate.
yes i m new to programming and some topics havent been covered.I spent the day trying to understnd switch statements and how they operate.
|
|
Hello RahRah,
When I said the whole program I meant from the first "#include" to the last closing } of the file or the "whole file". "main" is calling functions that are not there.
Another thing I notices is that in the first program you called the variable "engMark1", but in the last post you called the variable "engMark". I would prefer the second variable name because the "1" is not really needed. My point is that you should be consistent between the first attempt and a revision.
At the beginning of "main" you are calling functions that there is no code for. With out them I can not tell if they are right or wrong.
At the end of "main" you call the function
When I run the program I get:
I see that the extra blank lines come from "main". For now I put a comments on those blank lines.
End of part 1.
When I said the whole program I meant from the first "#include" to the last closing } of the file or the "whole file". "main" is calling functions that are not there.
Another thing I notices is that in the first program you called the variable "engMark1", but in the last post you called the variable "engMark". I would prefer the second variable name because the "1" is not really needed. My point is that you should be consistent between the first attempt and a revision.
At the beginning of "main" you are calling functions that there is no code for. With out them I can not tell if they are right or wrong.
At the end of "main" you call the function
codeSymbol(engMark,matMark,LOMark,HisMark,CLMark,GeoMark,average,course); the way it should be. the next line calls the overloaded function codeSymbol(course,eng1,math1,Life1,His1,comp1,geo1,avg1);,but you are using the wrong set of parameters for this function and it is not meant to be called from "main".When I run the program I get:
*************************************************************************
****STUDENT ACADEMIC RECORD
This program inputs the learner marks of matric level
subjects and prints the student final report.
***************************************************************************
*****
Name:JohnDoe School :CSCCCSCC
Subject Mark Symbol Code
English 80% A Z
Mathematics 85% A Z
Life Orientaton 75% B Z
History 95% A
Computer Literacy 79% B
Geography 84% A
Average Year Mark : 83% with SymbolA
the highest mark was:95%
the lowest mark was:75%
*************************************************************************
A 7
A 7
B 6
A 7
B 6
A 7
A 7
Press Enter to continue
|
I see that the extra blank lines come from "main". For now I put a comments on those blank lines.
End of part 1.
Part 2.
Here is what I did with your program with what I had to work with:
And the output is:
End part 2
Here is what I did with your program with what I had to work with:
|
|
And the output is:
*************************************************************************
**** STUDENT ACADEMIC RECORD ****
This program inputs the learner marks of matric level
subjects and prints the student final report.
***************************************************************************
*****
Name:JohnDoe School :CSCCCSCC
Subject Mark Symbol Code
English 80% A Z
Mathematics 85% A Z
Life Orientaton 75% B Z
History 95% A
Computer Literacy 79% B
Geography 84% A
Average Year Mark : 83% with SymbolA
the highest mark was:95%
the lowest mark was:75%
*************************************************************************
Press Enter to continue
|
End part 2
Part 3.
Looking at the above output the tab does not line things up very well. You might want to take the tabs out of "Symbol" and "code" and use spaces to center the headings. Then you can keep the tabs in the lines that follow.
I do not know what "Symbol" and "Code" are actually for and what should be in those columns. I may have it backwards for all I know. If "Code" should be something different for each subject I need to know what that would be to help you code for it.
In the first output block at the top of the page if the column of letters and the column of numbers need to be there it would help if I could understand what they are for.
I realize that some of my code is a bit beyond where you are at and I will help you understand what you do not know. If it turns out that you just can not use it let me know and we can find another way.
Hope that helps,
Andy
Looking at the above output the tab does not line things up very well. You might want to take the tabs out of "Symbol" and "code" and use spaces to center the headings. Then you can keep the tabs in the lines that follow.
I do not know what "Symbol" and "Code" are actually for and what should be in those columns. I may have it backwards for all I know. If "Code" should be something different for each subject I need to know what that would be to help you code for it.
In the first output block at the top of the page if the column of letters and the column of numbers need to be there it would help if I could understand what they are for.
I realize that some of my code is a bit beyond where you are at and I will help you understand what you do not know. If it turns out that you just can not use it let me know and we can find another way.
Hope that helps,
Andy
Topic archived. No new replies allowed.