Problems with a C++ Code

[steaua stasucia]

I am a student and I'm doing a project with C++. Actually my program should tell the user if the word given is a palindrome or not. However, it's always saying "NO PALINDROME". Need help, please! Can't find the error!

#include<iostream>
#include<string>

using namespace std;

int main(){
    string n, a, b;
    cin>>n;
    int i, p=n.size(), c=1;    
    for (i=1; i<n.size(); (i=i+1)and(p=p-1)){
        a=(n[i]);
        b=(n[p]);
        if (a==b){
           c=c+1;
        }
        else {
           cout<<"NO PALINDROM"<<endl;
           i=n.size();
        }
    }
    if (c==n.size()){
       cout<<"YES PALINDROM"<<endl;
    }
    int z;
    cin>>z;
}

[ragn4rok234]

First thing I noticed was, on line 8 ask for input but you never tell the user what that input is supposed to be.

next two things I noticed was there was no "return 0" at the end of the function and instead of

    int z;
    cin>>z;

just use cin.ignore(2) essentially the same thing but instead of wasting a variable it just waits for you to hit a button.

[steaua stasucia]

Well, we were told that we did not have to tell the user what should be the input, but I'm OK with the other two things. Despite those facts it continues telling "NO PALINDROME" at any word.

Any idea? What's wrong in it?

[ragn4rok234]

So I found your error. You initialize i to 1 but arrays start at zero so i is looking at the second letter of your word. then secondly, n.size() returns 1 past the number of characters in your array so setting p=n.size() then b=n[p], b is equal to ' ' (a space). So to fix these errors, set i to 0 and p to n.size()-1.

OOOH and also, look at c..... look at it.... look at it.... mmk, so you set it to one, lets go through a loop
cin: aka
a = a
b = a
c = c + 1 == 2 // Weren't we still on the first letter? yeah, so make sure to initialize c to 0 as well

[steaua stasucia]

Thanks a lot ragn4rok234, now it works. I'm really grateful.

Bye!