Writing data to specified file and directory

[akarbarz]

In my code I create a folder in a specified path and open a file for writing. I then pass the outputfile to a function to do the actual writing. However, I can write to the file in main but not in my function.

#include <windows.h>
#include <iostream>
#include <string>
#include <fstream>
#include <sstream>
#include <iomanip>

using namespace std;
void checkheader(ostream& outputFile)
{
outputFile << "please work already " << endl; //write this to csv for practice
}
void CreateFolder(const char * path)
{
	if (!CreateDirectory(path, NULL))
	{
		return;
	}
}

int main(void)
{
        CreateFolder("C:\\CSV_ERROR_FILES_HERE\\");// create folder in specified path
	string filename = "errors.csv"; // create filename
	ofstream outputFile; 
	outputFile.open("C:/CSV_ERROR_FILES_HERE/errors.csv"); //open to outputfile for writing
        checkheader(outputFile); // call the function


}
	

[tpb]

It would seem some error checking is in order. I can't test this since I don't use Windows, but maybe something like this:

#include <windows.h>
#include <iostream>
#include <fstream>
using namespace std;

void checkheader(ostream& fout) {
    fout << "please work already\n";
}

bool CreateFolder(const char *path) {
    if (!CreateDirectory(path, 0) && GetLastError() != ERROR_ALREADY_EXISTS)
        return false;
    return true;
}

int main() {
    if (!CreateFolder("C:\\CSV_ERROR_FILES_HERE\\")) {
        cerr << "Problem creating folder\n";
        return -1;
    }

    ofstream fout("C:/CSV_ERROR_FILES_HERE/errors.csv");
    if (!fout) {
        cerr << "Problem opening file\n";
        return -1;
    }

    checkheader(fout);
}