Jumping into C++ cha 17 number 4 (binary trees and checking)

[gdz98]

Hi guys I m going trough the Jumping into C++ book and im currently "still" (for who knows me xD) on the binary tree chapter. There s an exercise that tells me to write a code where I need to let the user insert values in a tree and then create a function to see if the binary tree is the way it's supposed to be or not (if on the left there are only smaller values and on the right there are only greater values). Here's my code

  #include <iostream>

using namespace std;

struct node
{
    int key;
    node* left = NULL;
    node* right = NULL;
};

node* insert (node* tree, int key)
{
    if (!tree)
    {
        node* new_tree = new node;
        new_tree->key = key;
        return new_tree;
    }
    else if (key < tree->key)
        tree->left = insert (tree->left, key);
    else
        tree->right = insert (tree->right, key);
}

int Check (node* tree, node* left, node* right, int status)
{
    if (!tree)
        return status;
    if (left) // this lines are for checking if the left child is the way it s supposed to be. If it is,
    {         // we change/keep the status value at 1. Otherwise we set it at 2 and return it.
        if(left->key < tree->key)
            status = 1;
        else
        {
            status = 2;
            return status;
        }
    }
    if (right) // this lines are for checking if the right child is the way it s supposed to be. If it is,
    {         // we change/keep the status value at 1. Otherwise we set it at 2 and return it.
        if(right->key > tree->key)
            status = 1;
        else
        {
            status = 2;
            return status;
        }
    }
    status = Check (tree->left, left->left, left->left, status); // We call this recursive function to do the
    //same check on the entire left sub-tree
    if (status != 2)// in order not to ever change a virtual status which has changed to 2.
    {
        status= Check (tree->right, right->left, right->right, status);// We call this recursive function to do the
    //same check on the entire left sub-tree
    }
    return status;
}

void Delete (node* tree)
{
    if (!tree)
        return;
    Delete(tree->left);
    Delete(tree->right);
    delete tree;
}

int main ()
{
  node* tree = NULL;
  int key;
  int status = 0;
  int input;
  cout<<"1. Insert value \n2. Check if the tree's well structured \n3. Quit"<<endl;
  cin >> input;
  while (input == 1 || input == 2)
  {
    switch (input)
    {
      case 1:
          cout<<"Digit the value you want to insert \n";
          cin >> key;
          tree = insert(tree, key);
          break;
      case 2:
          status = Check (tree, tree->left, tree->right, status);
          if (status == 1)
            cout<<"Your tree's ok... BITCH \n";
          else if (status == 2)
            cout<<"Your tree's a shit \n";
          break;
    }
   cout<<"1. Insert value \n2. Check if the tree's well structured \n3. Quit"<<endl;
   cin >> input;
   }
   Delete(tree);
}

The issue now is that when I type 2 and I want to see if the tree is ok or not the program quits after a while...
I' m not sure if the arguments of the recursive functions are right or not. I ve tried to sketch a tree on a paper and tried to put the arguments in order to go where I wanted to go... and in this way it made sense at that time xD any help? :D

[jonnin]

to print the sorted data use in-order traversal:

print(node-> left)
print node
print(node->right)

so if you had

   5
 1  7
   6  8

it hits root (5) and goes left.
its at 1, it can't go left, so it prints 1
it can't go right, so it returns to 5
5 prints and then goes right to 7
7 goes left to 6
6 prints
7 prints and goes right to 8
8 prints and it unwinds and exits

this gives 1,5,6,7,8 .. sorted

Is that what you are asking?

[gdz98]

no it isn't sorry.... I wrote and "sorting" but that was from another exercise . I got confused. now I ve edited and corrected my title