out of range at memory location error

[mrphilipp7]

at line 59-60, my program always stops working says their is an error saying I am out of the range of memory location. What does this mean and why can't I output a vector that i passed in my function. I have the right parameters don't I?

  #include "stdafx.h"
#include <iostream>
#include <vector>
using namespace std;

void readarray(int array1[100], int& counter);
void printarray(int array1[100], int counter);
void copyarray(int array1[100], vector<int>&v1, int counter);
void printvector(vector<int>v1);

int main()
{
	int myarray[100], b;
	vector<int>myvector;
	readarray(myarray, b);
	printarray(myarray, b);
	copyarray(myarray, myvector, b);
	printvector(myvector);
	system("pause");
    return 0;
}

void readarray(int array1[100], int& counter)
{
	int num;
	for (int x = 0; x < 10; x++)
	{
		cout << "Enter element: ";
		cin >> num;
		counter++;
		array1[x] = num;
	}
}

void printarray(int array1[100], int counter)
{
	for (int x = 0; x < counter; x++)
	{
		cout << array1[x]<<" ";
	}
	cout << endl;
}

void copyarray(int array1[100], vector<int>&v1, int counter) 
{
	for (int x = 0; x < counter; x++)
	{
		v1.push_back(array1[x]);
	}
}

void printvector(vector<int>v1)
{
	int biggest = 0;
	for (unsigned int x = 0; x < v1.size(); x++)
	{
		if (v1.at(x) > biggest)
		{
			cout << v1.at(x);
			biggest = v1.at(x);
		}
	}
	cout << biggest << endl;
}

[E0p9LyTq]

Where are you initializing your b variable?

No where, so you are using whatever garbage value it contains.

[mrphilipp7]

but how does that apply to my printvector() function?

[mrphilipp7]

it solved my problem, but i'd like you to explain this. Why did i get the error at lines 59-60? shouldn't it tell me that the minute I try to increase the value of B?

[E0p9LyTq]

There is no one answer to undefined behavior. Using an undefined variable as the limiter in a for loop is undefined behavior and can show up anywhere in your program. It just happened to cause problems with what seems to be an unrelated function.

Do you know what the actual number of elements were contained in your vector? No, you don't. You define an array to be 100 elements, and then likely proceed to read more than 100 elements into your vector. b in main() becomes counter in your 3 array functions.

readarray() increments a garbage value and that garbage value gets thrown into printarray() and copyarray().

GIGO, garbage in, garbage out.

It looks like you are using Visual Studio. VS in debug mode initializes variables to zero, something it doesn't do in release mode. Lots of bugs can creep in when changing that configuration.