Super long program, how to optimize?
Hey so I'm doing an assignment (https://imgur.com/a/qykyQ) and I'm done with everything except the sort-by-name part and the search function, but it's already 200+ lines and kinda ugly, there are many parts where the code seems really repetitive.
If you see anything that can be optimized, let me know!
Also, I'm having trouble with the last two parts, if you can tell me which topics I need to learn to do them, that would be greatly appreciated. Thanks!
|
|
If you see anything that can be optimized, let me know!
Also, I'm having trouble with the last two parts, if you can tell me which topics I need to learn to do them, that would be greatly appreciated. Thanks!
#define OMGSEATS OSeat[iX][iY].sName = sInputName; OSeat[iX][iY].Day.iDay = iSelectDay;OSeat[iX][iY].Day.iMonth = iSelectMonth;OSeat[iX][iY].Day.iYear =
iSelectYear;bFoundSeat = true;
:-D
iSelectYear;bFoundSeat = true;
:-D
"OMGSEATS" lol funny, but we haven't done the #define preprocessor, so I can't use that, also I dont understand your code at all. Explain pls?
thanks
thanks
You must have done the #include preprocessor tho, otherwise nothing would be compiling. So you could make a file with exactly duplicated lines of code, seats.cpp, then #include it in four places and it would be more organized.
Maybe they want you to use functions though. Since you haven't done the #define preprocessor its an open question if they've taught how to pass pointers to variables instead of the variables. If not, guess you're stuck with global variables if you want functions.
Maybe they want you to use functions though. Since you haven't done the #define preprocessor its an open question if they've taught how to pass pointers to variables instead of the variables. If not, guess you're stuck with global variables if you want functions.
multi dimensional constructs are slightly slower than 1d if the compiler can't unroll it for you. They often end up, if nothing else, with an extra loop variable to maintain that is multiple bogus checks, increments, storage, etc. Use a 1-d construct even if logically it is 2-d. The speed gains are small until you have very high amounts of data, though, its probably not worth rewriting for that.
lose the stand-alone day/month/year for a single date variable, cutting assignments and such by a factor of 3?
use \n instead of endl in looped print statements.
can you do less checks in your nested ifs?
eg
if (something and value < firstbucket)
...
else if(something and value < second bucket) //its >= firstbucket here, and less than second
so no need to check a range if reworded?? I didn't check if this is possible or not, but if so...
as for reading it,
anywhere that you repeat the same code more than twice should be a function unless there is a very solid reason not to do that.
eg:
OSeat[iX][iY].sName = sInputName;
OSeat[iX][iY].Day.iDay = iSelectDay;
OSeat[iX][iY].Day.iMonth = iSelectMonth;
OSeat[iX][iY].Day.iYear = iSelectYear;
bFoundSeat = true;
^^ function
finally magic numbers suck. Get those moved out to constants.
eg
for(x = 3; x < 39; x++) // bad
for(x = start; x < somemax; x++) //good
then if you change start or somemax it changes all the loops ... its unsafe to search/replace all the 3s, its unsafe to to it by hand, its just generally bug-prone and troubling to deal with constants in the middle of code.
lose the stand-alone day/month/year for a single date variable, cutting assignments and such by a factor of 3?
use \n instead of endl in looped print statements.
can you do less checks in your nested ifs?
eg
if (something and value < firstbucket)
...
else if(something and value < second bucket) //its >= firstbucket here, and less than second
so no need to check a range if reworded?? I didn't check if this is possible or not, but if so...
as for reading it,
anywhere that you repeat the same code more than twice should be a function unless there is a very solid reason not to do that.
eg:
OSeat[iX][iY].sName = sInputName;
OSeat[iX][iY].Day.iDay = iSelectDay;
OSeat[iX][iY].Day.iMonth = iSelectMonth;
OSeat[iX][iY].Day.iYear = iSelectYear;
bFoundSeat = true;
^^ function
finally magic numbers suck. Get those moved out to constants.
eg
for(x = 3; x < 39; x++) // bad
for(x = start; x < somemax; x++) //good
then if you change start or somemax it changes all the loops ... its unsafe to search/replace all the 3s, its unsafe to to it by hand, its just generally bug-prone and troubling to deal with constants in the middle of code.
Last edited on
References can save typing and eye strain with zero cost:
Create an operator to display a seat. Then you can call it wherever needed. Notice that I moved the code that prints the price to after the switch statement instead of repeating it each time.
The big savings come in your main function. Why iterate though each and every seat checking whether it's in the right section when you can determine exactly which rows to search up front? When determining the rows, use data instead of code:
Perhaps an even better way to store the data is to have a "Section" class. Each section has a name, a price, and starting/ending rows (and columns?). That would make clear what I had to guess: that the prices and row locations are related to the sections.
|
|
Create an operator to display a seat. Then you can call it wherever needed. Notice that I moved the code that prints the price to after the switch statement instead of repeating it each time.
|
|
The big savings come in your main function. Why iterate though each and every seat checking whether it's in the right section when you can determine exactly which rows to search up front? When determining the rows, use data instead of code:
|
|
Perhaps an even better way to store the data is to have a "Section" class. Each section has a name, a price, and starting/ending rows (and columns?). That would make clear what I had to guess: that the prices and row locations are related to the sections.
Topic archived. No new replies allowed.