Critique and Optimize my code?

[Elarionus]

Hello! I just wanted some feedback on my code, and maybe some ways I could make it better. The prompt was to create a program that did the following things:

1. Read a text file with 11 columns and 35 rows. The first column was "student 1, student 2, etc.," and the next 10 columns were their supposed answers on a test (A, B, C, or D).

2. Ask for user input to fill an array for the correct answers to the test.

3. Print all of the student answers.

4. Compare the 1D correctAnswers array to the 2D studentAnswers array (that was read in from a file).

5. Print the students' scores.

6. Print the highest, lowest, and average scores.

If you need any other information, or if I could've worded my question better, please let me know!

Here is my code:

  //---- Libraries ----//
#include <iostream>
#include <fstream>
#include <string>
using namespace std;

ifstream infile;

//---- Function Prototypes ----//
void print(string answers[35][11], const int ROWS, const int COLS);
void grade(string answers[35][11], const int ROWS, const int COLS, string correctanswers[10]);

//---- Main Function ----//
int main()
{
	const int ROWS = 35;
	const int COLS = 11;
	string x;
	infile.open("exam.txt");

	string answers[ROWS][COLS];

	if (infile.is_open())
	{
		for (int i = 0; i < ROWS; i++)
		{
			for (int j = 0; j < COLS; j++)
			{
				infile >> answers[i][j];
			}
		}
	}

	string correctanswers[10];
	cout << "Please enter the correct answers to the test in all caps.\n";
	for (int x = 0; x < 10; x++)
	{
		cin >> correctanswers[x];
	}

	print(answers, 35, 11);
	grade(answers, 35, 11, correctanswers);
}

void print(string answers[35][11], const int ROWS, const int COLS)
{
	for (int i = 0; i < ROWS; i++)
	{
		for (int j = 0; j < COLS; j++)
		{
			cout << answers[i][j] << " ";
		}
		cout << endl;
	}
}

void grade(string answers[35][11], const int ROWS, const int COLS, string correctanswers[10])
{

	int highest_score = 0;
	int lowest_score = 10;
	int sum_of_scores;
	double average_score;

	for (int i = 0; i < 35; i++)
	{
		int student_score = 0;
		for (int j = 1; j < 11; j++)
		{
			if (correctanswers[j-1] == answers[i][j])
			{
				student_score += 1;
			}

			else
			{
				student_score += 0;
			}
		}
		cout << answers[i][0] << " score is " << student_score << endl;

		if (student_score > highest_score)
		{
			highest_score = student_score;
		}

		if (student_score < lowest_score)
		{
			lowest_score = student_score;
		}

		sum_of_scores += student_score;
	}

	average_score = (sum_of_scores / 35);

	cout << "The highest score is: " << highest_score << endl;
	cout << "The lowest score is: " << lowest_score << endl;
	cout << "The average score is: " << average_score << endl;
}

[icy1]

35 and 11 should only appear once in the code, assigned to variables, e.g. ROWS and COLS like you have in main. Everywhere else should only have ROWS, COLS. Do the same thing for any other stray numbers, like correctanswers[10].

What if you suddenly have 36 rows? Now you have to change the program in dozens of places. Consider also rewriting all the arrays as vectors so that you don't need to worry at all about the number of rows.

For input, should tell the user to separate answers with spaces.

This part is extra and doesn't do anything:

else
{
    student_score += 0;
}

Overall, the code has good organization and formatting; keep it up!