Printing a 2D Dynamic Array Class

[Mattthews]

Im coding a game called Gomoku(Gobang) and i have used a 2d dynamic array to implement the board in a class, however my code doesnt print the board and crashes when i cout the board in a function. Help! The error occurs in the printBoard() function at this line *cout<<board[i][j];* The code is below:

  int main(void)
{
    int sizeBoard;
    ifstream infile ("input.txt");
    infile >> sizeBoard;
    int rows=15;
    int columns=15;
    Gobang game(sizeBoard,rows,columns);
    game.initialization();
    game.boardReset();
    game.printBoard();
}
//Class Implementation code
#include "Gobang.h"
#include <iostream>
#include <cstdlib>
using namespace std;

Gobang::Gobang()
{
    board = NULL;
}

Gobang:: Gobang(int boardSize,int rows,int columns )
{
    setParameters(boardSize,rows,columns);
}

void Gobang:: setParameters(int boardSize,int rows,int columns)
{
    row = rows;
    sizeB = boardSize;
    cols = columns;
}

Gobang::~Gobang()
{
    board = NULL;
}

void Gobang:: initialization()
{
    char  **board = new char*[row];
    //Creation of Board in Dynamic memory
    for (int i=0; i< sizeB ; i++ )
    {
        board[i] = new char[cols];
    }

    for (int i=0; i< sizeB; i++ )
    {
        for (int j=0; j<sizeB; j++)
        {
            board[i][j] = '*';
        }
    }

}

void Gobang:: printBoard()
{
    for (int i=0;i<sizeB;i++)
    {
        for (int j=0;j<sizeB;j++)
        {
            cout << board[i][j];
        }
        cout << endl;
    }

}

void Gobang:: boardReset()
{
    for (int i=0;i<row;i++)
    {
        for (int j=0;j<cols;j++)
        {
            board[i][j] = '*';
        }
    }
}

void Gobang:: testFile()
{
    cout << sizeB << endl;
}

[icy1]

you forgot the [ /code ] (no spaces) closing tag. Can you also add indentation? ;D

[Mattthews]

I did..pleas help

[icy1]

Appears to be working for me... I got rid of input file and made it compile.

I think the problem was in your initialization method you might've been making an extra board instead of using the private board_ variable (inside Gobang class). Can't see because you didnt post your full class. Also I added underscores to what I assume are private variables, since this is common practice.

Edit: Also I see you're using rows, columns, *and* sizeboard? Why do you need sizeboard if you already have rows and columns?

#include <iostream>
using namespace std;

class Gobang
{
public:
    Gobang()
    {
        board_ = NULL;
    }
    
    Gobang(int boardSize,int rows,int columns )
    {
        setParameters(boardSize,rows,columns);
    }
    
    ~Gobang()
    {
        board_ = NULL;
    }
    
    void setParameters(int boardSize,int rows,int columns)
    {
        rows_ = rows;
        sizeB_ = boardSize;
        cols_ = columns;
    }
    
    void initialization()
    {
        //Creation of Board in Dynamic memory
        board_ = new char*[rows_];
        for (int i=0; i< sizeB_; i++ )
        {
            board_[i] = new char[cols_];
        }
    
        for (int i=0; i<sizeB_; i++ )
        {
            for (int j=0; j<sizeB_; j++)
            {
                board_[i][j] = '*';
            }
        }
    
    }
    
    void printBoard()
    {
        for (int i=0; i<sizeB_; i++)
        {
            for (int j=0; j<sizeB_; j++)
            {
                cout << board_[i][j];
            }
            cout << endl;
        }
    
    }
    
    void boardReset()
    {
        for (int i=0; i<rows_; i++)
        {
            for (int j=0; j<cols_; j++)
            {
                board_[i][j] = '*';
            }
        }
    }
    
    void testFile()
    {
        cout << sizeB_ << endl;
    }
    
private:
    int rows_;
    int cols_;
    int sizeB_;
    char** board_;
};

int main()
{
    int sizeBoard = 15;
    //ifstream infile ("input.txt");
    //infile >> sizeBoard;
    int rows=15;
    int columns=15;
    Gobang game(sizeBoard,rows,columns);
    game.initialization();
    game.boardReset();
    game.printBoard();
    
    return 0;
}

In action: https://repl.it/repls/PristinePoorScriptinglanguages

[Mattthews]

Thanx bro..works perfectly! Only problem was that i had char** board = new char*[row] AND also had char**board in my private after removing the "Char **" in the initialization everything worked!! thanx man!!