undeclared identifier errors despite no undeclared variables

[vaderboi]

In visual studio I am trying to build my solution but continually get C2065 errors that claim that many of my variables have not been declared. This is not true so I'm wondering what is happening. My compiler's error list says that variables "CurrentWord", "Difficulty", "Guess", "Response", and "SecretWord" have not been declared even though I explicitly did.

Note: I don't know if this is relevant but the intention of this solution is to output to the console a Bull Cow Game in which a user has to guess a secret word. Kind of like hang man except that the user has to guess an entire word at a time and the console outputs the number of letters the user guessed correctly (cows) and the number of letters the user guessed incorrectly (bulls). This isn't even close to finished. I just want to know why I am getting this error.

Here are my files that are to be linked together:

 //main.cpp

#include "FBullCowGame.h"
#include <string>
#include <iostream>
#include <fstream>

void PrintIntro();
void PlayGame(); //TO IMPLEMENT
bool AskToPlayAgain();


int main(){

	PrintIntro();
	
	bool bPlayAgain = false;
	do {
		PlayGame();
		bPlayAgain = AskToPlayAgain();
	} while (bPlayAgain);

	return 0; // exit the application

};



void PrintIntro(){

	//constexpr int WORLD_LENGTH = 9;
	std::cout << "Welcome to Bulls and Cows, a fun word game.\n";
	//std::cout << "Can you guess the " << WORLD_LENGTH;
	//std::cout << " letter isogram I'm thinking of?\n";
	std::cout << std::endl;

	return;
};

 
void PlayGame() {

	FBullCowGame BCGame; // instantiate a new game

	//variable "Difficulty" is assigned difficulty based on user input
	FText Difficulty = BCGame.DifficultySelect();

	//sets the max tries based on the difficulty user selected
	BCGame.SetMaxTries(Difficulty);

	int32 MaxTries = BCGame.GetMaxTries();

	//TO CREATE: Method that finds word from ListOfWords and assigns it to SecretWord
	BCGame.SetSecretWord();

	for (int32 count = 1; count <= MaxTries; count++) {
		FText Guess = BCGame.GetGuess();
		std::cout << "Your guess was: " << Guess << std::endl;
		std::cout << std::endl;
	}

	return;
};

bool AskToPlayAgain(){

		std::cout << "Do you want to play again (yes/no)? ";
		FText Response = "";
		std::getline(std::cin, Response);

		//converts all characters of string in to lower case characters
		Response = toLowerCase(Response);

		bool validAnswer = false;

		//do-while loop ensures that user enters valid response before loop exits
		do {
			if (Response == "yes" || Response == "y") {
				validAnswer = true;
			}
			else if (Response == "no" || Response == "n") {
				validAnswer = false;
			}
			else {
				std::cout << "Please enter a valid response (yes/no): " << std::endl;
				std::getline(std::cin, Response);
				Response = toLowerCase(Response);
			}
		} while (validAnswer = false);

		return validAnswer;

};

//FBullCowGame.h

#ifndef __FBULLCOWGAME_H_INCLUDED__
#define __FBULLCOWGAME_H_INCLUDED__

#include "toLowerCase.h" //[mine]
#include <string>

using FText = std::string;
using int32 = int;

//values intitialized to zero
struct BullCowCount {
	int32 Bulls = 0;
	int32 Cows = 0;

};

class FBullCowGame {

	public:
		//void Reset(); //TO DO: Make a more rich return value
		FText DifficultySelect(); //[mine]
		void SetMaxTries(FText Difficulty);
		int32 GetMaxTries() const;
		void SetSecretWord(); //[mine]
		int32 GetCurrentTry(); 
		//bool IsGameWon() const;
		FText GetGuess();
		FText ToLowerCase(FText word);
		//bool GuessCheckValidity(FText); TO DO: Make a more rich return value
		//FText SubmitGuess(FText);

	private: 
		int32 MyCurrentTrys = 0; 
		int32 MyMaxTries = 0;
		FText SecretWord = "";
		FText Guess = "";


};

#endif

//FBullCowGame.cpp

#include "FBullCowGame.h"
#include <string>
#include <iostream>
#include <fstream>


FText FBullCowGame::DifficultySelect() {

	std::cout << "Please select a difficulty (easy, medium, hard, brutal): ";
	FText Difficulty = "";
	std::cin >> Difficulty;

	Difficulty = toLowerCase(Difficulty);

	bool ValidAnswer = false;

	//makes sure user inputs valid difficulty
	do {
		if (Difficulty == "easy" || "medium" || "hard" || "brutal") {
			ValidAnswer = true;
		}
		else {
			std::cout << "Please enter valid choice (easy, medium, hard, brutal): ";
			std::cin >> Difficulty;
			Difficulty = toLowerCase(Difficulty);
		}

	} while (ValidAnswer == false);

	return Difficulty;


};

void FBullCowGame::SetMaxTries(FText Difficulty) {

	if (Difficulty == "easy") {
		MyMaxTries = 15;
	}
	else if (Difficulty == "medium") {
		MyMaxTries = 10;
	}
	else if (Difficulty == "hard") {
		MyMaxTries = 5;
	}
	else if (Difficulty == "brutal") {
		MyMaxTries = 3;
	}

	return;

};

int32 FBullCowGame::GetMaxTries() const{
	
	return MyMaxTries;
};

void FBullCowGame::SetSecretWord(){
	
	std::ifstream inFile;

	//opens ListOfWords.txt file which has 100 words to select from
	inFile.open("ListOfWords.txt");

	if (inFile.fail()) {
		std::cerr << "Error opening file" << std::endl;
		exit(1);
	}

	//pick a random number from 0 to 99
	int32 RandomNumber = rand() % 100;

	int32 Count = 0;

	FText CurrentWord = "";

	inFile >> CurrentWord;

	//conditional expression searches for word in text file until the Count matches
	if (Count == RandomNumber) {
		SecretWord = CurrentWord;
	}
	else {
		while (Count != RandomNumber) {
			Count++;
			inFile >> CurrentWord;
		}
		SecretWord = CurrentWord;
	}

	inFile.close();
	
};

int32 FBullCowGame::GetCurrentTry() {

	return MyCurrentTrys;

};

/*void FBullCowGame::Reset() {
	constexpr int32 MAX_TRIES = 8;
	MyMaxTries = MAX_TRIES;

	const FString HIDDEN_WORD = "Planet";
	MyHiddenWord = HIDDEN_WORD;

	MyHiddenWord = HIDDEN_WORD;

	MyCurrentTry = 1;

	return;
}*/

/*bool FBullCowGame::IsGameWon() const {
	return false;
}*/

FText FBullCowGame::GetGuess() {

	int32 CurrentTry = GetCurrentTry();

	//get a guess from the player
	std::cout << "Try " << CurrentTry << ". Enter your guess: ";
	FText Guess = "";
	std::getline(std::cin, Guess);

	//converts all characters to lower case
	Guess = toLowerCase(Guess);

	return Guess;
};

//turns all characters of a String in to lower case
FText FBullCowGame::ToLowerCase(FText word) {

	int32 i = 0;

	//iterate through the word and make every letter lower case
	for (i = 0; i < (int32)(word.length()); i++) {
		//condition met if character is uppercase
		if ((word[i] >= 65) && (word[i] <= 90)) {
			//character is then transformed from uppercase to lower case
			word[i] = word[i] + 32;
		}
	}

	return word;


};

/*bool FBullCowGame::GuessCheckValidity(FText) {
	return false;
};*/

/*BullCowCount FBullCowGame::SubmitGuess(FString){

	//increment the turn number
	MyCurrentTry++;

	//setup a return variable
	BullCowCount BullCowCount;
	//loop through the letters in the guess
		//compare letters against the hidden word

	return BullCowCount();
}*/

[E0p9LyTq]

Your using declarations of FText and int32 are not in the proper file, move the declarations into your toLowerCase header file so the new types can be seen in all of your source files.

Either make your toLowerCase() function be inlined, or remove the function definition out of your header file into a source (cpp) file.

[vaderboi]

Why would I put the declarations in "toLowerCase.h"? Wouldn't the using declarations in "FBullCowGame.h" be enough for the entire solution since the FBullCowGame header file is included in both "main.cpp" and "FBullCowGame.cpp"?

Also, I got rid of the "toLowerCase.h" file and just placed the function it contained in "FBullCowGame.cpp" and the definition in "FBullCowGame.h".

[E0p9LyTq]

vaderboi wrote:

Why would I put the declarations in toLowerCase.h?

Your toLowerCase header file uses those redefined types. You declared the new types in FBullCowGame.h after you include toLowerCase.h. The compiler doesn't know what the new types are when working with toLowerCase.h.

You could declare the new types in FBullCowGame.h after you include <string> and before you include toLowerCase.h. Easier to just move the using statements into toLowerCase.h.

[vaderboi]

That did the trick! Thank you very much.