EOF problems

[stavros]

I have a .txt file with a path to a file on each line. My code opens this file & loops through each file to retrieve information. Everything is fine, but it seems to be trying to go one line beyond the text, then throws an error. How do I get it to stop at the end of the last line. PLEASE SEE CODE:

int main(){
    string line;
    ifstream file ("./file_list.txt");
    int count=0;
    char * file_ptr;
    char file_name[46];
    enum variable{LATITUDE=0,LONGITUDE=1,RAIN=2,WIND=3,TEMP=4,RH=5};
    FireWeatherWRF latitude, longitude,rain_temp,rain,wind,temp,rh;
    if (file.is_open()){
        while (!file.eof()){
            getline (file,line);
            for (int i=0;i<46;i++){file_name[i]=line[i];}
            file_ptr=file_name;
            if (count==0){
                latitude.read_WRF(file_ptr,LATITUDE);
                longitude.read_WRF(file_ptr,LONGITUDE);
                rain.read_WRF(file_ptr,RAIN);
                wind.read_WRF(file_ptr,WIND);
                temp.read_WRF(file_ptr,TEMP);
                rh.read_WRF(file_ptr,RH);
                count++;               
            }
            else{
                rain_temp.read_WRF(file_ptr,RAIN);
                cout<<rain_temp.data[0][0]<<endl;
                for (int lat=0;lat<SN;lat++){
                    for (int lon=0;lon<WE;lon++){
                        rain.data[lat][lon]=rain.data[lat][lon]+rain_temp.data[lat][lon];
                    }
                }
                if (count==24){count=0;}
                else {count++;}
            }
        }
        cout<<"cum rain: "<<rain.data[0][0]<<endl;
        file.close();                        
    }
    return 0;
}

output:

0
0
0
0
0
0
0
0
0
0
0
0
0
0.0785536
1.15065
1.9852
2.01943
2.01943
2.01943
2.01943
2.01943
2.01943
2.01943
2.01943
// this is where it is trying to read a line beyond any text
0x7fff1c934de0 is not valid
could not get pointer to NcVar latitude requested

[Duthomhas]

Lines 10 and 11 should be:

        while (getline (file,line)) {

Please, Don't loop on eof(). Just say "No!"

Hope this helps.

[stavros]

So I changed it & I still get the same error. Any other ideas?

[Duthomhas]

I don't believe you. Post your current code.

[stavros]

alright... I got the error to go away- but now i am not reading the last line of text...

[stavros]

Now, it's working, but i didn't change anything more than the condition statement of the while as suggested by Duoas-

[Duthomhas]

It is one of those weird things about C++.
Glad to have helped.
:-)