error with using a binary search

[kodera]

The program takes in a list of names, then sorts them, then asks for a name to serach for, and shoujld give the binary address of the memory.

As of right now, it crashes as soon as I type in a name to search for. Here is the program:

#include <iostream>
#include <stdlib.h>

using namespace std;

char first, last, C;

char **Create2DArray (unsigned int NumRows, unsigned int NumCols)
{
	char **	TwoDArray;
	TwoDArray = new char * [NumRows];
	for (unsigned int i = 0; i < NumRows; i++)
		TwoDArray [i] = new char [NumCols];
       return TwoDArray;
}

void Free2DArray (char **TwoDArray, unsigned int NumCols)
{
	for (unsigned int i = 0; i < NumCols; i++)
		delete [] TwoDArray [i];	
	delete [] TwoDArray;		
}

void BubbleSort (char ** Array, char NumofNames = 20)
{
	char i=0, j=0;
	for (i = 0; i < NumofNames; i++)
	{			
		for (j = 0; j < NumofNames-1; j++)
		{
			if (strcmp (Array [j+1], Array [j]) == -1)
			{
				char *temp  = Array [j];
				Array [j]   = Array [j+1];
				Array [j+1] = temp;
			}
		}
	}
}

char BinarySearch (char TwoDArray[10])
	{
	do {
		char mid = (last + first) / 2;  // compute mid point.
        if (TwoDArray[mid] == C)
			return mid;
        else if (C < TwoDArray[mid]) 
           last = mid - 1;
        else
           first = mid+1;     // found it. return position
	   }  while (first <= last);
	return -1;
	}

int main ()
{
    unsigned int NumofNames = 5;
    unsigned int NumCols = 20;
	cout << "Enter your names with a space in between each name. Type the ENTER key when finished. " << endl;
	cout << "\nEnter list of names: ";
    char ** TwoDArray = Create2DArray (NumofNames, NumCols);
    for (unsigned int i = 0; i < NumofNames; i++)
		{
		cin >> TwoDArray [i];
		
		if ((cin.get() == '\n') && (NumofNames <= 5))
			{
			cout << "\nYou have entered: " << endl;
			for (unsigned int j = 0; j < NumofNames; j++)
				cout << TwoDArray [j] << "  " << endl;
				cout << endl;
			}
		}

	BubbleSort (TwoDArray, NumofNames);

	cout << "\nHere are the names in sorted order:\n";
	for (unsigned int k = 0; k < NumofNames; k++)
		cout << TwoDArray [k] << "  " << endl;
		cout << endl;

	cout << "Which name do you want to search for? " << endl;
	for (unsigned int i = 0; i < NumofNames; i++)
		{
		cin >> TwoDArray[i];

		BinarySearch (TwoDArray[10]);
		cout << "The index of the string is: " << TwoDArray << endl;
		}

	return 0;
	Free2DArray (TwoDArray, NumCols);
}

[justAbeginner]

may i suggest u use an vector<string> to put the names in...
in that way u can use eather the sort and find functions from algorithm, or u can make ur own, but it should be much easyer then with dinamic alocation of 2D arrays

[kodera]

We have to use the dynamic array, as set by the "requirements" of our professor for this assignment. At this point, I need the binary search to work, but I am not sure what Name should be compared against since I am not sure how to compare name to another name in my array...

cout << "Which name do you want to search for? " << endl;
	cin >> Name;

	BinarySearch (TwoDArray[10]);
	if (Name = TwoDArray)
		cout << "The index of the string is: " << Name << endl;
	else
		cout << "The string you seek is missing. " << endl;

[justAbeginner]

first of all, change the if to if(Name==TwoDArray)
and second, try to make just one array that will store the names, and when u search for a name, count how many places the pointer has changed, that counter will give u the index you are searching for.