Ending out of loop without return 0

[kodera]

In my code, I am trying to end out of the for loop to continue with my next list of arguments, but do not know how to properly exit out of the loop so as to continue...

BubbleSort (TwoDArray, NumofNames);
	cout << "\nHere are the names in sorted order:\n";
	for (unsigned int k = 0; k < NumofNames; k++)
		{
		cout << TwoDArray [k] << "  " << endl;
		}

    Free2DArray (TwoDArray, NumCols);

	cout << "Which name do you want to search for? " << endl;

[oghmaosiris]

It should work... your K is being incremented at the end of every iteration.

What exactly is it doing?

[kodera]

here is the code in it's whole:
it displays my final list of sorted names, and then crashes, because I had to remove the return 0 statement, so that it would continue with the rest of my code...

this has soem other issues, since I am still working on adding the BinarySearch stuff.

#include <iostream>
#include <stdlib.h>

using namespace std;

char **Create2DArray (unsigned int NumRows, unsigned int NumCols)
{
	char **	TwoDArray;
	TwoDArray = new char * [NumRows];
	for (unsigned int i = 0; i < NumRows; i++)
		TwoDArray [i] = new char [NumCols];
       return TwoDArray;
}

void Free2DArray (char **TwoDArray, unsigned int NumCols)
{
	for (unsigned int i = 0; i < NumCols; i++)
		delete [] TwoDArray [i];	
	delete [] TwoDArray;		
}

void BubbleSort (char ** Array, char NumofNames = 20)
{
	char i=0, j=0;
	for (i = 0; i < NumofNames; i++)		//states i, must be less than allocated amount
	{			
		for (j = 0; j < NumofNames-1; j++)			//???
		{
			if (strcmp (Array [j+1], Array [j]) == -1)		//checks to see if i is greater than j in array
			{
				char *temp  = Array [j];		//creates a temporary location for i
				Array [j]   = Array [j+1];					//swaps i with j
				Array [j+1] = temp;								//places j at top of array
			}
		}
	}
}

char BinarySearch (char TwoDArray[10], char first, char last, char C)
	{
	do {
		char mid = (last + first) / 2;  // compute mid point.
        if (TwoDArray[mid] == C)
			return mid;
           first = mid + 1;  // repeat search in top half.
        else if (C < TwoDArray[mid]) 
           last = mid - 1; // repeat search in bottom half.
        else
           first = mid+1;     // found it. return position /////
	   }  while (first <= last);
	return -1;
	}

int main ()
{
    unsigned int NumofNames = 5;
    unsigned int NumCols = 20;
	cout << "Enter your names with a space in between each name. Type the ENTER key when finished. " << endl;
		cout << "\nEnter list of names: ";
    char ** TwoDArray = Create2DArray (NumofNames, NumCols);
    for (unsigned int i = 0; i < NumofNames; i++)
		{
		cin >> TwoDArray [i];
		
		if ((cin.get() == '\n') && (NumofNames <= 5))
			{
			cout << "\nYou have entered: " << endl;
			for (unsigned int j = 0; j < NumofNames; j++)
				cout << TwoDArray [j] << "  " << endl;
				cout << endl;
			}
		}

	BubbleSort (TwoDArray, NumofNames);
	cout << "\nHere are the names in sorted order:\n";
	for (unsigned int k = 0; k < NumofNames; k++)
		{
		cout << TwoDArray [k] << "  " << endl;
		}

    Free2DArray (TwoDArray, NumCols);

	cout << "Which name do you want to search for? " << endl;
	for (unsigned int i = 0; i < NumofNames; i++)
		{
		cin >> TwoDArray [i];
	BinarySearch (TwoDArray, char first, char last, char C);
	cout << "The index of the string is: " << TwoDArray << endl;
		}
	return 0;
}

[oghmaosiris]

on line 87 why are you declaring a function? Function declarations happen before you enter Main.

wait a tick... you don't have any function declarations... you need to declare them before you define them.

Lines 43-45 you need curly braces for the if statement because its beyond 1 line.

[kodera]

I guess I get confused on where to declare and what to declare.... so my char's for first, last, and C are declared in the void BinarySearch... so do I have to redeclare the same thing under my int main...?

[oghmaosiris]

Well, you need to declare the functions themselves before you use them, its usually done right after the using namespace std;.

Then you declare a variable you are going to pass to the function inside the main function.

[kodera]

New problem... if you know how to fix, chime in!! When it gets to the end where it asks for what name to search for, it crashes as soon as the name is entered...??

#include <iostream>
#include <stdlib.h>

using namespace std;

char first, last, C;

char **Create2DArray (unsigned int NumRows, unsigned int NumCols)
{
	char **	TwoDArray;
	TwoDArray = new char * [NumRows];
	for (unsigned int i = 0; i < NumRows; i++)
		TwoDArray [i] = new char [NumCols];
       return TwoDArray;
}

void Free2DArray (char **TwoDArray, unsigned int NumCols)
{
	for (unsigned int i = 0; i < NumCols; i++)
		delete [] TwoDArray [i];	
	delete [] TwoDArray;		
}

void BubbleSort (char ** Array, char NumofNames = 20)
{
	char i=0, j=0;
	for (i = 0; i < NumofNames; i++)
	{			
		for (j = 0; j < NumofNames-1; j++)
		{
			if (strcmp (Array [j+1], Array [j]) == -1)
			{
				char *temp  = Array [j];
				Array [j]   = Array [j+1];
				Array [j+1] = temp;
			}
		}
	}
}

char BinarySearch (char TwoDArray[10])
	{
	do {
		char mid = (last + first) / 2;  // compute mid point.
        if (TwoDArray[mid] == C)
			return mid;
        else if (C < TwoDArray[mid]) 
           last = mid - 1;
        else
           first = mid+1;     // found it. return position
	   }  while (first <= last);
	return -1;
	}

int main ()
{
    unsigned int NumofNames = 5;
    unsigned int NumCols = 20;
	cout << "Enter your names with a space in between each name. Type the ENTER key when finished. " << endl;
	cout << "\nEnter list of names: ";
    char ** TwoDArray = Create2DArray (NumofNames, NumCols);
    for (unsigned int i = 0; i < NumofNames; i++)
		{
		cin >> TwoDArray [i];
		
		if ((cin.get() == '\n') && (NumofNames <= 5))
			{
			cout << "\nYou have entered: " << endl;
			for (unsigned int j = 0; j < NumofNames; j++)
				cout << TwoDArray [j] << "  " << endl;
				cout << endl;
			}
		}

	BubbleSort (TwoDArray, NumofNames);

	cout << "\nHere are the names in sorted order:\n";
	for (unsigned int k = 0; k < NumofNames; k++)
		cout << TwoDArray [k] << "  " << endl;
		cout << endl;

	cout << "Which name do you want to search for? " << endl;
	for (unsigned int i = 0; i < NumofNames; i++)
		{
		cin >> TwoDArray[i];

		BinarySearch (TwoDArray[10]);
		cout << "The index of the string is: " << TwoDArray << endl;
		}

	return 0;
	Free2DArray (TwoDArray, NumCols);
}