Timer Help For Newbie

[thebig1]

Write your question here.

Hi Guys,

I am trying to create a function that when its on, it counts time. Then off it returns 0, then if on begins counting again but having no luck at all.
This is what I have so far but I get errors.

  Put the code you need help with here.
{ /* begin of FUNCTION BLOCK: Timer */

	/* type code here */

	RTE_Services_Time_ReadTime(&u32CurrentTime);
	
	if (ENABLE!= true)
	{	
	goto Exit;
	}
		{
		Q = (u32CurrentTime - u32StartTime); 
		}	
		
	RTE_Services_Time_ReadTime(&u32StartTime);
	
	return true;
	
			{
			Exit:
			return false;
			}
} /* end of FUNCTION BLOCK: Timer */

[Handy Andy]

Hello thebig1,

Welcome to the forum,

Your code slightly revised:

// <--- Missing function definition.
{ /* begin of FUNCTION BLOCK: Timer */

  /* type code here */

  RTE_Services_Time_ReadTime(&u32CurrentTime);

  if (ENABLE != true)
  {  // <-- Not needed for a single statement.
	  return false;
  }
  else  // <--- Missing.
  {
	  Q = (u32CurrentTime - u32StartTime);
  }

  RTE_Services_Time_ReadTime(&u32StartTime);

  return true;

//  Not needed. Bothe the {} and the code
  //{
  //Exit:
	 // return false;
  //}
} /* end of FUNCTION BLOCK: Timer */

I can only guess that "ENABLE" is a variable passed to the function. I do not see it or how it is passed.

Just like I can only guess that "RTE_Services_Time_ReadTime" is from a header file that I am not familiar with.

Your line 10 using a "goto" is bad programming. It is much better to use "return false;" in its place.

Between your lines 11 and 12 you are missing an "else" statement.

Your line 13 uses the variables "u32CurrentTime" and "u32StartTim", but where did these variables get their value.

Not sure if you realize it or not, but your line 18 is the end of the function and what comes after should not be used.

If you are using a header file that is not common you need to note this in your question.

Hope that helps for now,

Andy

P.S. Realized that "ENABLE" may need to be toggled somewhere in the function.