c++ compiler errors on Amortization Project

[cking391]

I am a beginner who is struggling with understanding how to fix 14 syntax errors. I know this is homework, but I am really trying to understand what I am doing wrong and what to do next. Any help would be greatly appreciated.

[code]
Put the code you need help with here.
[Amortization.h]
#pragma once
#ifndef AMORTIZATION_H
#define AMORTIZATION_H
class Amortization
{
private:
double P; // principle
double I; // interest
double N; // periods

public:
Amortization(); //default constructor (prototype)
Amortization(double p, double i, double n);
getPayment(double amort, amort2);
};

#endif // ! AMORTIZATION_H

[Amortization.cpp]
#include <iostream>
#include <cmath>
#include "Amortization.h"

using namespace std;
using namespace::std;
using::Amortization;


// default constructor implementation
Amortization::Amortization()
{
P = 0;
I = 0;
N = 360;
}
Amortization::Amortization(double p, double i, double n)
{
P = p;
I = i;
N = n;

}
double Amortization::getPayment();
{
// algorithm for amortization
// Payment = P [I * (1 + I)^N] / (1 + I)^N - 1]
// Payment = P [I * powerPart] / [powerPart - 1]


I = I / 1200
double powerPart p= pow((1 + I), N);
double payment = p *((I * powerPart) / (powerPart - 1));

return payment;

}
[CourseProjectWeek7Source.cpp]
#include <iostream>
#include <iomanip>
#include <cmath>
#include "Amortization.h"
#include <fstream>
#include <string>

using namespace std;
using namespace::std;
using std::ios;


void menu(void);
void writeData(void);
void readData(void);

const char FileName[] = "TestAddress.txt";

int main() {
double Amortization::amort;
double principle, interest, periods, amort, amort2;

cout << "Your default payment is $" << setprecision(2) << fixed << amort.getPayment << " endl";
cout << " enter principle: ";
cin >> principle;
cout << "enter interest: ";
cin >> interest;
cout << "enter number of perisods: ";
cin >> periods;
Amortization amort2(principle, interest, periods);

cout << "Your payment is $" << amort2.getPayment << endl;

cin.clear();
cin.ignore();
cin.get();

menu();
system("Pause");
return 0;
} //end main

void menu(void) {
//allow user to choose to append records, display records or exit the program

int menuChoice = 0;

cout << "1. Display Data" << endl;
cout << "2. Write Data" << endl;
cout << "0. Exit" << endl;

cin >> menuChoice;

if (menuChoice == 1)
{
readData();
}
else if (menuChoice == 2)
{
writeData();
}

}//end menu

void writeData(void) {
string loan;
string rate;
string years;

string userChoice = "Y";

//Write the Address Info to a file
//loop while user still has data to write to file
//eg outStream<<name<<”#”; //where # is the delimiter

ofstream myFile;
myFile.open(FileName, ios::app);

while (userChoice == "Y")
{
// loop to get user input
cin.ignore();

cout << "Append Records" << endl << endl;
cout << "Loan.......... ";
getline(cin, loan);
cout << "Rate.........";
getline(cin, rate);
cout << "Years.........";
getline(cin, years);
cout << "Balance.........";


// format
// John Smith, 902 Union Ave, Any Town, TX, 79552

myFile << loan << ","
<< rate << ","
<< years << "," << endl;
cout << "Enter another Record? (Y/N) ";
cin >> userChoice;
}


myFile.close();

}//end write data

void readData(void) {
//read data from a file
//use the split function to break a
//deliminated line of text into fields
ifstream inMyStream(FileName);

if (inMyStream.is_open()) {

//set character to use as a line between record displays
string recBreaks = "";
recBreaks.assign(20, '-');

int fieldCount = 0; //keep track of the number of fields read
int recordCount = 1; //keep track of the number of records read

//read the first field
fieldCount = 1;
string fieldBuffer;
getline(inMyStream, fieldBuffer, ',');

while (!inMyStream.eof()) {

//display the field
switch (fieldCount) {
case 1:
cout << recBreaks << endl;
cout << "record # " << recordCount << endl;
cout << "Loan...." << fieldBuffer << endl; break;
case 2:
cout << "Rate.." << fieldBuffer << endl; break;
case 3:
cout << "Years...." << fieldBuffer << endl;

fieldCount = 0;
recordCount++; break;
}

//read the next field
getline(inMyStream, fieldBuffer, ',');
fieldCount++;
}
cout << recBreaks << endl;

inMyStream.close();
}
}//end read data

[dhayden]

Here is your code with the syntax errors cleaned up. Search for "dmh" to see what I changed. Note that I jammed it all into one file.

#ifndef AMORTIZATION_H
#define AMORTIZATION_H
class Amortization
{
  private:
    double P;			// principle
    double I;			// interest
    double N;			// periods

  public:
      Amortization();		//default constructor (prototype)
      Amortization(double p, double i, double n);
    double getPayment();	// Looking at the calls to getPayment, it appears that it takes no parameters.
    // also you must indicate what type it returns (a double)

};

#endif // ! AMORTIZATION_H

// [Amortization.cpp]
#include <iostream>
#include <cmath>
// #include "Amortization.h"

using namespace std;
using namespace::std;
// using::Amortization;  // dmh. no need for this

// default constructor implementation
Amortization::Amortization()
{
    P = 0;
    I = 0;
    N = 360;
}

Amortization::Amortization(double p, double i, double n)
{
    P = p;
    I = i;
    N = n;

}

// dmh. In Amortization.h you declared this with 2 parameters.  The declaration and this
// definition must match
double
Amortization::getPayment()	// dmh no semicolon between definition of function and it's body of code
{
// algorithm for amortization
// Payment = P [I * (1 + I)^N] / (1 + I)^N - 1]
// Payment = P [I * powerPart] / [powerPart - 1]

    // dmh. Don't change the member I.  Otherwise think what would happen if you called getPayment() twice,
    // the second call would use the modified version of I.  So instead, use a local variable for the modified I.
    // I = I / 1200 ;
    double interest = I/1200;
    double powerPart = pow((1 + interest), N);

    // dmh Use "P" instead of "p".  Variable names are case sensitive
    double payment = P * ((interest * powerPart) / (powerPart - 1));

    return payment;

}

//[CourseProjectWeek7Source.cpp]
#include <iostream>
#include <iomanip>
#include <cmath>
// #include "Amortization.h"
#include <fstream>
#include <string>

using namespace std;
using std::ios;

void
menu(void);
void
writeData(void);
void
readData(void);

const char FileName[] = "TestAddress.txt";

int
main()
{
// double Amortization::amort;  // dmh you can't define a member of a class, only an instance of the class itself.
    double
	principle,
	interest,
	periods;


    // dmh You can't call getPayment on a class instance that you haven't defined. And there's no point defining
    // it since you haven't entered the principal, interest, and number of periods
   // cout << "Your default payment is $" << setprecision(2) << fixed << amort.getPayment() << " endl";	// dmh. To call getPayment, add "()" after the name

    // dmh check your spelling in the next few lines
    cout << " enter principle: ";
    cin >> principle;
    cout << "enter interest: ";
    cin >> interest;
    cout << "enter number of perisods: ";
    cin >> periods;

    Amortization amort2(principle, interest, periods);

    // dmh use "()" to call getPayment
    cout << "Your payment is $" << amort2.getPayment() << endl;

    cin.clear();
    cin.ignore();
    cin.get();

    menu();
    system("Pause");
    return 0;
}						 //end main

void
menu(void)
{
//allow user to choose to append records, display records or exit the program

    int
	menuChoice = 0;

    cout << "1. Display Data" << endl;
    cout << "2. Write Data" << endl;
    cout << "0. Exit" << endl;

    cin >> menuChoice;

    if (menuChoice == 1) {
	readData();
    } else if (menuChoice == 2) {
	writeData();
    }

}						 //end menu

void
writeData(void)
{
    string
	loan;
    string
	rate;
    string
	years;

    string
	userChoice = "Y";

//Write the Address Info to a file
//loop while user still has data to write to file
//eg outStream<<name<<”#”; //where # is the delimiter

    ofstream
	myFile;
    myFile.open(FileName, ios::app);

    while (userChoice == "Y") {
// loop to get user input
	cin.ignore();

	cout << "Append Records" << endl << endl;
	cout << "Loan.......... ";
	getline(cin, loan);
	cout << "Rate.........";
	getline(cin, rate);
	cout << "Years.........";
	getline(cin, years);
	cout << "Balance.........";

// format
// John Smith, 902 Union Ave, Any Town, TX, 79552

	myFile << loan << "," << rate << "," << years << "," << endl;
	cout << "Enter another Record? (Y/N) ";
	cin >> userChoice;
    }

    myFile.close();

}						 //end write data

void
readData(void)
{
//read data from a file
//use the split function to break a
//deliminated line of text into fields
    ifstream
    inMyStream(FileName);

    if (inMyStream.is_open()) {

//set character to use as a line between record displays
	string
	    recBreaks = "";
	recBreaks.assign(20, '-');

	int
	    fieldCount = 0;	//keep track of the number of fields read
	int
	    recordCount = 1;	//keep track of the number of records read

//read the first field
	fieldCount = 1;
	string
	    fieldBuffer;
	getline(inMyStream, fieldBuffer, ',');

	while (!inMyStream.eof()) {

//display the field
	    switch (fieldCount) {
	    case 1:
		cout << recBreaks << endl;
		cout << "record # " << recordCount << endl;
		cout << "Loan...." << fieldBuffer << endl;
		break;
	    case 2:
		cout << "Rate.." << fieldBuffer << endl;
		break;
	    case 3:
		cout << "Years...." << fieldBuffer << endl;

		fieldCount = 0;
		recordCount++;
		break;
	    }

//read the next field
	    getline(inMyStream, fieldBuffer, ',');
	    fieldCount++;
	}
	cout << recBreaks << endl;

	inMyStream.close();
    }
}						 //end read data 

[cking391]

Please ignore and stop as I have managed to somehow figure this out. Now that I am so very happy I am going to take the time to step in and out of each line to better understand what I have done. Happy Programming and thanks for keeping me from loosing my sanity on top of loosing sleep.

[cking391]

Thanks dhayden but this program also needs to display the data which the code doesn't but I have figured it out with my original program. But I really appreciate your help and how you cleaned it up. But I will be submitting my original work in hopes for a teacher comment for how to improve. One more week to go in this class and I must say I have enjoyed this more than C# but will continue to play, write, learn, and grow.

[dhayden]

No problem. Good luck.

One bit of advice: compile your code frequently rather than writing a ton of code and seeing if it will compile. By compiling frequently, you'll catch errors early rather than letting them propagate.