Program crashes as pointer tries to access struct

[oldspiderdude]

Hi, this is my solution to UVa123: https://uva.onlinejudge.org/index.php?option=com_onlinejudge&Itemid=8&page=show_problem&problem=59
I am not sure exactly why the code crashes at line 104 when I try to access a struct with a pointer that was allocated memory

My Input:
is
::
Descent of Man
END

Output:
did END
Working on title #0
descent of man
titleLength 14
In string, searching for words
Word Beg, Word Length, curCursor: 0, 7, 7
descent
loop: 0
Word detected as not ignored
finished capitalisation
DESCENT
finished replacing
DESCENT of man
created new storeByKeyWord
set head to curr
0x687210
DESCENT

Then it crashes

My Code:

#include <iostream>
#include <sstream>
#include <string>
#include <stdio.h>
#include <locale>
#include <stdlib.h>


using namespace std;

bool isIgnored(string wordCheck, string ignoredWords[], int ignoreCount) {
    for (int loop=0; loop<ignoreCount; loop++) {
        cout << "loop: " << loop << endl;
        if(wordCheck==ignoredWords[loop]) {
            return true;
        }
    }
    return false;
}

struct storeByKeyWord {
string keyword;
string entireTitle;
storeByKeyWord* next;
};

string word, newCapWord, newCapPhrase;
int ignoreCount=0;
int numTitles=0;
bool spaceBefore;
int titleLength;
bool wordUnique;
int wordBegCur, wordLeng, curCursor;


int main()
{
    storeByKeyWord *head=NULL, *curr=NULL, *tail=NULL, *findPlace=NULL, *findPlaceLag=NULL;
    string* titles=new string[200];
    string* wordsIgnore=new string[50];
    while(1) {
        cin >> word;
        if (word=="::") {
            break;
        }
        wordsIgnore[ignoreCount]=word;
        ignoreCount++;
    }
    while (getline(cin, word, '\n')) {
        if (!cin||word=="END") {
            break;
        }
        if (word=="") continue;
        titles[numTitles]=word;
        titleLength=word.length();
        for (int looptoLower=0; looptoLower<titleLength; looptoLower++) {
            //cout << "looptoLower, char: " << looptoLower << ", " <<
            //word[looptoLower]<< endl;
            word[looptoLower]=char(tolower(word[looptoLower]));
            //cout << "char after" << word[looptoLower] << endl;
        }
        titles[numTitles]=word;
        numTitles++;
    }
    cout << "did END" << endl;
    for (int loopFindKeywords=0; loopFindKeywords<numTitles; loopFindKeywords++) {
        cout << "Working on title #" << loopFindKeywords << endl;
        cout << titles[loopFindKeywords] << endl;
        wordBegCur=0; wordLeng=0; curCursor=0;
        titleLength=(titles[loopFindKeywords]).length();
        newCapPhrase=titles[loopFindKeywords];
        cout << "titleLength " << titleLength << endl;
        while (curCursor<titleLength-1) {
            curCursor=wordBegCur;
            wordLeng=0;
        cout << "In string, searching for words" << endl;
            while ((newCapPhrase[curCursor]!=' ')&&(curCursor<=titleLength-1)) {
                wordLeng++;
                curCursor++;
            }
        cout << "Word Beg, Word Length, curCursor: " << wordBegCur << ", " <<
        wordLeng << ", " << curCursor << endl;
        newCapWord=newCapPhrase.substr(wordBegCur,wordBegCur+wordLeng);
        cout << newCapWord << endl;
        if (!isIgnored(newCapWord, wordsIgnore, ignoreCount)) {
            cout << "Word detected as not ignored" << endl;
            for (int loopCap=0; loopCap<wordLeng; loopCap++) {
                newCapWord[loopCap]=char(toupper(newCapWord[loopCap]));
            }
            cout << "finished capitalisation" << endl;
            cout << newCapWord << endl;
            newCapPhrase.replace(wordBegCur, wordBegCur+wordLeng, newCapWord);
            cout << "finished replacing" << endl;
            cout << newCapPhrase << endl;
            curr=(storeByKeyWord*)malloc(sizeof(storeByKeyWord));
            cout << "created new storeByKeyWord" << endl;
            if (head==NULL) {
                head=curr;
                cout << "set head to curr" << endl;
            }
            cout << curr << endl;
            cout << newCapWord << endl;
            (curr->keyword)=newCapWord;
            cout << "curr->keyword: " << (curr->keyword) << endl;
            (curr->entireTitle)=newCapPhrase;
            cout << "curr->entireTitle: " << (curr->entireTitle) << endl;
            findPlace=head; findPlaceLag=head;
            while(1) {
                if ((findPlace->keyword)>(curr->keyword)) {
                    if (findPlace==head) {
                        (curr->next)=head;
                        (head->next)=NULL;
                        head=curr;
                        break;
                    }
                    else {
                        while (1) {
                            if ((findPlaceLag->next)==findPlace) {
                                (findPlaceLag->next)=curr;
                                (curr->next)=findPlace;
                                break;
                            }
                            findPlaceLag=(findPlaceLag->next);
                        }
                    }
                    break;
                }
                else {
                    if ((findPlace->next)!=NULL) {
                        findPlace=(findPlace->next);
                        continue;
                    }
                    else {
                        (curr->next)=(findPlace->next);
                        (findPlace->next)=curr;
                        break;
                    }
                }
            }
        }
        wordBegCur=curCursor+1;
        }
        break;
    }
    spaceBefore=false;
    while (1) {
        if (spaceBefore) cout << endl;
        cout << (head->entireTitle);
        if (head->next==NULL) {
            break;
        }
        spaceBefore=true;
        head=(head->next);
    }


    return 0;
}

[ne555]

> string* titles=new string[200];
unnecessary dynamic allocation

> if (!cin||word=="END") {
¿where does it say that the input ends with "END"?

> for (int looptoLower=0; looptoLower<titleLength; looptoLower++) {
not a good name for an index, in fact it's quite bad.

> cout << "did END" << endl;
annoying logs messages.
use the debugger to make a step-by-step run

> curr=(storeByKeyWord*)malloc(sizeof(storeByKeyWord));
storeByKeyWord contains std::string, which is not POD.
std::string has a constructor, which is bypassed by malloc(), then undefined behaviour.
so instead of malloc() it should be new, however, ¿why are you rolling your own list? (and a linked list for more injury)

here you are

std::map< std::string, std::vector<std::string> > dictionary;
dictionary[keyword].push_back(title);

[oldspiderdude]

Thanks, I didn't know I could use structs like lists.
I also tried using new, it worked and stopped crashing when I wrote

TYPE* pName= (TYPE*) new TYPE[sizeof(TYPE)]();