Array help

[piratekingluffy]

thank you.

[Thomas1965]

int ar[25];
fillArray(ar, 100);

void fillArray(int a[], int size)
{
	for (int i = 0; i < 100; i++)
		a[i] = rand() % 100 + 1;
}

Why do you try to write 100 elements into an array with the size of 25?

[goldenchicken]

Can you specify the problem? "A debug error" isn't very clear. Maybe you meant a compiler error, when your program won't run.

Also, you include <vector>, but you never use it. using a std::vector to store your integers will make your code easier. For example, you won't have to pass in a size parameter.

[Chervil]

The code is consistent in that it consistently ignores the size parameter - or passes the wrong value in the first place. For example here:

void printArray(int a[], int size)
{
	for (int i = 0; i < 25; i++)
		cout << a[i] << endl;
}

Line 33 should use the function parameter, not use some arbitrary number plucked from thin air.

void printArray(int a[], int size)
{
	for (int i = 0; i < size; i++)
		cout << a[i] << endl;
}

Inside function main() you could do something like this:

    const int SIZE = 25;
    
    int ar[SIZE];

    fillArray(ar, SIZE);

    printArray(ar, SIZE);

    int count = countEvens(ar, SIZE);

After that, the value 25 should appear just once in the entire program, where the constant is defined.

Similarly, the value 100 should appear just once in the entire program, where the random number is generated.

[piratekingluffy]

thanks for the help. I figured it out thanks to you guys.

[MikeyBoy]

Please DON'T delete your question after you've got your answer. It makes this thread useless as a learning resource for anyone else. It's a selfish abuse of this forum.

Please edit your post to restore the original question.

[piratekingluffy]

MikeyBoy. sorry. I won't do it again. I forgot what I wrote in the original question and I do not have the original broken code anymore either