tell me

[chicofeo]

tell you what?

[Enoizat]

It seems to work, but I think it would be more consistent if you moved the functions that modify the internal state of your structs inside the structs themselves.

Just to give you a general idea:

#include <iostream>
#include <limits>

struct Node {
    int data;
    Node *p_next;
};

struct List {
    void addNodeToTail(Node* p);
    void timMax();
    Node* p_head {nullptr};
    Node* p_tail {nullptr};
};

void List::addNodeToTail(Node* to_be_added)
{
    if(p_head == nullptr) {
        to_be_added->p_next = nullptr;
        p_head = p_tail = to_be_added;
    } else {
        p_tail->p_next = to_be_added;
        p_tail = to_be_added;
    }
}

Node* createNodeFromData(int x)
{
    Node *tmp = new Node;
    tmp->data = x;
    tmp->p_next = nullptr;
    return tmp;
}

void input(List& l)
{
    std::cout << "Nhap so Node: ";
    int n;
    std::cin >> n;
    std::cin.ignore(1);
    for(int i = 0; i < n; i++) {
        std::cout << "Please give me data for next node: ";
        int x;
        std::cin >> x;
        std::cin.ignore(1);
        Node* tmp = createNodeFromData(x);
        l.addNodeToTail(tmp);
    }
}

void List::timMax()
{
    int x = p_head->data;
    for(Node* p = p_head; p != nullptr; p = p->p_next){
        if(p->data > x) {
            x = p->data;
        }
    }
    std::cout << "\nMax : " << x;
}

void waitForEnter();

int main()
{
    List l;
    input(l);
    l.timMax();
    waitForEnter();
    return 0;
}

void waitForEnter()
{
    std::cout << "\nPress ENTER to continue...\n";
    std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
}

However this is a forum to ask for help, not to have our code evaluated.
Good luck with your project!

[Enoizat]

I've just realized this post is nearly identical to another one opened by a different user (tanhhn58)
http://www.cplusplus.com/forum/beginner/217366/
...Which is already signed as solved without any answer.