error with sorting

[navi33]

hi. im new to this sorting stuff so please help me out here.
im assign to input 10 numbers, then sort then to descending order.
my problem is after i input 10 number there some negative numbers popping out that i dont know where it came and then the program ends....

Y_Y help me pls i need this done tommorrow.
#include <iostream>

using namespace std;

int main()
{
int a[10];
int i,j,temp,flag=0;
for(i=1,j=0;i<11,j<10;j++,i++)
{
cout<<"Enter number"<<i<<": ";
cin>>a[j];
}
for (i=0;i<10;i++)
{
for(j=0;j<(10-i);j++)
{
if (a[j]<a[j+1])
temp=a[j];
a[j]=a[j+1];
a[j+1]=temp;
}
}
for(i=0;i<10;i++)
cout<<a[i];
return 0;
}

[z05DSL3A]

Here is some code to do an ascending sort, I will leave it up to you to change it to descending.
You will also need to understand the code and change it, as your teacher will know that you have not written this.

#include <iostream>

using namespace std;

const int limit(10);  //  

int main()
{
    int data[limit] = {0};
    
    for(int i(0); i < limit; ++i)
    {
        cout << "Enter number " << (i + 1) << " : ";
        cin >> data[i];
    }

    //-- Bubble sort Pseudocode------------------------------------------------
    //do
    //  swapped := false
    //  for each i in 0 to length(A) - 2 inclusive do:
    //    if A[i] > A[i+1] then
    //      swap( A[i], A[i+1] )
    //      swapped := true
    //    end if
    //  end for
    //while swapped
    //
    //-- Bubble sort ----------------------------------------------------------

    bool swapped(false);
    do
    {
        swapped = false;
        for(int i(0); i < limit - 1; ++i)
        {
            if(data[i] > data[i+1])
            {   //swap
                int temp = data[i+1];
                data[i+1] = data[i];
                data[i] = temp;
                swapped = true;
            }
        }
    }while(swapped);
    //-- End of bubble Sort----------------------------------------------------

    cout << "Numbers sorted in ascending order: "; 
    for(int i(0); i < limit; ++i)
    {
        cout << data[i] << " ";
    }
    cout << endl;

    return 0;
}

[navi33]

ill be checking this out.
but still be wanting to know what went wrong with my code.
thx~

[z05DSL3A]

but still be wanting to know what went wrong with my code.

Good reply. :0)

From the looks of the code posted, the section

if (a[j]<a[j+1])
temp=a[j];
a[j]=a[j+1];
a[j+1]=temp;

should be

if (a[j]<a[j+1])
{
    temp=a[j];
    a[j]=a[j+1];
    a[j+1]=temp;
}

p.s. To post code use the [code] [/code] tags.

[navi33]

o.o
i didnt see that..

Hahaha thx now my program is working~

love this site!

mwuahh~

[amit0991]

dude replace j< ( 10 - i ) by j< (9 - i ). your problem is solved..

[OnymousIllusion]

You could use vectors here is a video

http://www.youtube.com/watch?v=rn6qNGI-g1U