simple program does't work

[krossas]

Hello, my program does't seem to be working. It was supposed to write how many times the inserted name was used in the txt document. I think that the problem might be with the string inserted text. But the k returns as 0.Any help is appreciated.

  #include <iostream>
#include <fstream>
using namespace std;


struct Song{
    string band;
    string song;
    double m;
    double s;
};
 void read (Song S[],int &n);
int main()
{
    int k = 0;
    int n;
    Song S[100];
    string name;
    cout << "Enter bands name: " << endl;

    getline(cin,name);
    read(S,n);
        for (int i =1;i<=n;i++)
    {
        if (name == S[i].band)
        {
            k++;
        }

    }
    cout << "Number of " << name << " songs: " << k << endl;

    return 0;
}
//-------
    void read (Song S[],int &n)
    {
        ifstream fd ("d.txt");
        fd >> n;
        for (int i = 1;i<=n;i++)
        {
            getline(fd,S[i].band,'-');
            getline(fd,S[i].song,',');
            fd >> S[i].m >> S[i].s;
        }
}

[TarikNeaj]

Im very confused.

read(D,n) // What is "D"? Your array is called "S".

if (name == D[i].band) // Same here. Your array was created as Song S[]. Not Song D[]
{
            k++;
}

This is also an incorrect for-loop if you want to loop through the entire array -

for (int i = 1;i<=n;i++)

Array indexes start at 0. So if you have an array of 100. they would be 0-99.

for(int i = 0; i < 100; i++)
{
    // code here
}

[krossas]

sorry, i changed the names from my native language so left some unchanged.
im worried the most about this part:

string name;
getline(cin,name);
read(S,n);
for (int i =1;i<=n;i++)
{
if (name == S[i].band)
{
k++;
}

can the string be compared to an array?

[TarikNeaj]

Hey.

You are not comparing a string to an array. You are comparing a string to a string. Because S[i].band where band is a string.

The problem remains the same, as I pointed out earlier about the indexes of an array.

This is also an incorrect for-loop if you want to loop through the entire array -

for (int i = 1;i<=n;i++)

Array indexes start at 0. So if you have an array of 100. they would be 0-99.

for(int i = 0; i < 100; i++)
{
    // code here
}

This for-loop goes from 0-99.

You should google/youtube arrays to get a better understanding about how they work.