linked list and nodes

[sesslit805]

I need help with the funtion inserbypose();
please help it compiles but it's not working

#include <iostream>
#include<string>

using namespace std;

class LL;

class Node
{
  friend class LL;
private:
  string firstName;
  string lastName;
  string phoneNumber;
  Node * nextRecord;
};

class LL
{
private:
  Node* head;

  void destroy();

  //to dereference then put parenthesis.                                                                                                                                             

public:
  LL();
  LL(const LL&);
  ~LL();

  void append(string, string, string);
  void insertAtBeginning(string, string, string);
  void insertByPos(string, string, string, int);
  void print();
  void searchByName(string, string);
  void updateNumber(string, string, string);
  void removeRecord(string, string);
  void reverse();
};

//--------------------------------------------                                                                                                                                       
// the default constructor                                                                                                                                                           
LL::LL()
{

  head=nullptr;

}

//--------------------------------------------                                                                                                                                       
// the copy constructor                                                                                                                                                              
LL::LL(const LL& source)
{
  //  Node *nodeptr;                                                                                                                                                                 

  //head=nullptr;                                                                                                                                                                    

}

//----
}

//--------------------------------------------                                                                                                                                       
// the destructor                                                                                                                                                                    
LL::~LL()
{

  Node *nodeptr ;
  Node *nextNode;

  nodeptr = head;

  while ( nodeptr!= nodeptr)
    {
      nextNode = nodeptr-> nextRecord;
      delete nodeptr;

      nodeptr = nextNode;
    }


}

//--------------
void LL::print ()
{
  Node *nodeptr=head;

  while(nodeptr)
    {
      //display                                                                                                                                                                      
      cout << nodeptr -> firstName<< " " << nodeptr -> lastName << " " << nodeptr -> phoneNumber << endl << endl;

      //move thru the next node                                                                                                                                                      
      nodeptr = nodeptr -> nextRecord;


    }


}

//--------------------------------------------                                                                                                                                       
// search for a particular person in the list and print the                                                                                                                          
// corresponding phone number                                                                                                                                                        
void LL::searchByName (string fName, string lName)
{



}

}
// create a node and insert the node at the position pos                                                                                                                             
void LL::insertByPos (string fName, string lName, string phone, int pos)
{
  Node *newNode;
  Node *nodePtr;
  Node *previousNode = NULL;

  newNode = new Node;
  newNode -> firstName = fName;
  newNode -> lastName=lName;
  newNode -> phoneNumber =phone;
 
  if ( head==NULL )
    {
      return;
    }
  if (pos ==0)
    {
      newNode -> nextRecord= head;
      head = newNode;
    }
  int i =0;
  nodePtr = head;
  while ( nodePtr != NULL && i < pos)
    {
      previousNode = nodePtr;
      nodePtr= nodePtr ->  nextRecord;
      i++;
    }

  newNode -> nextRecord = previousNode -> nextRecord;
  previousNode -> nextRecord = newNode;



}
      

void LL::updateNumber(string fName, string lName, string newPhone)
{

}

//--------------------------------------------                                                                                                                                       
// Destroy all the nodes in the list                                                                                                                                                 
void LL::destroy()
{

}


//--------------------------------------------                                                                                                                                       
// traverse the list and reverse the list nodes so the last node                                                                                                                     
// becomes the first and the first node becomes the last one                                                                                                                         
void LL:: reverse()
{

}

//--------------------------------------------                                                                                                                                       
int main ()
{
  LL list1;

  list1.append ("Mayssaa", "Najjar", "878-635-1234");                                                                                                                                         
  list1.insertAtBeginning ("Jim", "Meyer", "337-465-2345");
  list1.append ("Joe", "Didier", "352-654-1983");
  list1.insertByPos ("Adam", "James", "202-872-1010", 2);
  list1.insertAtBeginning("Nancy", "Garcia", "617-227-5454");

  list1.print();

  /*                                                                                                                                                                                 
  list1.searchByName ("Nancy", "Garcia");                                                                                                                                            
  list1.searchByName ("Jamie", "Garcia");                                                                                                                                            
                                                                                                                                                                                     
  list1.updateNumber ("Nancy", "Garcia", "989-876-1234");                                                                                                                            
  list1.updateNumber ("Jamie", "Garcia", "345-467-1234");                                                                                                                            
  */
  list1.removeRecord ("Mayssaa", "Najjar");  return 0;
}

[sesslit805]

if someone can help me with searchbyname and updatenumber also that would be great.

[TheIdeasMan]

please help it compiles but it's not working

So you have these linker errors, that is after getting rid of extraneous braces:

/tmp/ccgvGRbT.o: In function `main': :(.text.startup+0x5f):
undefined reference to `LL::append(std::string, std::string, std::string)' :(.text.startup+0xf6):
undefined reference to `LL::insertAtBeginning(std::string, std::string, std::string)' :(.text.startup+0x18d):
undefined reference to `LL::append(std::string, std::string, std::string)' :(.text.startup+0x2c1):
undefined reference to `LL::insertAtBeginning(std::string, std::string, std::string)' :(.text.startup+0x34c):
undefined reference to `LL::removeRecord(std::string, std::string)'
collect2: error: ld returned 1 exit status

None of the functions you call in main actually have a function definition, so it's no great surprise that it's not working.

[sesslit805]

i compile it as g++ -std=c++11 lab12.cpp

[sesslit805]

and it compiles ...

[TheIdeasMan]

i compile it as g++ -std=c++11 lab12.cpp

That's an appallingly minimal compilation command, try this as a minimum:

g++ -std=c++11 -Wall -Wextra -pedantic-errors lab12.cpp

and it compiles ...

Yes but as I said you have linker errors, but much more importantly:

Repeat: None of the functions you call in main actually have a function definition, so it's no great surprise that it's not working.