Positive and Negative, Even and Odd

[celticqueenkira]

So I'm writing a program that asks to input an integer and the program tells if it's odd or even, negative or positive. For some reason, it'll get the pos/neg part right, but if it's negative, it outputs even and if it's positive it outputs odd. I can't figure out what is making it do this, and I've tried several while/ if-else statements. This is what I have right now.

#include <iostream>
#include <string>

using namespace std;


int main()
{
 
 int integer;
 int positive;
 int negative;
 int odd;
 int even;   
 char ynAns;
       
    //ask user for an integer
 cout << "Please enter an integer." << endl;
 cin >> integer;
 cout << "The integer you entered is " << endl;    

    if (integer < 0){
    integer = negative;
    cout << "negative " << endl;
    }        
    if (integer > 0){
    integer = positive;
    cout << "positive " << endl;
    }             
    if (integer == 0){
    integer = 0;
    cout << "zero." << endl;        
    }
    
    if ((integer % 2== 0) && (integer != 0)){
        integer = even;
        cout << "and even." << endl;
        }   
    else if ((integer !=0) && (integer != even)) {
        integer = odd;
        cout << "and odd." << endl;    
              }
     
 return 0;
}    

Any input will be appreciated. (I'm putting a "would you like to continue" in there, in case anyone wonders about the 'char ynAns')

[SamuelAdams]

int integer;
integer = even;

positive, negative, Even and Odd do not work for INT.

Remove all the lines where you put integer =

[gunnerfunner]

some suggestions for a shorter program:

#include <iostream>

int main()
{
    std::cout << "Enter number: ";
    int num{};
    std::cin >> num;//other input validation checks http://www.cplusplus.com/forum/beginner/206234/
    if (num != 0)
    {
        if (num % 2 == 0)
        {
            std::cout << ((num > 0) ? "Even and positive \n" : "Even and negative \n");
        }
        else
        {
            std::cout << ((num > 0) ? "Odd and positive \n" : "Odd and negative \n");
        }
    }
    else
    {
        std::cout << "The number is zero \n";
    }
}

[celticqueenkira]

positive, negative, Even and Odd do not work for INT.

Remove all the lines where you put integer =

That was my problem. Now it works seamlessly. Thank you!