Displays weirdcharacters when it runs. please help me ****

[sesslit805]

HI guys I don't know what's wrong with my code it compiles but when I run it I get so many question marks and random numbers and letters. I don't think it has anything with my code maybe the way I am compiling it? Please take a look at my code.

I have 4 other sub classes: Package.h, ExpressPackage.h, PriorityPackage.h and InternationalPackage.h but the error I belive is to be in my PackageInventory.cpp.

Please help.

 #include "PackageInventory.h"
#include <iostream>
#include <vector>
#include <string>
#include <fstream>

using namespace std;

PackageInventory::PackageInventory()
{}

void PackageInventory::CreateNewPackage(string senderN, string senderA, string senderC, string senderS, long senderZIP, string recipN, string recipA, string recipC, string recipS, \
long recipZIP, string L, string D, double W, double C, string insure)
{

  Package P(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP, L, D, W, C, insure);

  packages.push_back(P);

  for(int i=0; i<packages.size(); i++)
    {
      cout << packages[i].getSenderName();
    }
  //packages[i].print();                                                                                                                                                             

  //  packages.push_back(Package(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP, L, D, insure, W, C));                                      

}

void PackageInventory::CreateNewExpress(string senderN, string senderA, string senderC, string senderS, long senderZIP, string recipN, string recipA, string recipC, string recipS, \
long recipZIP,string L, string D, double W, double C,string insure,  double express )
{
  ExpressPackage EP(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP,L , D, W,C, insure,  express);

    expressPackages.push_back(EP);

    //  expressPackages.push_back(ExpressPackage(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP, L, D, insure, W, C, express));             
}

void PackageInventory::CreateNewPriority(string senderN, string senderA, string senderC, string senderS, long senderZIP, string recipN, string recipA, string recipC, string recipS,\
 long recipZIP, string L, string D, double W, double C, string insure,string t, double len, double wid, double hie )
{
  PriorityPackage PI(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP, L, D, W, C, insure, t, len, wid, hie );

  priorityPackages.push_back(PI);


}

void PackageInventory::CreateNewInternational(string senderN, string senderA, string senderC, string senderS, long senderZIP, string recipN, string recipA, string recipC, string re\
cipS, long recipZIP,string L, string D,  double W, double C, string insure, string count)
{
  InternationalPackage IP(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP,L, D, W, C, insure, count);
internationalPackages.push_back(IP);

}

void PackageInventory::PrintAllPackages()
{
  if(packages.empty())

      cout<<"There are no Packages"<<endl;
  else
    cout <<"\nPackages: ";

  cout << packages.size() << endl;

  for(int i=0; i<packages.size(); i++)
    {
      packages[i].printPackage();
      cout <<endl;
    }

}

void PackageInventory::PrintAllPriorityPackages()
{
 if(packages.empty())

      cout<<"There are no Packages"<<endl;
  else
    cout <<"\nPackages: ";

  cout << packages.size() << endl;

  for(int i=0; i<packages.size(); i++)
    {
      packages[i].printPackage();
      cout <<endl;
    }

}

void PackageInventory::PrintAllPriorityPackages()
{
  if(priorityPackages.empty())
    cout <<"There are no Priority Packages\n";

  else
    cout <<"\nPriority Packages: ";
  for(int i=0; i<priorityPackages.size(); i++)
    {
      priorityPackages[i].printPriority();
      cout <<endl;
    }
}

void PackageInventory::PrintAllExpressPackages()
{
  if(expressPackages.empty())
    cout <<"There are no Express Packages\n";

  else
    cout <<"Express Packages";
  for(int i=0; i<priorityPackages.size(); i++)
    {
      expressPackages[i].printExpress();
      cout <<endl;
    }
}

void PackageInventory::PrintAllInternationalPackages()
{
  if(internationalPackages.empty())
    cout << "There are no International Packages\n";

  else
    cout << "\nInternational Package(s): ";
  for(int i=0; i <internationalPackages.size(); i++)
    {
      internationalPackages[i].printInternational();
      cout <<endl;
    }
}

void PackageInventory::PrintAllShippedOnYear(string D)
{
  cout << "\nPackages Shipped on Specific Year: ";

  for (int i=0; i< packages.size(); i++)
    {
      if(D==packages[i].getDate())
        {
          packages[i].printPackage();
          cout <<endl;
        }
    }

}
void PackageInventory::CalculateTotalCost()
{

}

void PackageInventory::ProcessTransactionFile(string fileName)
{
  ifstream inputFile;
  string command;
  string senderN, senderA, senderC, senderS,recipN, recipA, recipC, recipS, L, D, insure, t, count;
  long senderZIP, recipZIP;
  double W,C, wid, len, hie, express;

  inputFile.open(fileName.c_str());

  if(!inputFile)
    cout <<"Error opening the transaction file.\n";

  else
    {

      while(inputFile >>command)
        {

          //      cout <<command << endl;                                                                                                                                            

          if (command== "CreateNewPackage")

 {
              inputFile>>senderN >> senderA>> senderC >> senderS >> senderZIP >> recipN >> recipA >> recipC >> recipS>> recipZIP>> L >> D >> W>> C>>insure;
              CreateNewPackage(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP, L, D,W,C, insure);
            }
          else if(command=="CreateNewExpress")
            {
              inputFile >> senderN >> senderA >> senderC >> senderS >> senderZIP >> recipN >> recipA >> recipC >> recipS >> recipZIP >> L >> D >> W>>C>>insure>>  express;

             CreateNewExpress(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP,L , D, W,C, insure,  express);
            }

          else if(command=="CreateNewPriority")
            {
              inputFile >>senderN >> senderA >> senderC >> senderS >> senderZIP >> recipN >> recipA >> recipC >> recipS >> recipZIP >> L >> D >> W >> C>> insure >> t >>len >> wid >\
> hie;

              CreateNewPriority(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP, L, D, W, C, insure, t, len, wid, hie );
            }
          else if(command=="CreateNewInternational")
            {
              inputFile >>senderN >> senderA >> senderC >> senderS >> senderZIP >> recipN >> recipA >> recipC >> recipS >> recipZIP >> L >> D >> W >> C >> insure>>count;

              CreateNewInternational(senderN, senderA, senderC, senderS, senderZIP, recipN, recipA, recipC, recipS, recipZIP,L, D,  W, C,insure, count);
            }
          else if(command=="PrintAllPackages")
            {
              PrintAllPackages();
 cout << endl;
            }
          else if (command=="PrintAllPriorityPackages")
            {
              PrintAllPriorityPackages();
              cout <<endl;
            }
          else if(command == "PrintAllExpressPackages")
            {
              PrintAllExpressPackages();
              cout <<endl;
            }
          else if (command=="PrintAllInternationalPackages")
            {
              PrintAllInternationalPackages();
              cout <<endl;
            }
          else if(command=="PrintAllShippedOnYear")
            {
              inputFile >>D;
              PrintAllShippedOnYear(D);
              cout <<endl;
            }
          else if(command== "CalculateTotalCost")
            {

            }
        }
      inputFile.close();
    }
}

Main:

#include <iostream>
#include <vector>
#include <string>
#include "PackageInventory.h"

using namespace std;

int main()
{

  PackageInventory  inventory;

  inventory.ProcessTransactionFile("TransactionFile.txt");
  //   inventory.PrintAllPackages();                                                                                                                                                 
  return 0;
}

[goldenchicken]

I don't immediately see what's wrong, but if it compiles, you can't call it a syntax error :-).
I hope you'll eventually find out.

[jlb]

Please post the contents of PackageInventory.h as well, also post samples of any and all sample files.

My first suggestion would be to try to reduce the number of parameters in most of your functions (consider helper structures) and try to reduce code duplication. Your variable naming could also use some work.

[sesslit805]

sorry

[jlb]

You're going to need to narrow the problem down a bit more. I suggest you first verify that you're reading each of your input files correctly. After you read a line print the line out, perhaps you should consider overloading both the extraction and insertion operators to aid in reading and printing the information for your classes. Remember one of the biggest sources of error are inputs.