Sockets - Server spamming (null)

[ExSanity]

The goal of this is for the client to connect send a message the server receive the message print the message in server console and then send the same message back to the client for the client to receive and it do it all over again yet when ever i put anything in the client it just spams in the sevrer (null)

Client Code

#include <stdio.h> 
#include <string.h> 
#include <stdlib.h> 
#include <unistd.h> 
#include <sys/socket.h> 
#include <sys/types.h> 
#include <netdb.h> 
#include <netinet/in.h> 
#include <arpa/inet.h>
#include <limits.h>
#include <errno.h>
#define RED     "\x1b[31m"
#define GRN   "\x1b[32m"
#define YEL  "\x1b[33m"
#define NRM   "\x1b[0m"

//Defining Variables



//Starting Code
int main(int argc, char *argv[]) {
//defining things
int sock, newsock, portno, binder, connector;
ssize_t bytes_read, bytes_written, writeintro;
struct sockaddr_in serv_addr, cli_addr;
struct hostent *server;
int yes = 1;
socklen_t clilen;
//Check to make sure correct syntax
if(argc < 3) {
    printf("\n%sUsage: <serveraddr> <portno>%s\n", RED, NRM);
    exit(0);
}
//Make the socket!
    sock = socket(AF_INET, SOCK_STREAM, 0);
    if (sock < 0 || sock == 0) {
        printf("\n%s Unable to create the Socket.", RED);
    };

//Define Ser.addr struct info
server = gethostbyname(argv[1]); 

if(server == NULL) {
    fprintf(stderr, "No such host.\n");
    printf("%s\n", strerror(errno)); 
    exit(EXIT_FAILURE);
}

portno = atoi(argv[2]);
serv_addr.sin_family = AF_INET;
memcpy(&serv_addr.sin_addr.s_addr, server->h_addr, server->h_length);
serv_addr.sin_port = htons(portno);
connector = connect(sock, (const struct sockaddr *) &serv_addr, sizeof(serv_addr));
if(connector < 0) {
    printf("\n%sConnection Failed%s", RED, NRM);
}
else { 
    printf("Made a connection to %s\n", inet_ntoa(serv_addr.sin_addr)); 
};
for (; ;) {
    ssize_t recver, sedner;
    char sendd[155], *recv;
    printf("Message: ");
    fgets(sendd, 155, stdin);
    sedner = write(sock, sendd, sizeof(send));
    recver = read(sock, recv, sizeof(recv));
    fprintf(stdout, "%s", recv);
}
}

Server Code

#include <stdio.h> 
#include <string.h> 
#include <stdlib.h> 
#include <unistd.h> 
#include <sys/socket.h> 
#include <sys/types.h> 
#include <netdb.h> 
#include <netinet/in.h> 
#include <arpa/inet.h>
#include <limits.h>
#include <errno.h>
#define RED     "\x1b[31m"
#define GRN   "\x1b[32m"
#define YEL  "\x1b[33m"
#define NRM   "\x1b[0m"

//Defining Variables



//Starting Code
int main(int argc, char *argv[]) {
//defining things
int sock, newsock, portno, binder, listener;
ssize_t bytes_read, bytes_written, writeintro;
struct sockaddr_in serv_addr, cli_addr;
struct hostent *server;
int yes = 1;
socklen_t clilen;
//Check to make sure correct syntax
if(argc < 3) {
    printf("\n%sUsage: <serveraddr> <portno>%s\n", RED, NRM);
    exit(0);
};
//Make the socket!
    sock = socket(AF_INET, SOCK_STREAM, 0);
    if (sock < 0 || sock == 0) {
        printf("\n%s Unable to create the Socket.", RED);
    };

//Define Ser.addr struct info
server = gethostbyname(argv[1]); 

if(server == NULL) {
    fprintf(stderr, "No such host.\n");
    printf("%s\n", strerror(errno)); 
    exit(EXIT_FAILURE);
};

portno = atoi(argv[2]);
serv_addr.sin_family = AF_INET;
memcpy(&serv_addr.sin_addr.s_addr, server->h_addr, server->h_length);
serv_addr.sin_port = htons(portno);
//Bind on socket//Error it
binder = bind(sock, (struct sockaddr *)&serv_addr, sizeof(serv_addr));
if(binder < 0) {
    printf("\n%sBinding Failed.%s", RED, NRM);
};
//Listen on Socket for Connection/Error it
listener = listen(sock, 20);
if(listener < 0) {
    printf("\n%s Failed to listen!%s", RED, NRM);
};

fprintf(stdout, "%s Waiting for a connection...%s", GRN, NRM);
//Accept the Socket/Error it
newsock = accept(sock, (struct sockaddr *) &cli_addr, &clilen);
if(newsock < 0) {
    printf("\n%sFailed to Accept the Connection%s", RED, NRM);
};
fprintf(stdout, "Connection!");
//On Connection (The Good Stuff)
//Recv first string (user) for broadcast.
ssize_t uname;
char data[155];
char format[155];
char joined[155] = "Connected on";
char *from = inet_ntoa(cli_addr.sin_addr);
ssize_t joinbcast;
//uname = read(newsock, data, sizeof(data));
//strcpy(data, format);
//strcat(format, joined);
//strcat(format, from);
//joinbcast = send(newsock, format, sizeof(format), 0);
for ( ; ;){
    char *recved, *send;
    ssize_t recvdata, senddata;
    recvdata = read(newsock, recved, sizeof(recved));
    if (recvdata == 0) {
        printf("\n%sClient closed the connection%s\n", RED, NRM);
    }
    fprintf(stdout, "%s", recved);
    senddata = write(newsock, recved, sizeof(recved));
};
close(newsock);
}

[SamuelAdams]

This is on windows ?

[ExSanity]

No, this is on Mac/Linux

[coder777]

The read functions in both Server(line 88)/Client(line 67) store the data to an invalid/uninitialized pointer which results in undefined behavior.

Both recv and recved needs to be either an array or otherwise allocated memory. Currently e.g. sizeof(recved) will be the size of the pointer.