Guidance with repitition statements

Hi everyone, I completed this assignment and was graded for it, so hopefully it's okay to post. The task was to alter a previous program to repeat if the user chooses to and then display total wins, total losses, and an average if the user chooses not to repeat the program. My code just seems really long and it took me awhile to complete, therefore I am seeking some guidance to condense my code and properly utilize the while statement. In particular, I get confused on placement of commands when I want something repeated that has an original statement with multiple choices and then multiple choices that can branch off from that original choice. I also realized that my code will not display the last win/loss because the choice to exit the loop does not include my counting of wins/losses.

-Thanks in advanced

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
// This program plays the classic scissor-rock-paper game
// The user will input a choice of scissor, rock, or paper
// The program will randomly choose scissor, rock, or paper
// This program will allow the user to play as many times as they want
// If the user wishes to stop playing, then total wins, loses, and average wins will be displayed

#include <iostream>
#include <ctime>
#include <string>
using namespace std;

int main()
{
	int Choice; // User's choice of scissor, rock, or paper
	int number; // The program's random choice of scissor, rock, or paper
	string choice2;
	double total, win, lose, average;

	total = 0;
	win = 0;
	lose = 0;

	do
	{
		total++;
		average = win / total;

		// Prompt user to enter choice
		cout << "Enter scissor (0), rock (1), paper (2): ";
		cin >> Choice;

		// Play game !
		if (Choice == 0)
		{
			// Random number seed
			srand((unsigned)time(0));

			// Generate a number between 0 to 2
			int number = (rand() % 3);

			if (number == 0)
			{
				cout << "The computer is scissor. You are scissor too. It is a draw." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
					continue;
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}

			else if (number == 1)
			{
				cout << "The computer is rock. You are scissor. You lose." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
				{
					lose++;
				}
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}
			else
			{
				cout << "The computer is paper. You are scissor. You win." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
				{
					win++;
				}
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}
		}

		else if (Choice == 1)
		{
			// Random number seed
			srand((unsigned)time(0));

			// Generate a number between 0 to 2
			int number = (rand() % 3);

			if (number == 0)
			{
				cout << "The computer is scissor. You are rock. You win." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
				{
					win++;
				}
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}

			else if (number == 1)
			{
				cout << "The computer is rock. You are rock. It is a draw." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
					continue;
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}
			else
			{
				cout << "The computer is paper. You are rock. You lose." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
				{
					lose++;
				}
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}
		}

		else if (Choice == 2)
		{
			// Random number seed
			srand((unsigned)time(0));

			// Generate a number between 0 to 2
			int number = (rand() % 3);

			if (number == 0)
			{
				cout << "The computer is scissor. You are paper. You lose." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
				{
					lose++;
				}
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}

			}
			else if (number == 1)
			{
				cout << "The computer is rock. You are paper. You win." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
					win++;
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}
			else
			{
				cout << "The computer is paper. You are paper. It is a draw." << endl;
				cout << "Do you want to play again? <y/n> : ";
				cin >> choice2;
				if (choice2 == "y")
					continue;
				else
				{
					cout << "You have played " << total << " times." << endl;
					cout << "You lost " << lose << " times." << endl;
					cout << "You won " << win << " times." << endl;
					cout << "Your winning average is " << average << endl;
				}
			}
		}

		else
			cout << "Invalid Input." << endl;

	} while (choice2 == "y");


	system("pause");
	return 0;
}
Last edited on
convert the user's input into an integer:
r=2, s = 1, p = 0

get the computer's move: rand()%3;

if (user * computer) //no one is paper
{
result = lose;
if (user > computer)
win
else if user == computer
draw;
}

else //someone is paper
{
//figure out who won for paper specific conditions, how simple can you make this?
//hint, if you renumber to s = 2, p=1, r= 0, which is (value+1)%3 for both pc and user...
//its pretty tight.
}



Last edited on
First, we know that win/lose and total can't be for example 1.5. So you should declare them as integers. Second let's see your logic. If i choose paper and pc chooses rock, then I will win only if I press y, to play again? So you should increment win or lose not in if(choice2=="y"), before that.After if(choice=="y") follows continue;
Topic archived. No new replies allowed.