C++

Forum

 
Snake game!!!

spax1111111 (56)
I set two if statements in the logic function in case i hit the wall or i eat a fruit represented with "F" but when i run my program nothing happens.Why?


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
 
#include<iostream>
#include<conio.h>
#include<string>
#include<cstring>
#include<cstdlib>
using namespace std;

bool gameOver;
const int width=20;
const int height=20;

int x,y,fruitX,fruitY,score; // x je glava a y je tijelo

enum direction{Stop=0,Left,Right,Up,Down};
direction dir;

void Setup()
{ 
  gameOver=false;
  dir=Stop;
  x=width/2; 
  y=height/2; 
  fruitX=rand()%width;
  fruitY=rand()%height;
  score=0;

}
void Draw()  
{ 
  system("cls");
  for(int i=0;i<width+1;i++)
  {
    cout<<"#";  
  }
  cout<<endl;
  
    for(int i=0;i<height;i++)
    {
	  for(int j=0;j<width;j++)
	  {
	    if(j==0)cout<<"#";
	    
	    if(i==y&&j==x) 
	    {
		  cout<<"O";   
		}
		else if(i==fruitY&&j==fruitX) 
		{
		  cout<<"F";  
		} 
		else cout<<" ";
		if(j==width-1)
		cout<<"#";  
	  }
	  cout<<endl;  
	}
  
  for(int i=0;i<width+1;i++)
  {
    cout<<"#";  
  } 
 cout<<endl;
 cout<<"Score: "<<score<<endl;
}

void Input()
{  
  if(_kbhit())
  {
    switch(_getch())
	{
	  case 'a':dir=Left;break;
	  case 'd':dir=Right;break;
	  case 'w':dir=Up;break;
	  case 's':dir=Down;break;
	  case 'x':gameOver=true;break;
	}  
  }

}
void Logic()
{  
  switch(dir)
  {
    case Left:
    	x--;
    	break;
    	
	case Right:
    	x++;
    	break;
    	
	case Up:
    	y--;
    	break;
    	
	 case Down:
    	y++;
    	break;
		default:
		break;
		
	if(x>width || x<0 || y>height || y<0)
	{  
	gameOver=true;	
	}	
	if(x==fruitX&&y==fruitY)
	{
	 score=score+10;
	 fruitX=rand()%width;
	 fruitY=rand()%height;  
	}	
				
		
  }
  
  
  
  
  
}

int main() // {  }  \  ||  ~
{
  
 Setup();
 while(!gameOver)
 {
   Draw();
   Input();
   Logic();  
 }
 
 
 

 return 0;  
}
Last edited on
Enoizat (1343)
Hi, spax1111111.
Did you solved your problem?
I can’t be of much help since I couldn’t get hold of a version of “conio.h”, but I installed ncurses on my Linux machine. Syntaxes are different, but I just meant to give you some hints, if I may.

Firstly, libraries like “ncurses” and “conio” want to ‘dominate’ the output window, so you are likely to come up against a lot of issues if you use std::cout to output your characters.
You should try to use the “conio” specific output functions, like “putch()”, “cputs()” and “cprintf()”.
In ncurses I had to substitute “printw()”, “mvaddch()”... for them.

Secondly, your rows 103-112
1
2
3
4
5
6
7
8
9
10
 
if(x>width || x<0 || y>height || y<0)
{  
gameOver=true;  
}   
if(x==fruitX&&y==fruitY)
{
 score=score+10;
 fruitX=rand()%width;
 fruitY=rand()%height;  
}

look as if they should be placed out of the switch block.

Thirdly, you don’t initialize srand(), so rand() always gives the same values.

Finally, the characters you are going to write by your line 41
if(j==0)cout<<"#";
will be overwritten from your code on line 51:
else cout<<" "

I know we are used to different styles of coding, but it would have taken me too long to adjust to your, so please consider my code as a simple suggestion. I stopped when I had a working Draw() function, so Input() and Logic() are still to be done.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
 
#include<ncurses.h>
#include<string>
#include<cstring>
#include<cstdlib>

bool gameOver;
const int width=20;
const int height=20;

int x, y, fruitX, fruitY, score; // x je glava a y je tijelo

enum direction{Stop=0,
               Left,
               Right,
               Up,
               Down};
direction dir;

void Setup();
void Draw();
void Input();
void Logic();


int main()
{
    Setup();
    // ======================================================================
    //        Ncurses specific commands
    initscr();  // Start ncurses mode
    noecho();   // Don't echo() while we do getch()
    raw();      // Disable line buffering
    // ======================================================================

    while(!gameOver)
    {
        Draw();
        Input();
        Logic();
    }

    // ======================================================================
    //        Ncurses specific commands
    endwin();   // End curses mode
    // ======================================================================

    return 0;
}

void Setup()
{
    gameOver=false;
    dir=Stop;
    x=width/2;
    y=height/2;
    fruitX=rand()%width;
    fruitY=rand()%height;
    score=0;
}

void Draw()
{
    clear();    // ncurses: clear the screen

    // Print a line of '#' at row 0
    for(int i=0; i<width+1; i++){
        addch('#');    // put one char into current cursor location
    }

    // Print a line of '#' at row 'height'
    move(height,0);
    for(int i=0;i<width+1;i++)
        addch('#');

    // First line (==0) already printed, we need to go on
    // to second line (==1)
    for(int i=1; i<height; i++) {
        for(int j=0; j<width; j++)
        {
            if(j==0){
                mvaddch(i,j,'#');
            } else if(i==y && j==x){
                mvaddch(i,j,'O');
            } else if(i==fruitY && j==fruitX) {
                mvaddch(i,j,'F');
            } else {
                mvaddch(i,j,' ');
            }
            if(j==width-1){
                mvaddch(i,j+1,'#');
            }
        }
    }
    mvprintw(height+1, width/2, "Score = %d", score);
    mvprintw(height+2, width/3, "fruitX = %d\tfruitY = %d", score,
             fruitX, fruitY);
}

void Input()
{
//    if(_kbhit())
//    {
//        switch(_getch())
//        {
//        case 'a':dir=Left;break;
//        case 'd':dir=Right;break;
//        case 'w':dir=Up;break;
//        case 's':dir=Down;break;
//        case 'x':gameOver=true;break;
//        }
//    }
    char userchoice;
    userchoice = getch(); // no need of ENTER because raw() already invoked
    switch (userchoice) {
    case 'a':
    case 'A':
        dir = direction::Left;
        break;
    case 'd':
    case 'D':
        dir = direction::Right;
        break;
    case 'w':
    case 'W':
        dir = direction::Up;
        break;
    case 's':
    case 'S':
        dir = direction::Down;
        break;
    case 'x':
    case 'X':
        gameOver = true;
        break;
    default:
        break;
    }
}

void Logic()
{
    switch(dir)
    {
    case Left:
        x--;
        break;

    case Right:
        x++;
        break;

    case Up:
        y--;
        break;

    case Down:
        y++;
        break;
    default:
        break;
    }
    if(x>width || x<0 || y>height || y<0)
    {
        gameOver=true;
    }
    if(x==fruitX&&y==fruitY)
    {
        score=score+10;
        fruitX=rand()%width;
        fruitY=rand()%height;
    }
}


My output:
#####################
#                   #
#                   #
#                   #
#                   #
#                   #
#  F                #
#                   #
#                   #
#                   #
#         O         #
#                   #
#                   #
#                   #
#                   #
#                   #
#                   #
#                   #
#                   #
#                   #
#####################
          Score = 0
      fruitX = 0        fruitY = 3


Good luck!
spax1111111 (56)
I just briefly looked your suggestions but definitely the rows 103-112 should go outside the switch :D your code looks pretty good thx a lot I think I will be able now to finish the game.
Topic archived. No new replies allowed.