operator overloading question

[jamesfarrow]

Is it better to do the following see 1st and second codes snippetts. They both 'do' the same thing.

  //oervload stream input operator
std::istream &operator>>( std::istream &input, Point &rhs ) {
    
    float local;
    
    std::cout << "Input x value: ";
    input >> local;
    while ( ! input ) {
        input.clear();
        input.ignore();
        std::cout << "Enter a number: ";
        input >> local;
    }
    rhs.setXValue( local );
    
    std::cout << "Input y value: ";
    input >> local;
    while ( ! input ) {
        input.clear();
        input.ignore();
        std::cout << "Enter a number: ";
        input >> local;
    }
    rhs.setYValue( local );
    
    return input;
}


//oervload stream input operator
std::istream &operator>>( std::istream &input, Point &rhs ) {
    
    //float local;
    
    std::cout << "Input x value: ";
    input >> rhs.xValue;
    while ( ! input ) {
        input.clear();
        input.ignore();
        std::cout << "Enter a number: ";
        input >> rhs.xValue;
    }
    //rhs.setXValue( local );
    
    std::cout << "Input y value: ";
    input >> rhs.yValue;
    while ( ! input ) {
        input.clear();
        input.ignore();
        std::cout << "Enter a number: ";
        input >> rhs.yValue;
    }
    //rhs.setYValue( local );
    
    return input;
}

[jonnin]

local does not really do anything for you. Better... either way.. you can argue that it is more readable with local. Not very convincingly, but one could argue it.

I am not a fan of weird operators. By weird, I mean, I would find it odd that


yourclass >> something;

would produce text prompts.

You would expect it to just move data silently.
For this type of function, I would have just called it "getdata" or "putdata" or something instead of trying to operator it.