Counters mess each other up

[turtleman1]

Hi again, hope I posted this correctly. I wrote some code to simply count words, lines and characters in a text file. But when i run this entire code the output is incorrect. If i only run the word counter i get the right answer; this also applies for lines. My character counter gives me a wrong output every time. How do I run this code without one counter messing up the other?

 #include <fstream>
#include <iostream>
#include <string>

using namespace std;

int main ( int argc, char *argv[] )
{
  
    ifstream the_file ( argv[1] );
    
    if ( !the_file.is_open() )
      cout<<"Cant open file";
    else {
        string lines;
      int l=0;
      while (getline(the_file, lines)) 
      {
        ++l;
         
      }
               
    string word;
	int w=0;
	while(!the_file.eof())
	{
		the_file >> word;
		w++;
        
    
    }
        int char_count = 0;
       char ch;

       while (!the_file.eof())
       {
              the_file >> ch;
           
           char_count++;
       }
          
        cout << l<<endl <<w<<endl <<char_count;
    }
}

output

< 78
< 0
< 0
\ No newline at end of file
> 78 330 1791 file2.txt

[ne555]

To count the lines you read the entire file. ¿In what part do you instruct the program to go back to the beginning to now count the words/characters?
Or instead of reading the file three times, you may process each line.

Also, don't loop on eof, loop on the reading operation
while( the_file >> word )

[turtleman1]

Ok, now i understand to go back to the beginning of the program.
The extra to the while statement is in case a file is empty. so it will return 0 0 0 because it was returning 0 1 1. but im still getting the character/letter counter wrong. can u see why? im getting 1790 when it should be 1791.
ps
thanks for the earlier comment. It helped me so much.

#include <fstream>
#include <iostream>
#include <string>

using namespace std;

int main ( int argc, char *argv[] )
{
  
    ifstream the_file ( argv[1] );
    
    if ( !the_file.is_open() )
      cout<<"Cant open file";
    else {
        string lines;
      int l=0;
      while (getline(the_file, lines)) 
      {
          
        ++l;
         
      }
        
the_file.clear();
the_file.seekg(0, ios::beg);
     
            
    string word;
	int w=0;
        
	while(true)
{
    
	if(the_file.peek() == -1)
		break;
        
		the_file >> word;
		w++;
		
 }
        
the_file.clear();
the_file.seekg(0, ios::beg);
        
	int number_of_chars = 0;
	char c;

	while(true)
{
    
	if(the_file.peek() == -1)
		break;

	c = the_file.get();
	

		++number_of_chars;
    
}
        
        cout << l<<endl <<w<<endl <<number_of_chars;
    }
}

output;
< 78
< 330
< 1790

[ne555]

learn to indent, that hurts to look at.

> The extra to the while statement is in case a file is empty. so it will
> return 0 0 0 because it was returning 0 1 1.
No, that's wrong.
Suppose that the file has only one character, an space ' '.

		while(true) {
			if(the_file.peek() == EOF) //it passes, there's an space
				break;
			the_file >> word; //this would execute (and fail)
			w++; //you've counted a word.
		}

Again, loop on the input operation.


However, for the characters it should be the same. Perhaps you see different in windows if the file ends with an end-of-line or not.
You may do while( the_file >> std::noskipws >> c ) instead.

[turtleman1]

I did peek the way above but still get one char less in my output, maybe The_file characters were counted incorrectly for this test case.

Thank you for all the helps :)