15 puzzles code not working properly

[tieuholy]

I don't know why when I prompt the user to enter the number to replace the '*', the entered number will replace the whole board.

#include <iostream>
#include <cstdlib>
#include <ctime>

using namespace std;

const int SIZE = 4;
const int BLANK_TILE = '*';
const int BOARD_SIZE = 16;

void displayBoard(int board[][SIZE]);
void shuffle(int board[][SIZE], int &blanki, int &blankj);
bool moveTile(int gameBoard[][SIZE], int &nextMove, int &blanki, int &blankj, int &i, int &j);
bool won(int gameBoard[][SIZE]);


int main() 
{
	
	int nextMove;
	int tempVal;
	int i,j;
	
    
   // TODO: create the game board

   int board [][SIZE]={1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,0};
   cout << "This is the board before shuffling: "<<endl;
   displayBoard(board);
     
   // TODO: shuffle tiles on board
   int blanki, blankj;
  cout << "Now this is the board after we shuffled: "<<endl;
  shuffle(board, blanki, blankj);
  displayBoard(board);
  
  //locate the blank space
	for (int m = 0; m< SIZE; m++)
	{
	  for (int n=0; n<SIZE; n++)
	  {
		  if (board[m][n]==0)
		  {
			  blanki=m;
			  blankj=n;
		  }
	  }
	}
//TO DO: prompt the user to input the move   
  do
  {
	  if(moveTile(board, nextMove, blanki, blankj, i, j)==true)
	  {
		  tempVal=board[i][j];
		  board[i][j]=board[blanki][blankj];
		  board[blanki][blankj]=tempVal;
		  
		  displayBoard(board);
	  }
	  
	  else 
	  {
		  cout <<"Location out of bounds"<<endl;
		  
		  displayBoard(board);
		  
			cout << "\n";
	  }
// TODO: play the game until the user wins!
  }
  while (!won(board));
  
  cout <<"Congratulations, you finish the board"<<endl;
    
    return 0;
}

void displayBoard (int board[][SIZE])
{
	for (int i =0; i<SIZE; i++)
	{
		for (int j=0; j<4; j++)
		{
			if(board[i][j] == 0)
			{
				cout <<"*";
			}
			else
			{
			cout << board[i][j]<<" ";
			}
		}
        cout << endl;   
	}
}
void shuffle(int board[][SIZE], int &blanki, int &blankj)
{
	int temp;
	srand (time(0));
	
	for (int i =0; i<SIZE; i++)
	{
		for (int j=0; j< SIZE; j++)
		{
			int blanki = rand() % 4;
			int blankj =rand() % 4;
			
			temp = board[i][j];
			board[i][j] = board[blanki][blankj];
			board[blanki][blankj]=temp;
		}
	}
}
bool moveTile(int gameBoard[][SIZE], int &nextMove, int &blanki, int &blankj, int &i, int &j)
{	
	int tempVal;
	cout << "Input the number you want to swap with *: "<< endl;
	cin >> nextMove;
	
	for (int p=0; p<SIZE; p++)
	{
		for (int q=0; q<SIZE; q++)
		{
			if (gameBoard[p][q] = nextMove)
			{
				i=p;
				j=q;
			}
		}
	}
	
	if (i==0 && j==0)
	{
		if ((blanki==i && blankj==j+1)||(blanki==i+1 && blankj==j))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
					return true;
		}
		
		else 
			return false;
	}
		
	else if (i==0 && j==3)
	{
		if ((blanki==i && blankj==j-1)||(blanki==i+1 && blankj==j))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
		
				return true;
		}
		
		else 
			return false;
	}
	else if (i==3 && j==3)
	{
		if ((blanki==i-1 && blankj==j) || (blanki==i && blankj == j-1))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
		
			return true;
		}
		
		else 
			return false;
	}
	else if (i==3 && j==0)
	{
		if((blanki==i-1 && blankj==j) || (blanki==i && blankj==j+1))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
				return true;
		}
		
		else 
			return false;
	}
	
	else if ((i==0) && (j>0 && j<SIZE))
	{
		if((blanki ==i && blankj==j-1) || (blanki == i && blankj==j+1) || (blanki == i+1 && blankj==j))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
				return true;
		}
		
		else 
			return false;
	}
	
	else if ((i>0 && i<SIZE) && (j==0))
	{
		if((blanki== i-1 && blankj == j)|| (blanki==i+1 && blankj==j) || (blanki==i && blankj==j+1))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
				return true;
		}
		
		else 
			return false;
	}
	
	else if (( i>0&&i<SIZE) && (j==3))
	{
		if ((blanki==i-1 && blankj==j)||(blanki == i+1 && blankj==j)|| (blanki==i && blankj==j-1))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
				return true;
		}
		
		else 
			return false;
	}
	
	else if ((i=3)&&(j>0&&j<SIZE))
	{
		if((blanki==i&& blankj==j-1)|| (blanki==i&&blankj==j+1)|| (blanki==i-1&&blankj==j))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
				return true;
		}
		
		else 
			return false;
	}
	
	else if ((i>0&&i<3) && (j>0&&j<3))
	{
		if((blanki==i-1 &&blankj==j) || (blanki==i&&blankj==j+1) || (blanki==i&&blankj==j-1) || (blanki==i+1&&blankj==j))
		{
			tempVal=blanki;
			blanki=i;
			i=tempVal;
			
			tempVal=blankj;
			blankj=j;
			j=tempVal;
				return true;
		}
		
		else 
			return false;
	}

}	

	
bool won(int gameBoard[][SIZE])
{
	int count=1;
	for (int i=0; i<SIZE; i++)

		for (int j=0; j<SIZE; j++)
		{
			if (gameBoard[i][j]!=count)
				return false;
			count++;
		}
	
	return true;
}

[Mantorr22]

Line 124 :
if (gameBoard[p][q] = nextMove)

Should you use == instead of = ?

[tieuholy]

Thank you I already fixed that but I still work in a very weird way. But thank you for pointing that out for me though!

[TheIdeasMan]

Compilation warnings, as per cpp.sh:

96:38: warning: unused parameter 'blanki' [-Wunused-parameter]
96:51: warning: unused parameter 'blankj' [-Wunused-parameter]
In function 'bool moveTile(int (*)[4], int&, int&, int&, int&, int&)':
124:34: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
294:1: warning: control reaches end of non-void function [-Wreturn-type]

Warnings are your friend: turn on as many compiler warning options as you can.

Line 96: these variables are shadowed by the ones on lines 105 and 106

Line 124: as Mantorr22 says.

Line 294: if you are going to have an else if chain, always put a final else - it catches bad input. You could at least put a return statement there. But you probably want to do more: it's some sort of error.

Always initialise your variables to something. Wait until you have a sensible value to assign to it, and only do 1 per line.

Good Luck !!