what does this mean

[kg245407]

I just tried to compile my program and the only error I got was that it said line 98: function definition does not declare parameters. I am using g++ to compile

#include <iostream>
using namespace std;
        
class CheckingAccount  
{ 
public: 
        //constructors
        CheckingAccount(string name, double bal);
        
        CheckingAccount();
        
        void input();   
        
        //accessors
        double get_balance();
        string get_name();
        void make_deposit();
        void make_withdrawl();
                     
private:
        //account holder's full name
        string full_name;
                        
        //account holder's account balance
        double balance;
};
        
int main
{
        char choice;
        CheckingAccount account = new CheckingAccount;

        account.input();
        
        do{
                cout << "What would you like to do today?" << endl;
                     << "A- Display the account information" << endl;
                     << "B- Make a deposit" << endl;
                     << "C-Make a withdrawl" << endl;
                     << "D-Exit the program" << endl;
                cin >> choice;

                switch(choice){
                        case 'A':
                                cout << "Your name is " << account.get_name() << endl;
                                cout << "You have $" << account.get_balance() << " in your account" << endl;
                        break;
                        case 'B':
                                account.make_deposit();
                        break;
                        case 'C':
                                account.make_withdrawl();
                        break;
                        case 'D':
                                cout << "Exit Checking Account" << endl;
                        break;
                        default:
                                cout << "Not a valid choice" << endl;
                        break;
                }
        }while(choice != 'D');
        return 0;
}
                                
                        
CheckingAccount::CheckingAccount(string name, double bal)
{
        full_name = name;
        balance = bal;
}
                        
CheckingAccount::CheckingAccount()
{
        full_name = "";
        balance = 0.0;
}
                        
void CheckingAccount::input()
{
        cout << "Enter your full name: ";
        cin >> full_name;
        cout << "Enter your account balance: ";
        cin >> balance;
}                       

double CheckingAccount::get_balance()
{
        return balance;
}
                        
string CheckingAccount::get_name()
{
        return full_name;
}
 
void CheckingAccount::make_deposit()
{
        double deposit;
        cout << "How much do you want to deposit? $";
        cin >> deposit;  
        balance = balance + deposit;
}
                        
void CheckingAccount::make_withdrawl()
{
        double withdrawl;
        cout << "How much do you want to withdrawl? $";
        cin >> withdrawl;
        if(withdrawl > balance)
        {
                cout << "You do not have enough money in your account for the withdrawl";
        }else{
                balance = balance - withdrawl;
        }//end if
}

[kg245407]

line 98 in my program is line 28 on here

[Disch]

functions need a parameter list (parenthesis)

main is a function. Therefore it should have them:

int main() // <- give it parenthesis
{
  //...
}

[kg245407]

oh wow thanks duh! except now I am stuck in an infinite loop! any idea why?

[Zhuge]

Where is the infinite loop?

[kg245407]

it is occuring with the string in the CheckingAccount::input()
I can enter without spaces but when I uses spaces for the name it sends it into an infinite loop

[Zhuge]

I don't see any loop at all in the input() method. If you run it in a debugger and step through the code, how is it looping in input()?

[kg245407]

no its not looping in the input. Its looping through the main but it only loops through the main like that when the input is a string with spaces

[Zhuge]

The problem likely resides in the fact that cin>> will terminate when it hits a whitespace character or newline. Since you entered several spaces, cin>> hits the first one, exits and goes to the next cin>>, which immediately (before you can type any response) reads the space and exits as well. This probably repeats several times. I can't really see why it would loop forever at your while, however. Is "choice" getting assigned a space character or is it staying as uninitialized garbage?

[kg245407]

its getting a letter A, B, C, or D. and if I don't use cin>> for the string what can I use?

[Zhuge]

You should probably use getline(cin, my_string_name);.
That will read until an enter, and won't leave any extra newlines in the buffer either. The only thing is when you read that char with cin>>, it will leave a newline in the buffer that you'll have to toss or ignore.

[kg245407]

thanks!