Code not working

[Brad 08]

Hey, sorry for the late post. Wanted to see if anyone can help me figure out what I am doing wrong with this code. It's late and probally making some simple error. The code is mean to genertate diff random numbers and display them aswell as the min, max, average and order them from smallest to largest. Thanks for the help.

#include <iostream>
#include <math.h>
#include <cstdlib>
#include <cstring>
using namespace std;

int main()
{
	void generateRand(int[], int, int, int);
	bool search(int[], int, int);
	void printArray(int[], int);
	void bubblesort(int[], int, int);
	float m, mean;
	int data, length;
	
	m= (data, length) ;
	
	cout << "The mean of the values you entered is: " << m << endl;
	
	return 0;	
}	
	

void generateRand(int data[], int num, int min, int max)
{
	int a;
	min = 1;
	max = 1000;
	cout << "The 100 numbers generated will be between 1 and 1000 " << endl;
		
	a = rand()% 1000 +1;
	{
			
		for(int x=0; x < num; x++)
		{
			if(data[x]==a)
			{
				a = rand()% 1000 +1; //takes random number
				{
					x=0;
				}
			}
			data[x]=a;	
		}
	}
}

bool search(int data[], int l, int x) // search for x make sure stored in data
{
	int a;
	cout << endl;
	for(int x = 0; x < data[x]; x++)
	{
		if(data[x]==a)
		{
			a = rand()% 1000 +1; 
			{
				x=0;
			}
			
			return true;
		}
		else 
		{
			return false;
		}
	}
}

void bubblesort(int a[], int length, int x) //sort values least to greatest
{

    int swap;
    for(int x=1; x < length ; x++)
    
    {
    
        for( int j=0; j<(length-x);j++)
        {	
			if( a[j] > a [j+1] )
	        {	
				swap=a[j];
	            a[j] = a[j+1];
	            a[j+1]=swap;
	            cout << "check" <<endl;
            
        	}
        }
    }
}

void printArray(int data[], int length) // print values
{
    for(int x = 0; x < length ; x++)
    {
    	cout << " \n";
    	
        cout << "		    THE SORTED VALUES LEAST TO GREATEST!				" << endl;
        cout << "The values are:" << data[x] << endl;
        cout << "Max number:" << endl;
        cout << "Min number" << endl;
    }
}

float mean(int data[], int l)
{
	float sum=0,y=0;
	float average;
	

	for (int x=0; x<l ; x++)
	{
		y=data[x];
		sum+=y;	
	}
	
	average =  sum /l;
	return average;
	 
}

















/*bool search(int data[], int length, int x)
{
	int i,x;
	if (data[i]= a)
	{
		a = rand()% 1000 +1;
		{
			i=0;
		}
			return true;
	}
	else
	{
		return false;
	}
}
*/

[48T7M4Gy]

http://www.cplusplus.com/forum/beginner/202084/

[Brad 08]

Now that I look at it I guess i can implement the same idea. But now this part of the code isn't couting anything do you see a problem?

int main()
{
	void generateRand(int[], int, int, int);
	/*bool search(int[], int, int);
	void printArray(int[], int);
	void bubblesort(int[], int, int);
	float m, mean;
	int data, length;
	
	m= (data, length) ;
	
	cout << "The mean of the values you entered is: " << m << endl;
	*/
	return 0;	
}	
	

void generateRand(int data[], int num, int min, int max)
{
	int a;
	min = 1;
	max = 1000;
	cout << "The 100 numbers generated will be between 1 and 1000 " << endl;
		
	a = rand()% 1000 +1;
	{
			
		for(int x=0; x < num; x++)
		{
			if(data[x]==a)
			{
				a = rand()% 1000 +1; //takes random number
				{
					x=0;
				}
			}
			data[x]=a;	
		}
	}
}

[48T7M4Gy]

You may have seen a few posts from people who are happy to help where they can. But generally we aren't mindreaders and/or magicians.

So, the way to handle this is as follows:

1. You have posted your code - step 1 OK
2. State clearly what the problem is, what you expect it to do and what it's doing instead.
3. Include sample input and the erroneous output.

4. Stick to the same thread where possible, and this is no exception, instead of creating multiple threads. They are timewasters for all concerned.

We await 2 and 3. :)

[48T7M4Gy]

#include <iostream>

using namespace std;

void generateRand(int[], int);
void printArray(int[], int);
int lowest (int[], int);
double mean(int[], int);

int main()
{
    const int limit = 20;
    int data[limit] = {0};
    
    // Generate random data
    cout << "The " << limit << " numbers generated will be between 1 and 1000 " << endl;
    generateRand(data, limit);
    printArray(data, limit);
    
    //Determine minimum
    int least = lowest( data, limit);
    cout << "Least value: " << least << endl;
    
    //Determine average
    double average = mean(data, limit);
    cout << "Average: " << average << endl;
    
    return 0;
}

void generateRand(int array[], int num)
{
    
    for(int x = 0; x < num; x++)
    {
        array[x] = rand() % 1000;
    
    }
    return;
}

void printArray( int array[], int num)
{
    for(int i = 0; i < num; i++)
    {
        cout << i + 1 << '\t' << array[i] << endl;
    }
}

int lowest(int array[], int num)
{
    int min = 5000;
    
    for(int i = 0; i < num; i++)
    {
        if (array[i] < min)
            min = array[i];
    }
    
    return min;
}

double mean(int array[], int num)
{
    int sum = 0;
    for (int i = 0; i < num; i++)
        sum += array[i];
    
    return sum / (double)num;
}