Sequential Ordering and Dynamic Arrays

[djr1599]

Hello, I keep getting errors with my code that I'm trying to produce. At the moment, it says I can't use MaxWords for the second parameter in the addInOrder function. I'm not sure if I produced this code correctly either, though the template is in the code below as well.

void histogram(const int MaxWords, istream& input, ostream& output)
{

    int nWords = MaxWords;
    string *words = new string[nWords];
  //* Declare an array of strings to hold all words
    int *wordCount = new int[nWords];
  //*   and an array of int to hold the number of times each word
  //*   encountered.

  // Read the words from the input and count them
  string word;
  while (input >> word)
    {
        insertionSort(words, nWords);

        for(int i=0;i < nWords; i++){
            reduceWords(words[i]);
           if (binarySearch(words, nWords, word) == true)
                wordCount[i]= wordCount[i]+1;
           else
                if (i < nWords)
           {
               addInOrder(words, nWords, word);
               wordCount[i] = wordCount[i]+1;
           }

           else
                if (i > MaxWords)
           {
                cerr<<"Input file contains more than "<<MaxWords<<" words.";
                exit(1);
           }
        }


      //* Reduce the word and, if any characters are left
      //* check to see if the word in already in our array

      //* If so, add one to that word's counter
      //* If not, is there room to add it to the array?

      //**  If so, add the word and a counter to the arrays, setting the
      //**     counter to 1.
      //**  If not, print the error message and abort the program [exit(1);]

    }


        for (int i = 0;i < MaxWords; i++)
            cout << words[i] << "," << wordCount[i]<<endl;
  //* Print all the words found, with their counts, in .csv format.


    delete [] words;
    delete [] wordCount;
  //* Clean up the arrays we created
}

template <typename T>
int addInOrder (T* array, int& size, T value)
{
  // Make room for the insertion
  int toBeMoved = size - 1;
  while (toBeMoved >= 0 && value < array[toBeMoved]) {
    array[toBeMoved+1] = array[toBeMoved];
    --toBeMoved;
  }

template <typename T>
int addInOrder (T* array, int& size, T value)
{
  // Make room for the insertion
  int toBeMoved = size - 1;
  while (toBeMoved >= 0 && value < array[toBeMoved]) {
    array[toBeMoved+1] = array[toBeMoved];
    --toBeMoved;
  }
  // Insert the new value
  array[toBeMoved+1] = value;
  ++size;
  return toBeMoved+1;
}

[Austin J]

I can't check it right now, but try changing your int& size to const int& size. You should be passing that reference as const anyways.

I'd change const int MaxWords to const int & MaxWords to.

[djr1599]

I edited my code a little, because I realized one of the other functions I was using prevented me from using the const int MaxWords since the addInOrder function edits the size when it uses ++size; in line 81. Now my program compiles, however it crashes before I can do anything.

[Austin J]

Post your main to be more informative please.

If you can, run your program through a debugger, it might be able to give you more information. It's hard to fix a crash in your program if you have no idea where it occurs let alone why.

[djr1599]

The Debugger isn't returning any errors for me, so I'm assuming it may have to do with how I have the exit(1) set up.

int main (int argc, char** argv)
{
  if (argc != 2 && argc != 4)
    {
      cerr << "Usage: " << argv[0] << " MaxWords [inFileName outFileName]" << endl;
      return -1;
    }

  int MaxWords = atoi(argv[1]);

  if (argc == 2)
    {
      // No file names in command line - use standard in and standard out
      histogram (MaxWords, cin, cout);
    }
  else
    {
      // Take input and output file names from the command line
      ifstream in (argv[2]);
      ofstream out (argv[3]);
      histogram (MaxWords, in, out);
    }

  return 0;
}

[djr1599]

I've learned that the error lies within the addInOrder function but can't figure out why.