C++

Forum

 
Program just displays all outputs and doesnt seem to execute code

adeclue (6)
Im not sure what im missing, or if i have something out of order. Were supposed to write a program that asks the user to enter a file name of a Random text file that we were provided that is just numbers.And validate that the file was opened. Once the user opens the file (Random.txt) successfully, the program should calculate the following:
A) The number of numbers in the file:
B) The even numbers in the file:
C) The odd numbers in the file:
D) The sum of all the numbers in the file:
E) The average of all the numbers in the file:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
 
  #include <cstdlib>
#include <cmath>
#include <iomanip>
#include <fstream>
#include<iostream>
#include<string>

using namespace std;

int main()

{

     // Declare Variables


     int num_value;
     int num_numbers;
     int even;
     int odd;
     double sum;
     double average;
     string randfilename;


     // Ask user for filename

     cout << "Enter the filename : \n";

    getline(cin,randfilename);

     // Open file to read the data

     ifstream inputFile(randfilename);

     // Check to verify file opened correctly

     if (inputFile.is_open())

     {

          cout<<"File opened successfully\n";

          // If File successfuly opened then the data is read and specified operations are run

         while (inputFile >> num_value)

         {

              cout << num_value << endl;

              num_numbers++;

              sum += num_value;

              if(num_value%2==0)
                         even++;

              else
                         odd++;

         }

     }

     else

     {

         //Display an error message

         cout << "Error opening the file\n";

     }



     if (num_numbers > 0)

         average = sum / num_numbers;

     else

         average = 0.0;

     cout << "Number of numbers: " << num_numbers << "\n";

     cout << "The even numbers are: " << even << "\n";

     cout << "The odd numbers are: " << odd << "\n";

     cout << "Sum is: " << sum << "\n";

     cout << "Average is: " << average;

     inputFile.close();



     return 0;

}
Thomas1965 (4571)
You need to initialize your variables before you use them. Afterwards it works.
Input file:
 
 
1 2 3 4 5

Output:
1
2
3
4
5
6
7
8
9
10
11
12
13
 
Enter the filename :
numbers.txt
File opened successfully
1
2
3
4
5
Number of numbers: 5
The even numbers are: 2
The odd numbers are: 3
Sum is: 15
Average is: 3
adeclue (6)
Below is what i get as a result when I try to run the program. I initialized my variables, but still get this output....I have a random.txt file on my desktop that I can open fine on its own. But it appears the program is not opening the file...


Enter the filename :
random.txt
Error opening the file
Number of numbers: 0
The even numbers are: 0
The odd numbers are: 0
Sum is: 0
Average is: 0
adeclue (6)
Figured it out, I didnt have the text file in the program folder... Thanks for your help
Topic archived. No new replies allowed.