Nearly finished Tic Tac Toe board

[dgood42]

This tic tac toe board I have made functions perfectly except for some reason I cannot get the 'X' and 'O' to switch, it always marks the spot 'O'. Even though I have been combing over the code for an hour and it seems like it should run smoothly :( I cant tell what the issue is. I am specifically refering to the bool markSpace function

  #include <iostream>
#include <vector>
#include <string>

using namespace std;


void createGameBoard(char bd[][3]);
void printBoard(char bd[][3]);
bool markSpace(char bd[][3], int row, int col);
bool gameOver(char game[][3], char &whoWon);



int main()
{
	char board[3][3];
	bool finished = false;
	int x, y;
	int count = 0;
	char winner = 'a';

	createGameBoard(board);
	printBoard(board);

	while (finished == false)
	{


		cout << "Enter X and Y coordinates in a 3x3 tic tac toe grid to play!" << endl;
		cout << "Enter an X coordinate 1-3 : ";
		cin >> x;
		cout << "Enter a Y coordinate 1-3: ";
		cin >> y;

		int realx = x - 1;
		int realy = y - 1;
		markSpace(board, realx, realy);
		if (markSpace(board, realx, realy) == true)
		{
			count++;
		}

		finished = gameOver(board, winner);
		printBoard(board);
	}
	if (finished == true && count < 9)
	{
		cout << "The winner is " << winner << "!" << endl;
	}
	else if (finished == false && count == 9)
	{
		cout << "You have a tie game" << endl;
	}


	return 0;
}
void createGameBoard(char bd[][3])
{
	for (int row = 0; row < 3; row++)
	{
		for (int col = 0; col < 3; col++)
		{
			bd[row][col] = '-';
		}
	}
}
void printBoard(char bd[][3])
{
	for (int row = 0; row <3; row++)
	{
		for (int col = 0; col < 3; col++)
		{
			cout << bd[row][col] << "\t";
		}
		cout << endl;
	}
}
bool markSpace(char bd[][3], int row, int col)
{

	static bool xTurn = true;

	xTurn = !xTurn;

	if (xTurn == true && bd[row][col] == '-')
	{
		bd[row][col] = 'X';
		system("CLS");

		return true;
	}
	else
	{
		bd[row][col] = 'O';
		system("CLS");

		return true;

	}

	system("CLS");
	return false;

}
bool gameOver(char game[][3], char &whoWon)
{
	char winner = 'a';

	if (game[0][0] != '-' && game[0][0] == game[1][1] && game[0][0] == game[2][2])
	{
		winner = game[0][0];
	}
	else if (game[2][0] != '-' && game[2][0] == game[1][1] && game[2][0] == game[0][2])
	{
		winner = game[2][0];
	}
	else
	{

		for (int row = 0; row <3; row++)
		{
			if (game[row][0] != '-' && game[row][0] == game[row][1] && game[row][0] == game[row][2])
			{
				winner = game[row][0];
				break;
			}
			else if (game[0][row] != '-' && game[0][row] == game[1][row] && game[0][row] == game[2][row])
			{
				winner = game[0][row];
				break;
			}
		}
	}
	if (winner == 'a')
	{
		return false;
	}
	else
	{
		whoWon = winner;
		return true;
	}
}

[SakurasouBusters]

1.
if (xTurn == true && bd[row][col] == '-')

Should be :
if (xTurn == true)

2.
static bool xTurn = true;

Should be :
static bool xTurn(false);

[dgood42]

Thank you for the help! I tried these changes and unfortunately it did nothing :/ still wont work. Tried separately and together

[cire]

Maybe get rid of line 38.

[dgood42]

Why line 38? thats my function to mark the space?

[SakurasouBusters]

You call markSpace(board, realx, realy) two times. That is why 'X' becomes 'O'.

[SakurasouBusters]

bool markSpace(char bd[][3], int row, int col)
{
	static bool xTurn = true;

	xTurn = !xTurn;

	if (xTurn == true && bd[row][col] == '-')
	{
		bd[row][col] = 'X';
		system("CLS");

		return true;
	}
	else
	{
		bd[row][col] = 'O';
		system("CLS");

		return true;

	}

	system("CLS");
	return false;

}

Should be :

static bool xTurn = false;
bool markSpace(char bd[][3], int row, int col)
{
	xTurn = !xTurn;

	if (xTurn == true)
	{
		bd[row][col] = 'X';
		system("CLS");

		return true;
	}
	else
	{
		bd[row][col] = 'O';
		system("CLS");

		return true;
	}
	system("CLS");
	return false;
}

[dgood42]

Thank you! I feel like a fool of a took. Didnt even notice I was double calling the function -__-

[cire]

Should be :

No, it shouldn't. There is no reason for xTurn to have a broader scope than markSpace if markSpace is the only piece of code that uses that particular state, and I would probably be adding a condition to the else before removing from the condition on the if. The modified function can never return false.