Linked List

[AndyGator]

I have to create a linked list, a stack, and a main to print out Hello World backwards. I am running into some problems with my code.

  Here is my Linked List
#include <iostream>
#include <cstddef>

using namespace std;

template <typename T>
class Node{
	private:
		T value;
		Node *next;

	public:

		Node();
		Node (T data);
		T remove();
		T getValue();
		Node* getNext();
		void setValue(T data);
		void setNext(Node *nextNode);

};

template <typename T>
Node<T>::Node(){

    next = NULL;

}

template <typename T>
Node<T>::Node(T data){

    value = data;
    next = NULL;


}

template <typename T>
T Node<T>::getValue(){

    return value;


}

template <typename T>
Node<T>* Node<T>::getNext(){

    return next;

}

template <typename T>
void Node<T>::setValue(T data){

    value = data;

}

template <typename T>
void Node<T>::setNext(Node *nextNode){

    next = nextNode;

}

template <typename T> class MyLinkedList{
    private:
        Node<T> head;
        int size;

    public:
        MyLinkedList();
        void add(T val);
        T remove();
        void printContent();
        int getSize();
        bool empty();
};

template <typename T>
MyLinkedList<T>::MyLinkedList(){

    size = 0;
}

template <typename T>
void MyLinkedList<T>::add(T val){

     Node<T> current = head;
     Node<T> add = new Node<T>(val);


        while (current.getNext() != NULL){
               current = *(current.getNext());
        }

        current.setNext(new Node<T>(val));

}


template <typename T>
T MyLinkedList<T>::remove(){

     Node<T> current = head;

        while (current.getNext() != NULL){

            if( (current.getNext())->getNext() == NULL)
                break;
            else
               current = *(current.getNext());
        }
    Node<T> last = *(current.getNext());
    current.setNext(NULL);
    T value = last.getValue();
    delete &last;
    return value;
}

template <typename T>
void MyLinkedList<T>::printContent(){

    Node<T> current = head;
    while (current.getNext() != NULL){
            cout << current.getData() << " ";
               current = &(current.getNext());
        }
}

template <typename T>
int MyLinkedList<T>::getSize(){

    return size;
}

template <typename T>
bool MyLinkedList<T>::empty(){

    if ( size == 0)
            return true;
    else
        return false;
}


Here is MyStack

#include <iostream>
#include <cstddef>


using namespace std;


template <typename T> class MyStack{
        private:
            MyLinkedList<T> list;

        public:
            MyStack();
            T pop();
            void push(T value);
            bool isEmpty();
};

template <typename T>
MyStack<T>::MyStack(){

    list = new MyLinkedList<T>();
}
template <typename T>
T MyStack<T>::pop(){

    return list.remove();

}

template <typename T>
void MyStack<T>::push(T value){

    list.add(value);

}

template <typename T>
bool MyStack<T>::isEmpty(){

    return list.empty();

}

And my Main

#include <iostream>
#include "MyStack.cpp"
using namespace std;
int main()
{
    MyStack<char> stack;
    char a[] = {'H','E','L','L','O','W','O','R','L','D'};
    for (int i = 0; i < 10; i++){
        stack.push(a[i]);
    }
    for (int i = 0; i < 10; i++){

        cout << stack.pop();
    }

   return 0;
}

Thanks for your time

[AndyGator]

On line 162, I get the error 'MyLinkedList' does not name a type. On line 174, i get the errors: 'list' was not declared in this scope, expected type-specifier before 'MylinkedList' and expected ';' before 'MyLinkedList.' On line 179, 186 and 193, I get 'list' was not declared in this scope.

[jlb]

Why are you #including a .cpp file in main?

You need to #include the proper header file to use your MyLinkedList class.

P

[AndyGator]

Ahh, I see. What type of header file would let me use my list class?

[AndyGator]

After removing the .cpp file in main, I am only getting errors saying MyStack was not declared in this scope. Sorry if this is basic stuff but the computer science program at my school is ass. I still have the same errors in MyLinkedList

[jlb]

Post the complete error messages, all of them, exactly as they appear in your development environment. Those messages have important information embedded within them to aid in locating and fixing the problems.

What type of header file would let me use my list class?

The header file that defines and implements the class. If you don't understand basic header files you're probably going to have major problems understanding template classes. Maybe you need to review some of the basics before you try to tackle templates?

[AndyGator]

In function 'int main()':|
|6|error: 'MyStack' was not declared in this scope|
|6|error: expected primary-expression before 'char'|
|6|error: expected ';' before 'char'|
|9|error: 'stack' was not declared in this scope|
|13|error: 'stack' was not declared in this scope|
||=== Build failed: 5 error(s), 0 warning(s) (0 minute(s), 0 second(s)) ===|


MyStack:

|10|error: 'MyLinkedList' does not name a type|
|In constructor 'MyStack<T>::MyStack()':|
|22|error: 'list' was not declared in this scope|
|22|error: expected type-specifier before 'MyLinkedList'|
|22|error: expected ';' before 'MyLinkedList'|
||In member function 'T MyStack<T>::pop()':|
|27|error: 'list' was not declared in this scope|
||In member function 'void MyStack<T>::push(T)':|
|34|error: 'list' was not declared in this scope|
||In member function 'bool MyStack<T>::isEmpty()':|
|41|error: 'list' was not declared in this scope|
||=== Build failed: 7 error(s), 0 warning(s) (0 minute(s), 0 second(s)) ===|

[jlb]

|6|error: 'MyStack' was not declared in this scope|

Did you #include the header file that defines your MyStack class?

10|error: 'MyLinkedList' does not name a type|

Did you #include the header file that defines the MyLinkedList class?

[AndyGator]

For my main, my header file is now

#include 
<iostream>
#ifndef MyStack_h
#endif  MyStack_h 

and for my MyStack

#include <iostream>
#include <cstddef>
#ifndef MyLinkedList_H
#endif  MyLinkedList_H

error messages now read:
Main:
|4|warning: extra tokens at end of #endif directive [enabled by default]|
||In function 'int main()':|
|8|error: 'MyStack' was not declared in this scope|
|8|error: expected primary-expression before 'char'|
|8|error: expected ';' before 'char'|
|11|error: 'stack' was not declared in this scope|
|15|error: 'stack' was not declared in this scope|
||=== Build failed: 5 error(s), 1 warning(s) (0 minute(s), 0 second(s)) ===|

MyStack:

5|warning: extra tokens at end of #endif directive [enabled by default]|
|13|error: 'MyLinkedList' does not name a type|
||In constructor 'MyStack<T>::MyStack()':|
|25|error: 'list' was not declared in this scope|
|25|error: expected type-specifier before 'MyLinkedList'|
|25|error: expected ';' before 'MyLinkedList'|
||In member function 'T MyStack<T>::pop()':|
|30|error: 'list' was not declared in this scope|
||In member function 'void MyStack<T>::push(T)':|
|37|error: 'list' was not declared in this scope|
||In member function 'bool MyStack<T>::isEmpty()':|
|44|error: 'list' was not declared in this scope|
||=== Build failed: 7 error(s), 1 warning(s) (0 minute(s), 0 second(s)) ===|

[AndyGator]

||In instantiation of 'MyStack<T>::MyStack() [with T = char]':|
|6|required from here|
|23|error: no match for 'operator=' in '((MyStack<char>*)this)->MyStack<char>::list = (operator new(12u), (<statement>, ((MyLinkedList<char>*)<anonymous>)))'|
23|note: candidate is:|
|61|note: MyLinkedList<char>& MyLinkedList<char>::operator=(const MyLinkedList<char>&)|
|61|note: no known conversion for argument 1 from 'MyLinkedList<char>*' to 'const MyLinkedList<char>&'|


||In instantiation of 'void MyLinkedList<T>::add(T) [with T = char]':|
|35|required from 'void MyStack<T>::push(T) [with T = char]'|
|9|required from here|
|85|error: invalid conversion from 'Node<char>*' to 'char' [-fpermissive]|
|31|error: initializing argument 1 of 'Node<T>::Node(T) [with T = char]' [-fpermissive]|
||=== Build failed: 3 error(s), 5 warning(s) (0 minute(s), 0 second(s)) ===|