tokenizing issue

[hornet7288]

I am writing a program for class which takes an expression as input and then prints out the numbers in the expression and the symbols from the expression in order. So for example:

Input:

(5 * 30) + 4

What output should be:

5 30 4 ( * ) +

My output is:

5 3 0 4 ( * ) +

So I have everything figured out except how I should be keeping multiple digit numbers together. Any advice would be greatly appreciated!

#include <vector> 
#include <string>
#include <iostream>
#include<cctype>

using namespace std;

int main()
{
	string userIn;
	vector<char> numbers;
	vector<char> symbols;

	cout << "Enter an expression: ";

	getline(cin, userIn);
	
	//Adding each single user input char to a vector 
	vector<char> inputVector(userIn.begin(), userIn.end());

	//Dividing characters by number or symbol and placing them into two separate vectors 
	for (unsigned int i = 0; i < inputVector.size(); i++) {
		if (isdigit(inputVector[i])) {
				numbers.push_back(inputVector[i]);
		} else {
			if (!isspace(inputVector[i])) {
				symbols.push_back(inputVector[i]);
			}
		}
	}
	//Printing characters in number vector
	for (unsigned int i = 0; i < numbers.size(); i++) {
		cout << numbers[i] << " ";
	}

	//Printing elements in symbols vector
	for (unsigned int i = 0; i < numbers.size(); i++) {
		cout << symbols[i] << " ";
	}
	cout << endl;

    return 0;
}

[liuyang]

If you look at the loop at line 22, you're doing tokenization character by character, not word by word. That's why you get '3' '0' instead of "30".

[hornet7288]

Yea that was what I intended to do. Otherwise I am not sure how I would strip the symbols and digits apart.

[SakurasouBusters]

vector<char> numbers;

The correct direction is :
vector<int> numbers;

[LA48b7Xj]

#include <cctype>
#include <iostream>
#include <sstream>
#include <string>
#include <vector>

using namespace std;

int main()
{
    cout << "Enter an expression: ";

    string input;
    getline(cin, input);
    stringstream ss {input};

    vector<double> numbers;
    vector<char> symbols;

    for(char ch=ss.get(); ss; ch=ss.get())
    {
        if(isdigit(ch))
        {
            ss.putback(ch);
            double d;
            ss >> d;
            numbers.push_back(d);
        }
        else if(isgraph(ch))
            symbols.push_back(ch);
    }

    for(auto e : numbers)
        cout << e << ' ';

    for(auto e : symbols)
        cout << e << ' ';

    cout << endl;
}

[SakurasouBusters]

.

[hornet7288]

Thanks krako! Looks like stringstream was the way to go.