If Statements

[mclogical]

Hey,

I am trying to get the smallest and biggest number out of three numbers using if statements. My problem is that I keep getting an error that says I did not initialize the variables...

Error C4700 uninitialized local variable 'b' used
Error C4700 uninitialized local variable 'c' used

I am using visual studio

  #include <iostream>
using namespace std;

int main()
{

	double a, b, c;
	cout << "Please enter three numbers \n";
	cin  >> a, b, c;

	if ((a > b) && (a > c))
	{
		cout << a << " is the largest \n";
		if (b > c)
		{
			cout << c << " is the smallest";
	    }
		if (c > b)
		{
			cout << b << " is the smallest";
		}
    }
	
	if ((b > c) && (b > a))
	{
		cout << b << " is the largest \n";
		if (a > c)
		{
			cout << c << " is the smallest";
		}
		if (c > a)
		{
			cout << a << " is the smallest";
		}
	}

	if ((c > b) && (c > a))
	{
		cout << c << " is the largest \n";
		if (b > a)
		{
			cout << a << " is the smallest";
		}
		if (a > b)
		{
			cout << b << " is the smallest";
		}
	}

	return 0;

}

[E0p9LyTq]

Line 9, cin >> a, b, c; should be cin >> a >> b >> c;

It could be rewritten as:

cin >> a;
cin >> b;
cin >> c;

[Handy Andy]

Hello mclogical,

As I have read here many times always initialize your variables. Line 7
double a, b, c;would be better written:

double a = 0, b = 0, c = 0;
or
double a(0), b(0), c(0);
or
double a{ 0 }, b{ 0 }, c{ 0 };

any one of the three will work.

Andy