Just will not work!

[greengirl1968]

Can't figure out why this will not output report.

#include <fstream>  
#include <iostream>  
#include <iomanip>  
#include <vector>  
#include <string>  
using namespace std;  
const int invSize = 2;  
void getInventory(ifstream& infile, vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);  
void displayMenu(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);   
void sellItem(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);  
void itemSearch(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice); 
void printReport(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);  
int main()  
{  
vector<int> itemQuantity;  
vector<string> itemID;  
vector<string> itemName;  
vector<int> pOrdered;  
vector<int> pInStore;  
vector<int> pSold;  
vector<double> manufPrice;  
vector<double> sellingPrice;  
int itemNumber;  
ifstream infile;  
infile.open("C:\\inventory.txt");  
if (!infile)  
{  
cout << "C:\\inventory.txt not read." << endl;  
system("pause");
return 1;  
}  
getInventory(infile, itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  
displayMenu(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  
infile.close();  
return 0;  
}  
void getInventory(ifstream& infile, vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice)  
{  
unsigned int i;  
string line;  
for (i = 0; i < itemID.size(); i++)  
{  
infile >> itemID[i]   
>> itemName[i]   
>> pOrdered[i]   
>> manufPrice[i]   
>> sellingPrice[i];  
pInStore[i] = pOrdered[i];  
}
pSold[0] = 0;  
}  
void displayMenu(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice) 
{  
char outputResponce;  
cout << "Type 'C' to check whether or not an item is in stock." << endl;  
cout << "Type 'S' to sell an item to a customer." << endl;  
cout << "Type 'R' to print an inventory report." << endl;     
cin >> outputResponce;  
if (outputResponce == 'C' ||outputResponce == 'c')  
itemSearch(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  
if (outputResponce == 'S' ||outputResponce == 's')  
sellItem(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  
if (outputResponce == 'R' ||outputResponce == 'r')  
printReport(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  
}  
void sellItem(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice)  
{  
int amtBought;  
double cash;  
char verifyItem;  
int i;  
int itemNumber;  
for (i = 0; i < 5; i++)  
{  
cout << "What is being purchased? Input item number. ";  
cin >> itemNumber;                                     
i = itemNumber;  
if (i != -1)  
{  
cout << "Selling " << itemName[i] << ", at a costs of $" << sellingPrice[i]  
<< ".  OK ? (Y/N)" << endl;  
cout << endl;  
cin >> verifyItem;  
if (verifyItem == 'N' || verifyItem == 'n')  
{  
cout << "Enter what is being sold by item number? " << endl;  
cin >> itemNumber;  
}  
cout << "How many items are required? " << endl;  
cin >> amtBought;  
if (amtBought < 1)  
cout << "Number purchased!" << endl;  
else 
{  
if (pInStore[i] < amtBought)  
cout << "Item not available" << pInStore[i] << " can be sold." << endl;  
else 
{  
cout << "Total" << amtBought * sellingPrice[i] << endl;  
cout << "Funds tendered" << endl;  
cin >> cash;  
if (cash < (amtBought * sellingPrice[i]))  
{  
cout << "Insufficient funds tendered." << endl;  
continue;  
}  
else 
{  
pInStore[i] = pInStore[i] - amtBought;  
cout << "Return" << cash - (amtBought * sellingPrice[i]) << "change." << endl;  
}  
}  
}  
}  
}  
}  
void itemSearch(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice)  
{  
int number;  
cout << "Which would you like to check?" << endl;  
cout << endl;  
cin >> number;  
if (pInStore[number] > 0)  
cout << "Currently you have " << pInStore[number] << "of that item in house." << endl;  
}  
void printReport(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,    
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice)  
{  
unsigned int i;  
int totalItems = 0;  
double totalInventory = 0;  
cout << "Friendly Hardware Store" << endl << endl;  
cout << "itemID ItemName pOrdered pInStore pSold manufPrice sellingPrice" << endl;  
cout << fixed << showpoint;  
cout << setprecision(2);  
for (i = 0; i < itemID.size(); i++)  
{  
cout << left;  
cout << setw(15) << itemID.at(i);  
cout << setw(15) << itemName.at(i);  
cout << right;  
cout << setw(15) << pOrdered.at(i);  
cout << setw(15) << pInStore.at(i);  
cout << setw(15) << pSold.at(i);  
cout << setw(15) << manufPrice.at(i);  
cout << setw(15) << sellingPrice.at(i) << endl;  
totalInventory += pInStore.at(i) * sellingPrice.at(i);  
totalItems += pInStore.at(i);  
}  
cout << endl;  
cout << "Total Inventory: $" << totalInventory << endl;  
cout << "Total number of items in the store: " << totalItems << endl;  
}

[jlb]

How can you even begin to read that program without any indentation?
https://en.wikipedia.org/wiki/Indent_style

Have you considered using a vector of a structure or class that holds all the fields of each inventory item instead of all of those parallel vectors?

[Thomas1965]

How is the format of the file ?

[greengirl1968]

The parameters of the exercise force me to use parallel vectors. As far as reading it goes, I just find this way easier sorry. I will work on doing the indentation. The input file holds this data:
itemID itemName pOrdered pInStore pSold manufPrice sellingPrice
4444 Circular Saw 150 150 40 45.00 125.00
3333 Cooking Range 50 50 20 450.00 850.00

I hope this helps because I am having a bit of a time with the input file anyway. I am beginning to think this is the problem. This is my first shot at a program that uses an input file so I don't know for sure how it is messed up. Sorry so lame.

[greengirl1968]

My best attempt

#include <fstream>  
#include <iostream>  
#include <iomanip>  
#include <vector>  
#include <string>  

using namespace std;  

const int invSize = 2;  

void getInventory(ifstream& infile, vector<string> itemID, vector<string> itemName, 
vector<int> pOrdered, vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);  

void displayMenu(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);   

void sellItem(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);  

void itemSearch(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice); 

void printReport(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   
vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   
vector<double> sellingPrice);  

int main()  

{  

vector<int> itemQuantity;  

vector<string> itemID;  

vector<string> itemName;  

vector<int> pOrdered;  

vector<int> pInStore;  

vector<int> pSold;  

vector<double> manufPrice;  

vector<double> sellingPrice;  

int itemNumber;  

ifstream infile;  

infile.open("C:\\inventory.txt");  

if (!infile)  

    {  

     cout << "C:\\inventory.txt not read." << endl;  

     system("pause");

     return 1;  

    }  

getInventory(infile, itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  

displayMenu(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  

infile.close();  

return 0;  

}  

void getInventory(ifstream& infile, vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   

vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   

vector<double> sellingPrice)  

{  

unsigned int i;  

string line;  

for (i = 0; i < itemID.size(); i++)  
   
    {  
    
     infile >> itemID[i]   
   
     >> itemName[i]   
    
     >> pOrdered[i]   
   
     >> manufPrice[i]   
    
     >> sellingPrice[i];  
  
     pInStore[i] = pOrdered[i];  
    
    }

pSold[0] = 0;  

}  

void displayMenu(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   

vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   

vector<double> sellingPrice) 

{  

char outputResponce;  

cout << "Type 'C' to check if item is in stock." << endl;  

cout << "Type 'S' to sell an item." << endl;  

cout << "Type 'R' to print report." << endl;     

cin >> outputResponce;  

if (outputResponce == 'C' ||outputResponce == 'c')  

itemSearch(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  

if (outputResponce == 'S' ||outputResponce == 's')  

sellItem(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  

if (outputResponce == 'R' ||outputResponce == 'r')  

printReport(itemID, itemName, pOrdered, pInStore, pSold, manufPrice, sellingPrice);  

}  

void sellItem(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   

vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   

vector<double> sellingPrice)  

{  

int numPurch;  

double funds;  

char verify;  

int i;  

int itemNumber;  

for (i = 0; i < 5; i++)  

    {  

     cout << "Enter the item number of salls item. ";  

     cin >> itemNumber;                                     

     i = itemNumber;  

     if (i != -1)  

         {  

          cout << "Selling " << itemName[i] << ", at a costs of $" << sellingPrice[i]  

          << ".  OK ? (Y/N)" << endl;  

          cout << endl;  

          cin >> verify;  

          if (verify == 'N' || verify == 'n')  

            {  

             cout << "Enter what is being sold by item number? " << endl;  

             cin >> itemNumber;  

            }  

cout << "How many items are required? " << endl;  

cin >> numPurch;  

if (numPurch < 1)  

cout << "Number purchased!" << endl;  

else 

            {  

             if (pInStore[i] < numPurch)  

             cout << "Item not available" << pInStore[i] << " can be sold." << endl;  

             else 

                {  

                 cout << "Total" << numPurch * sellingPrice[i] << endl;  

                 cout << "Funds tendered" << endl;  

                 cin >> funds;  

                 if (funds < (numPurch * sellingPrice[i]))  

                    {  

                     cout << "Insufficient funds tendered." << endl;  

                     continue;  

                    }  

                     else 

                        {  

                         pInStore[i] = pInStore[i] - numPurch;  

                         cout << "Return" << funds - (numPurch * sellingPrice[i]) << "change." << endl;  

                         }  

                    }  

                 }  

              }  

           }  

        }  

   void itemSearch(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,   

   vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   

   vector<double> sellingPrice)  

       {  

        int number;  

        cout << "Which would you like to check?" << endl;  

        cout << endl;  

        cin >> number;  

        if (pInStore[number] > 0)  

        cout << "Currently you have " << pInStore[number] << "of that item in house." << endl;  

        }  

void printReport(vector<string> itemID, vector<string> itemName, vector<int> pOrdered,    

vector<int> pInStore, vector<int> pSold, vector<double> manufPrice,   

vector<double> sellingPrice)  

       {  

        unsigned int i;  

        int totalItems = 0;  

        double totalInventory = 0;  

        cout << "Friendly Hardware Store" << endl << endl;  

        cout << "itemID ItemName pOrdered pInStore pSold manufPrice sellingPrice" << endl;  

        cout << fixed << showpoint;  

        cout << setprecision(2);  

        for (i = 0; i < itemID.size(); i++)  

            {  

             cout << left;  

             cout << setw(15) << itemID.at(i);  

             cout << setw(15) << itemName.at(i);  

             cout << right;  

             cout << setw(15) << pOrdered.at(i);  

             cout << setw(15) << pInStore.at(i);  

             cout << setw(15) << pSold.at(i);  

             cout << setw(15) << manufPrice.at(i);  

             cout << setw(15) << sellingPrice.at(i) << endl;  

             totalInventory += pInStore.at(i) * sellingPrice.at(i);  

             totalItems += pInStore.at(i);  

            }  

        cout << endl;  

        cout << "Total Inventory: $" << totalInventory << endl;  

        cout << "Total number of items in the store: " << totalItems << endl;  

      }

[Thomas1965]

I ran your program and found the first problem at the getInventory function.
All the vectors you pass to this function are empty and so nothing is read at your for loop.
At the end you try to access and empty vector pSold[0] = 0;
Try to fix this first.

[dhayden]

The problem with your input file is that the "name" field can contain spaces. For example, given this input line:

4444 Circular Saw 150 150 40 45.00 125.00 

And this code:

     infile >> itemID[i]   
     >> itemName[i]   
     >> pOrdered[i]   
     >> manufPrice[i]   
     >> sellingPrice[i];  

The program will read "4444" into itemID[i] and then it will read "Circular" into itemName[i].
Next it tries to read "Saw" into pOrdered[i], but since pOrdered[i] is an int, the code fails.

There are some other problems with getInventory:
1. The loop won't execute as Thomas1965 said because upon entry, itemId.size() is zero.
2. If a line in the input is missing a field, you run the risk of having the program think that a record spans across two lines in the input. That would be a real problem to find.
3. The vectors need to be passed by reference. Actually you should pass the vectors by reference or const reference to ALL of your functions.
4. You say that

The input file holds this data:
itemID itemName pOrdered pInStore pSold manufPrice sellingPrice
4444 Circular Saw 150 150 40 45.00 125.00
3333 Cooking Range 50 50 20 450.00 850.00

but getInventory sets pInStore based on the number ordered and it sets sold to zero. So should pInStore and pSold be in the input file at all?

Here is a version of getInventory that assumes inventory.txt contains:

itemID pOrdered manufPrice sellingPrice itemName

void
getInventory(ifstream & infile, vector < string > &itemID, vector < string > &itemName,
             vector < int > &pOrdered, vector < int > &pInStore, vector < int > &pSold,
             vector < double > &manufPrice, vector < double > &sellingPrice)
{
    string id, name;
    int ordered;
    double mprice, sprice;
    unsigned lineNo=1;
    string line;
    while (getline(infile, line)) {
        istringstream is(line);
        // Now extract the data from the line. We use getline() to read the name
        // because it can contain spaces.
        if ((is >> id >> ordered >> mprice >> sprice) && getline(is,name)) {
            // It's a good record, append the data to the vectors
            itemID.push_back(id);
            itemName.push_back(name);
            pOrdered.push_back(ordered);
            manufPrice.push_back(mprice);
            sellingPrice.push_back(sprice);
            pInStore.push_back(ordered);
            pSold.push_back(0);
        } else {
            cout << "Invalid input at line " << lineNo << ":\n";
            cout << line;
        }
        ++lineNo;
    }
}

[greengirl1968]

This is hopeless, going back to ground zero.

Thanks all.

[dhayden]

You're actually pretty close to working code. It's messy because you have to use separate vectors for each field. I'd keep going with the code that you have.

[Handy Andy]

greengirl1968,

Don't give up yet, as dhayden says you are close. I just got it working a little while ago and it finally worked when I passed the vectors by reference. Although my read file solution is not as nice as dhayden's it solved the input problem for now until I come to understand how his works.

keep asking questions,

Andy

[greengirl1968]

Alright, I will give it another shot. Still getting error compiling with dhayden's code fix. I think I put it in the wrong place. Feeling stupid about now.

[greengirl1968]

Thank you both dhayden and Handy Andy. You have been very encouraging. At this point you are doing a good job of keeping me from smashing things.

[greengirl1968]

I just about have it! The input file looks good, and it will compile, but now I have got to get it from shutting down after I input for the first input statement. I am sure that I just have the fix between the wrong lines. Still things are looking up!

[Handy Andy]

greengirl1968,

Good to hear that you are making progress. But, I think both dhayden and I need to be thinking about the fact that the input file format may not be changeable which would make inputting a string with spaces a bit more involved.

I am still thinking about the file read using the original file layout that you showed us. It is one of those problems that will bug me for awhile.

Keep working hard,

Andy

[dhayden]

Greengirl1968, please post your current code AND input file.

[greengirl1968]

4444
150
150
0
45.00
125.00
Circular Saw
3333
50
50
20
450.00
850.00
Cooking Range

is my current input file ordered itemId, pOrdered, pInStore, pSold, manufPrice, sellingPrice, itemName.

[greengirl1968]

I am still trying to make the code from my best attempt posting work at present.

[jlb]

It now looks like all the items are on a line by themselves, is that correct?

[greengirl1968]

Yes, it seems to make more sense that way, and it has worked for me in the past.

[Handy Andy]

greengirl1986,

If you have the ability to set up the input file any way that is needed that will work.
Having the ability to put the itemName any where you would like means that you can put all the product information on one line and put itemName at the end. That makes reading the file much easier as long as each field is separated by at least a space.

Knowing this I can work on fixing the read file function.

Andy