C++

Forum

 
the while loop doesnt break. anyone knows why

alkisaek (2)
#include <iostream>
#include<string>
using namespace std;

int main()
{
string x="";
cout<<"please enter a word\n";
cin>>x;
int no=x.size();
while(no>=5)
{
cout<<"good\n";
cin>>x;
int no=x.size(); //i want the while loop to stop after entering
//a word for the second time which has no.
// less than 5 but it doesnt
}

cout<<"small word\n";

return 0;

}
closed account (48T7M4Gy)
Maybe something like this:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
 
#include <iostream>
#include<string>
using namespace std;

int main()
{
    string x="";
    cout<<"please enter a word\n";
    
    while(cin >> x && x.size() > 5)
    {
            cout<<"good\n";
    }

    cout<<"small word\n";

    return 0;
}
ne555 (10692)
1- Indent your code
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
 
#include <iostream>
#include <string>
using namespace std;

int main() {
	string x = "";
	cout << "please enter a word\n";
	cin >> x;
	int no = x.size();
	while(no >= 5) {
		cout << "good\n";
		cin >> x;
		int no = x.size(); // i want the while loop to stop after entering
		// a word for the second time which has no.
		// less than 5 but it doesnt
	}

	cout << "small word\n";

	return 0;
}


a- Compile with warnings enabled
$ g++ -W{all,extra,pedantic} foo.cpp
foo.cpp: In function ‘int main()’:
foo.cpp:13:7: warning: unused variable ‘no’ [-Wunused-variable]
¿why does it say that `no' is unused when it is part of the condition in line 10?
Because it is not the same variable. (check out: scope)
Line 13 is declaring another variable, if you want to just assign to the one that you already have, then drop the type specifier. no = x.size();

\alpha- Just drop the `no' variable and use `x.size()' instead
closed account (E0p9LyTq)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 
#include <iostream>
#include <string>

int main()
{
   while (true)
   {
      std::string input = "";
      std::cout << "please enter text of five or more characters: ";
      std::getline(std::cin, input);

      if (input.size() < 5)
      {
         std::cout << "\nThe input was too small, try again please\n";
      }
      else
      {
         std::cout << "\nThank you....exiting....\n";
         break;
      }
   }
}


please enter a word of five or more characters: test

The input was too small, try again please
please enter a word of five or more characters: more test

Thank you....exiting....
Last edited on
alkisaek (2)
kemort, yours is correct. But why in mine after i input x with no. less than 5, it still stays in the loop?
closed account (48T7M4Gy)
But why in mine after i input x with no. less than 5, it still stays in the loop?
That's not what you have programmed it to do.
For instance if you type in 'four', no = 4, so the while test fails and you go straight to your line cout<<"small word\n";

please enter a word
four
small word
 
Exit code: 0 (normal program termination)
Last edited on
MikeyBoy (5631)
People have kindly taken the time and effort to explain why, in their replies to this thread. If you actually read those replies, you'd know the answer.
Topic archived. No new replies allowed.