help with functions

[taintedrogue]

The problem i am having is, how do i print win lost and draw without having -1,0,1 at end of it? also why does it double print win lost or draw when i have the if statement that keeps count

#include <iostream>
#include <cstdlib>
using namespace std;

int main(){
int outcome (int,int);
int newDieValue(int & ,int & );

int die1,die2;
int win =0 ,lost =0, draw= 0; //my counter

for (int i=0 ; i < 3 ; i++){ //start of for loop
cout << "\nPlease enter first die \n";
cin >> die1;

cout << "Please enter second die\n";
cin >> die2;

 //check if numbers entered are valid
/*****************************************************************/
while ((die1 < 1 || die1 > 6) || (die2 < 1 || die2 > 6) )
{
cout << "\nInvalid die , Please reenter a number from 1-6\n";

cout << "\nPlease enter first die \n";
cin >> die1;

cout << "Please enter second die\n";
cin >> die2;
}
/******************************************************************/

cout <<"\nDie one is : "<< die1 << endl << "Die two is : "<< die2 <<endl; //Prints result of dice

cout << outcome (die1, die2)<<endl;

//keeps stats of wins lost and draw
if (outcome(die1,die2) == 1)
    win++;

else if (outcome(die1,die2) == -1)
    lost++;

else if(outcome(die1,die2) ==0)
      draw++;
else;


//uses function to get new die value

 newDieValue( die1, die2);

cout <<"\nDie one is : "<<die1 <<endl << " Die two is : "<<die2<<endl;

cout  << outcome(die1,die2);



}//end of for loop


cout << "\n You won : "<< win << endl;
cout << " You lost  :"<< lost <<endl;
cout << "You draw  : "<< draw <<endl;
return 0;
}




/**********************************************/
//Function to calculate new value
int newDieValue(int &die1,int &die2){

   die1=die1 + 2;
  if (die1 > 6 ){
    die1 = die1 -6;
    return die1;
  }

  die2= die2 + 3;
  if (die2 > 6 ){
    die2 = die2 - 6;
  return die2;
  }



}


/************************************************************/
//Check to see if you win lose or draw
int outcome (int die1,int die2){
 int total = die1 + die2;
 const int win = 1, lose = -1 , draw = 0;

if (total == 7){
    cout << " you win\n";
    return win;
}

else if (total == 5){
    cout << " you win\n";
    return win;
}

else if (total == 12){
    cout << " you win\n";
    return win;
}

else if (total == 2){
    cout << " you lose\n";
    return lose;
}
else if (total == 4){
    cout << " you lose\n";
    return lose;
}
else if (total == 11){
    cout << " you lose\n";
    return lose;
}
else {
    cout << " you draw\n";
    return draw;
}

}//end of function

[nuderobmonkey]

Instead constants fo win/lost/draw you could use an enum.
newDieValue() is not valid because sometimes it fails to return a value. I gues that's causing the mailfunction.

Here I have a suggestion how the program could be with an enum, and in outcome() there is now a 'switch' directive.

#include <iostream>
#include <cstdlib>
using namespace std;

// using an enumeration instead some constants
enum Result {
    WIN,
    LOST,
    DRAW };

int main(){
    int outcome (int,int);
    int newDieValue(int & ,int & );

    int die1, die2;
    int win = 0 ,lost = 0, draw = 0; //my counter

    for (int i=0 ; i < 3 ; i++){ //start of for loop
        cout << "\nPlease enter first die \n";
        cin >> die1;

        cout << "Please enter second die\n";
        cin >> die2;

        //check if numbers entered are valid
        /*****************************************************************/
        while (die1 < 1 || die1 > 6 || die2 < 1 || die2 > 6 )
        {
            cout << "\nInvalid die , Please reenter a number from 1-6\n";

            cout << "\nPlease enter first die \n";
            cin >> die1;

            cout << "Please enter second die\n";
            cin >> die2;
        }
        /******************************************************************/

        cout <<"\nDie one is : "<< die1 << endl << "Die two is : "<< die2 <<endl; //Prints result of dice

        cout << outcome (die1, die2)<<endl;

        //keeps stats of wins lost and draw
        if (outcome(die1,die2) == WIN)
            win++;
        else if (outcome(die1,die2) == LOST)
            lost++;
        else if(outcome(die1,die2) == DRAW)
          draw++;

        //uses function to get new die value
        newDieValue( die1, die2);

        cout <<"\nDie one is : "<<die1 <<endl << " Die two is : "<<die2<<endl;
        cout  << outcome(die1,die2);
    }//end of for loop


    cout << "\n You won : "<< win << endl;
    cout << " You lost  :"<< lost <<endl;
    cout << "You draw  : "<< draw <<endl;
    return 0;
}
/**********************************************/
//Function to calculate new value
int newDieValue(int &die1,int &die2){

    die1 += 2;
    if (die1 > 6 ){
        die1 -= 6;
        return die1;
    }

    die2 =+ 3;
    if (die2 > 6 ){
        die2 -= 6;
        return die2;
    }
    // !!b return statement missed !!
}


/************************************************************/
//Check to see if you win lose or draw
Result outcome (int die1,int die2)
{
    int total = die1 + die2;
    
    switch (total) {
        case 7:
        case 5:
        case 12:
            cout << " you win";
            return WIN;
            
        case 2:
        case 4:
        case 11:
            cout << "you lose";
            return LOST;
            
        default:
            cout << "you draw";
            return DRAW;
    }
}//end of function

[nuderobmonkey]

I looked closer at your newDieValue(). Perhaps is this what you want to do:

void newDieValue(int &die1,int &die2){

    die1 += 2;
    if (die1 > 6 ) die1 -= 6;

    die2 =+ 3;
    if (die2 > 6 ) die2 -= 6;
}

[taintedrogue]

sorry the delay and thank you.