Number never found

[roots]

The number is never found. I'm not sure what the deal is here.

#include <iostream>
#include "Header1.h"
#include <iomanip>
using namespace std;


int main() {


	int numberChoice;
	bool which;
	listOfNumbers num;
	initialize(num);
	assign(num);
	print(num);
	cout << endl << "Pick a number to find..." << endl;
	cin >> numberChoice;
	numberChoice = choice(num, numberChoice);


	if (numberChoice == -1) {
		cout << "Number not found..." << endl;
	}
	else {
		cout << "Number Found!!!! : " << numberChoice;
	}

	return 0;
}

void initialize(listOfNumbers& p) {

	p.arrayLength = 60;
	for (int i = 0; i < p.arrayLength; i++) {
		p.array[i] = 0;
	}

}
void assign(listOfNumbers& p) {
	for (int i = 0; i < p.arrayLength; i++) {
		p.array[i] = i+1;
	}
}
void print(listOfNumbers& p) {
	for (int i = 0; i < p.arrayLength; i++) {

		if (i % 6 == 0) {
			cout << endl << endl;
		
			
		}
		cout << setw(4) << p.array[i] << "  ";
	}
}
int choice(listOfNumbers& p, int numberChoice) {

	int i;
	bool which = false;
	for (i = 0; i < p.arrayLength; i++) {
		p.array[i];
		if (p.array[i] == numberChoice) {
				which = true;
				break;
			}
			if (which == true) 
				return i;
			
			else 
				return -1;
			
		}

}

[cire]

Your for loop that begins on line 59 will never repeat. This function will either return nothing, resulting in undefined behavior when you use the result it didn't return or return -1. There is no other possibility given the logic in the function.

[Arslan7041]

Your choice function is faulty.

If the first if-condition is false, the function will immediately return -1 in the first iteration of the loop.

If the first if-condition happens to be true on the first iteration, then 'which' is assigned true, and the break statement that follows will break you out of the for-loop. Thus, the return statement on line 66 will never be executed.

Try this:

int choice(listOfNumbers& p, int numberChoice) {

	int i;
	for (i = 0; i < p.arrayLength; i++) {
	     if (p.array[i] == numberChoice) {
			return i;            // if number found, simply return index
	      }
         }
		
         return -1; // if we made it outside of the loop, number was never found, so return -1. 

}

[roots]

I see. I've got to work on thinking logically. I seem to make logic mistakes more than syntax. I guess that's just natural to make these mistakes.
Thanks dudes!