SFML - Sprite issue

I have a sprite sheet that has 4 animations with 4 frames each. The size of the .png is 128x192 so I believe each frame is 32x48 pixels spaced evenly. I have been getting an issue where the sprite displays the next frame alongside it's current frame for the second and third frame in the animation.

To help better visualise it:

Frame 1 - Frame 1 shows
Frame 2 - Frame 2 shows and Frame 3 also shows to it's right
Frame 3 - Frame 3 shows and Frame 4 also shows to it's right
Frame 4 - Frame 4 shows

So when the animation plays I get this ugly double glitch in the middle.

It seems as if too much of the texture is being shown(I can't seem to size the sprite in SFML).

Everything works fine apart from the double sprite glitch.

Here is the code I think is most likely at fault:


class Animation
{
private:
    std::string name;
    std::vector<sf::IntRect> frames;
    sf::Clock clock;
    sf::Time frame_length;
    size_t current_frame;
    bool is_playing;
public:
    Animation(std::string n, sf::Time fl): name(n), frame_length(fl), current_frame(0), is_playing(0) {}
    void AddFrame(int sx, int sy, int fx, int fy) { frames.push_back(sf::IntRect(sx,sy,fx,fy)); }
    void Update()
    {
        if(!is_playing) return;
        if(clock.getElapsedTime() < frame_length) return;
        if(current_frame+1 >= frames.size()) current_frame = 0;
        else current_frame++;
        clock.restart();
    }
    sf::IntRect& GetCurrentFrame() { return frames[current_frame]; }
    void Start()
    {
        if(!is_playing)
        {
            is_playing = true; clock.restart();
        }
    }
    void Stop() { if(is_playing) is_playing = false; current_frame = 0; }
    const bool IsPlaying() { return is_playing; }
};


// IN MAIN

...

    // Attempting to get the first strip of frames
    // The PNG size is 128x192 with 16 images
    // I have deduced that each image is 32x48
    Animation animation("walking_south",sf::milliseconds(250));
    for(unsigned int x = 0; x < texture_handler.GetTexture(0).getSize().x; x+=32)
        animation.AddFrame(x,0,x+31,47);

    // Create drawable sprite
    sf::Sprite sprite(texture_handler.GetTexture(0),animation.GetCurrentFrame());
    sprite.setOrigin(sprite.getOrigin().x+16,sprite.getOrigin().y+24);
    sprite.setPosition(sf::Vector2f(0,0));

...

        // Update section
        animation.Update();
        sprite.setTextureRect(animation.GetCurrentFrame());
        std::cout   << sprite.getTextureRect().left << " "
                    << sprite.getTextureRect().top << " "
                    << sprite.getTextureRect().width << " "
                    << sprite.getTextureRect().height << "\n";

        // Graphics rendering
        window.clear(sf::Color::White);
        window.draw(sprite);
        window.display();

Thanks in advance for any help guys, been tackling this since last night.

cire (8284)

animation.AddFrame(x,0,x+31,47);
=>
animation.AddFrame(x, 0, 32, 48);

The third and fourth parameter are width and height, respectively.

megatron 0 (471)

Legend mate.

So the IntRect() third and fourth arguments are respective to the first 2? Makes sense, I was trying to pinpoint each corner of the frame.

Thanks a bunch Cire.

EDIT: Bloody hell, width and height of course. I was looking at some other SFML version where it was "Top, Left, Right and Bottom". God damn you internet.

Last edited on

Topic archived. No new replies allowed.

C++

Forum

SFML - Sprite issue