While loop

[igor96]

Hello, I have a problem with the while loop.

    while(!feof(f)) {
    ucitajStudente(f, &(studenti[brStudenta]));
    }

Instead of running the function until it is the end of the file, the loop is running infinity. Why?

Thanks,
Igor

[Thomas1965]

What does ucitajStudente do ? Do you actually read from the file ?

[igor96]

Yes, it's reading data from the .txt file

Here is the full code:

#include <stdio.h>
#define MAXVREDNOST 250

typedef struct prijemni{
	int brLista;
	int brPrijave;
	char ime[32];
	char prezime[32];
	double bodoviSrednja;
	int bodoviPrijemni;
	double bodoviUkupan;
} student;

//promenljive
student studenti[MAXVREDNOST];
int brStudenta = 0;

double ucitajStudente(FILE *f, student *s){
	fscanf(f, "%d %d %s %s %fl %d %fl", &(s->brLista), &(s->brPrijave), &(s->ime), &(s->prezime), &(s->bodoviSrednja), &(s->bodoviPrijemni), &(s->bodoviUkupan));
}

void stampajStudente(){
	int i;
	for(i=0; i<brStudenta;i++){
	printf(" %d %d %s %s %f %d %f", studenti[i].brLista, studenti[i].brPrijave, studenti[i].ime, studenti[i].prezime, studenti[i].bodoviSrednja, studenti[i].bodoviPrijemni, studenti[i].bodoviUkupan);
}
}

main(){
	
	FILE *f;
	f = fopen("prijemni.txt", "r");
	if (f==NULL){
		printf("Greska!");
		return -1;
	}
	
	while(feof(f)) {
		ucitajStudente(f, &(studenti[brStudenta]));
		brStudenta++;
	}
	
	
	stampajStudente();
	
	fclose(f);
	

}

[Naughty Albatross]

Hi,

while(feof(f)) {
		ucitajStudente(f, &(studenti[brStudenta]));
		brStudenta++;
	}

I am not very sure why this loops forever in the first place. Maybe your input file is empty (or your program doesn't have permission to access the file).

However, you may try this :

std::cout << ((!feof(f)) ? "Start reading..." : "Error : File is empty (EOF)") << "\n\n";

while(!feof(f)) {
		ucitajStudente(f, &(studenti[brStudenta]));
		brStudenta++;
	std::cout << "#" << brStudenta << " student(s) read" << std::endl; 
}

[Naughty Albatross]

Can you let us see the content of the file prijemni.txt?

Edit : Let us know your program output if there is one.

[igor96]

Yes, here is the prijemni.txt:

1 103 John Smith 39.14 60 99.14
2 183 John Doe 38.58 60 98.58
3 41 Bernard Ames 38.16 60 98.16
4 88 Timothy Morris 38.08 60 98.08
5 124 Christopher Moss 37.44 60 97.44
6 347 Tim Bitner 37.24 60 97.24

There is not program output, just a blank CMD window since while is running infinity.
Thanks

[Naughty Albatross]

Ok, did you really ran my solution?

Anyway, I have updated it. Let me know your output outcome.

[Naughty Albatross]

fscanf(f, "%d %d %s %s %fl %d %fl", &(s->brLista), &(s->brPrijave), &(s->ime), &(s->prezime), &(s->bodoviSrednja), &(s->bodoviPrijemni), &(s->bodoviUkupan));
It is not %fl. It is %lf. Also put a space character at the end of the format string, which tells fscanf() to eat any whitespace characters, including new-lines ('\n')

So :
fscanf(f, "%d %d %s %s %lf %d %lf ", &(s->brLista), &(s->brPrijave), &(s->ime), &(s->prezime), &(s->bodoviSrednja), &(s->bodoviPrijemni), &(s->bodoviUkupan));

[igor96]

Thank you so much, the fscanf part was the only problem.
It works now and I get my results. Thanks again!

Have a great day!

[Naughty Albatross]

Oh, glad it helped :)